config: update checkstyle config to adjust to eclipse-cs style and first commit that use it

Author: romani

config/checkstyle_checks.xml

@@ -276,6 +276,7 @@
             <property name="tokens" value="LAMBDA"/>
             <property name="allowSingleLineStatement" value="true"/>
         </module>
+        <!-- modified -->
         <module name="RightCurly">
             <property name="tokens" value="METHOD_DEF"/>
             <property name="tokens" value="CTOR_DEF"/>
@@ -284,17 +285,18 @@
             <property name="tokens" value="LITERAL_FOR"/>
             <property name="tokens" value="STATIC_INIT"/>
             <property name="tokens" value="LITERAL_WHILE"/>
-            <property name="tokens" value="LITERAL_CATCH"/>
             <property name="tokens" value="LITERAL_ELSE"/>
             <property name="tokens" value="LITERAL_FINALLY"/>
             <property name="tokens" value="LITERAL_IF"/>
-            <property name="tokens" value="LITERAL_TRY"/>
+            <property name="tokens" value="LITERAL_CATCH"/>
             <property name="tokens" value="ANNOTATION_DEF"/>
             <property name="tokens" value="ENUM_DEF"/>
             <property name="option" value="alone"/>
         </module>
+        <!-- modified -->
         <module name="RightCurly">
             <property name="tokens" value="LITERAL_DO"/>
+            <property name="tokens" value="LITERAL_TRY"/>
             <property name="option" value="same"/>
         </module>
 
@@ -487,15 +489,18 @@
         <!-- Imports -->
         <module name="AvoidStarImport"/>
         <module name="AvoidStaticImport"/>
+        <!-- disable till we sync import order with main project -->
+        <!--
         <module name="CustomImportOrder">
             <property name="customImportOrderRules"
                       value="STATIC###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE"/>
             <property name="standardPackageRegExp" value="^java\."/>
             <property name="specialImportsRegExp" value="^javax\."/>
-            <property name="thirdPartyPackageRegExp" value="^org\."/>
+            <property name="thirdPartyPackageRegExp" value="^(net|org)\."/>
             <property name="sortImportsInGroupAlphabetically" value="true"/>
             <property name="separateLineBetweenGroups" value="true"/>
         </module>
+        -->
         <module name="IllegalImport"/>
         <module name="ImportControl">
             <property name="id" value="ImportControlMain"/>
@@ -508,7 +513,7 @@
             <property name="path" value="^.*[\\/]src[\\/]test[\\/].*$"/>
         </module>
         <module name="ImportOrder">
-            <property name="groups" value="/^java\./,javax,org"/>
+            <property name="groups" value="/^java\./,javax,net,org"/>
             <property name="ordered" value="true"/>
             <property name="separated" value="true"/>
             <property name="option" value="top"/>
@@ -612,11 +617,12 @@
             -->
             <property name="severity" value="ignore"/>
         </module>
+        <!-- modified to adjut eclipse-cs style -->
         <module name="Indentation">
-            <property name="basicOffset" value="4"/>
+            <property name="basicOffset" value="2"/>
             <property name="braceAdjustment" value="0"/>
-            <property name="caseIndent" value="4"/>
-            <property name="throwsIndent" value="8"/>
+            <property name="caseIndent" value="2"/>
+            <property name="throwsIndent" value="4"/>
         </module>
         <module name="OuterTypeFilename"/>
         <module name="TodoComment">

config/suppressions.xml

@@ -5,4 +5,19 @@
     "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
 
 <suppressions>
+    <!-- conflict with header -->
+    <suppress id="commentStartWithSpace"
+             files=".*"
+             lines="1,19"/>
+    <!-- temporal suppression due to leak -->
+    <suppress checks="JavadocVariable"
+             files="XmlProfileWriter.java"
+             />
+    <suppress checks="MissingJavadocMethod"
+             files="XmlProfileWriter.java"
+             />
+    <!-- no need for non library projects -->
+    <suppress id="JavadocPackage"
+             files=".*"
+             />
 </suppressions>