Issue #277: update to Checkstyle 8.40

Author: Calixte

net.sf.eclipsecs.checkstyle/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry exported="true" kind="lib" path="checkstyle-8.39-all.jar" sourcepath="checkstyle-checkstyle-8.39.zip"/>
+	<classpathentry exported="true" kind="lib" path="checkstyle-8.40-all.jar" sourcepath="checkstyle-checkstyle-8.40.zip"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8">
 		<attributes>
 			<attribute name="maven.pomderived" value="true"/>

net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF

@@ -46,5 +46,5 @@ Export-Package: .,
  com.puppycrawl.tools.checkstyle.utils,
  org.apache.commons.beanutils;version="8.39.0"
 Bundle-ClassPath: .,
- checkstyle-8.39-all.jar
+ checkstyle-8.40-all.jar
 Automatic-Module-Name: net.sf.eclipsecs.checkstyle

net.sf.eclipsecs.checkstyle/build.properties

@@ -1,6 +1,6 @@
 bin.includes = META-INF/,\
                .,\
                license/,\
-               checkstyle-8.39-all.jar
+               checkstyle-8.40-all.jar
 jars.compile.order = .
 source.. = metadata/

net.sf.eclipsecs.checkstyle/checkstyle-8.39-all.jar renamed to net.sf.eclipsecs.checkstyle/checkstyle-8.40-all.jar

@@ -1,9 +1,5 @@
 Design.group = Class Design
 
-DesignForExtension.desc = Checks that classes are designed for extension. More specifically, it enforces a programming style where superclasses provide empty "hooks" that can be implemented by subclasses.<br/>\r\nThe exact rule is that nonprivate, nonstatic methods of classes that can be subclassed must either be\r\n<ul>\r\n<li>abstract or</li>\r\n<li>final or</li>\r\n<li>have an empty implementation</li>\r\n</ul>\r\nRationale: This API design style protects superclasses against being broken by subclasses. The downside is that subclasses are limited in their flexibility, in particular they cannot prevent execution of code in the superclass, but that also means that subclasses cannot corrupt the state of the superclass by forgetting to call the super method.
-DesignForExtension.name = Design For Extension
-DesignForExtension.ignoredAnnotations = Annotations which allow the check to skip the method from validation.
-
 FinalClass.desc = Checks that a class which has only private constructors is declared as final.
 FinalClass.name = Final Class
 

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/design/checkstyle-metadata.properties

@@ -4,18 +4,6 @@
 "http://eclipse-cs.sourceforge.net/dtds/checkstyle-metadata_1_1.dtd">
 <checkstyle-metadata>
     <rule-group-metadata name="%Design.group" priority="1000">
-
-        <rule-metadata name="%DesignForExtension.name" internal-name="DesignForExtension" parent="TreeWalker">
-            <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck" />
-            <description>%DesignForExtension.desc</description>
-            <property-metadata name="ignoredAnnotations" datatype="String"
-                default-value="Test,Before,After,BeforeClass,AfterClass">
-                <description>%DesignForExtension.ignoredAnnotations</description>
-            </property-metadata>
-            <quickfix classname="net.sf.eclipsecs.ui.quickfixes.design.DesignForExtensionQuickfix" />
-            <message-key key="design.forExtension" />
-        </rule-metadata>
-
         <rule-metadata name="%FinalClass.name" internal-name="FinalClass" parent="TreeWalker">
             <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck" />
             <description>%FinalClass.desc</description>

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/design/checkstyle-metadata.xml

@@ -11,7 +11,7 @@
     <name>Checkstyle Core Library Plugin</name>
 
     <properties>
-        <checkstyle.version>8.39</checkstyle.version>
+        <checkstyle.version>8.40</checkstyle.version>
     </properties>
     <build>
         <plugins>

net.sf.eclipsecs.checkstyle/pom.xml

@@ -85,7 +85,6 @@ public class ChecksTest {
         "com.puppycrawl.tools.checkstyle.checks.metrics.CyclomaticComplexityCheck",
         "com.puppycrawl.tools.checkstyle.checks.coding.DeclarationOrderCheck",
         "com.puppycrawl.tools.checkstyle.checks.coding.DefaultComesLastCheck",
-        "com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck",
         "com.puppycrawl.tools.checkstyle.checks.blocks.EmptyBlockCheck",
         "com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyForInitializerPadCheck",
         "com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyForIteratorPadCheck",

net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java

@@ -10,6 +10,6 @@
 	<classpathentry exported="true" kind="lib" path="lib/dom4j-2.1.3.jar"/>
 	<classpathentry exported="true" kind="lib" path="lib/snakeyaml-1.26.jar"/>
 	<classpathentry exported="true" kind="lib" path="lib/reflections-0.9.10.jar"/>
-	<classpathentry kind="lib" path="lib/checkstyle-8.39-all.jar"/>
+	<classpathentry kind="lib" path="lib/checkstyle-8.40-all.jar"/>
 	<classpathentry kind="output" path="target/classes"/>
 </classpath>

net.sf.eclipsecs.core/.classpath

@@ -8,7 +8,7 @@ Bundle-ClassPath: .,
  lib/dom4j-2.1.3.jar,
  lib/snakeyaml-1.26.jar,
  lib/reflections-0.9.10.jar,
- lib/checkstyle-8.39-all.jar
+ lib/checkstyle-8.40-all.jar
 Bundle-Activator: net.sf.eclipsecs.core.CheckstylePlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: Eclipse Checkstyle Project