fix or silence generics warnings

First I fixed all warnings that could be fixed by adding generic type
arguments. Only afterwards I silenced the remaining warnings (basically
in all the AST visit() methods which operate with the non generic JDT
API).

Author: Bananeweizen

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java

@@ -555,8 +555,9 @@ private static void processProperties(Element moduleElement, RuleMetadata module
               property.getPropertyEnumeration().addAll(provider.getOptions());
             } else if (Enum.class.isAssignableFrom(providerClass)) {
 
+              @SuppressWarnings("rawtypes")
               EnumSet<?> values = EnumSet.allOf((Class<Enum>) providerClass);
-              for (Enum e : values) {
+              for (Enum<?> e : values) {
                 property.getPropertyEnumeration().add(e.name().toLowerCase());
               }
             }

net.sf.eclipsecs.sample/src/net/sf/eclipsecs/sample/checks/MethodLimitQuickfix.java

@@ -20,6 +20,7 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
 
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       public boolean visit(MethodDeclaration node) {
 
         Javadoc doc = node.getJavadoc();

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java

@@ -675,7 +675,7 @@ private void newModule(ISelection selection) {
         boolean openOnAdd = CheckstyleUIPluginPrefs
                 .getBoolean(CheckstyleUIPluginPrefs.PREF_OPEN_MODULE_EDITOR);
 
-        Iterator it = ((IStructuredSelection) selection).iterator();
+        Iterator<?> it = ((IStructuredSelection) selection).iterator();
         while (it.hasNext()) {
           Object selectedElement = it.next();
           if (selectedElement instanceof RuleGroupMetadata) {
@@ -736,6 +736,7 @@ private void removeModule(ISelection selection) {
                 Messages.CheckConfigurationConfigureDialog_titleRemoveModules,
                 Messages.CheckConfigurationConfigureDialog_msgRemoveModules)) {
 
+          @SuppressWarnings("unchecked")
           Iterator<Module> it = ((IStructuredSelection) selection).iterator();
           while (it.hasNext()) {
             Module m = it.next();
@@ -806,7 +807,7 @@ private class MetaDataContentProvider implements ITreeContentProvider {
     public Object[] getElements(Object inputElement) {
       Object[] ruleGroups = null;
       if (inputElement instanceof List) {
-        ruleGroups = ((List) inputElement).toArray();
+        ruleGroups = ((List<?>) inputElement).toArray();
       }
       return ruleGroups;
     }
@@ -993,7 +994,7 @@ public String getColumnText(Object element, int columnIndex) {
      * {@inheritDoc}
      */
     @Override
-    public Comparable getComparableValue(Object element, int col) {
+    public Comparable<?> getComparableValue(Object element, int col) {
       if (element instanceof Module && col == 0) {
         return Severity.ignore.equals(((Module) element).getSeverity()) ? new Integer(0)
                 : new Integer(1);

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersAction.java

@@ -77,6 +77,7 @@ public void run(IAction action) {
 
     Object element = selection.getFirstElement();
 
+    @SuppressWarnings("cast")
     IFile file = (IFile) ((IAdaptable) element).getAdapter(IFile.class);
     if (file != null) {
 

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java

@@ -49,22 +49,23 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
 
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(Block node) {
 
         if (containsPosition(lineInfo, node.getStartPosition())) {
 
           if (node.getParent() instanceof Block) {
 
-            List statements = ((Block) node.getParent()).statements();
+            List<?> statements = ((Block) node.getParent()).statements();
             int index = statements.indexOf(node);
 
             statements.remove(node);
             statements.addAll(index, ASTNode.copySubtrees(node.getAST(), node.statements()));
 
           } else if (node.getParent() instanceof SwitchStatement) {
 
-            List statements = ((SwitchStatement) node.getParent()).statements();
+            List<?> statements = ((SwitchStatement) node.getParent()).statements();
             int index = statements.indexOf(node);
 
             statements.remove(node);

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java

@@ -133,6 +133,7 @@ private void bracifyIfStatement(IfStatement ifStatement) {
         }
       }
 
+      @SuppressWarnings("unchecked")
       private Block createBracifiedCopy(AST ast, Statement body) {
         Block block = ast.newBlock();
         block.statements().add(ASTNode.copySubtree(block.getAST(), body));

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java

@@ -51,6 +51,7 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
 
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(SwitchCase node) {
 
@@ -59,7 +60,7 @@ public boolean visit(SwitchCase node) {
           if (node.isDefault() && !isLastSwitchCase(node)) {
             SwitchStatement switchStatement = (SwitchStatement) node.getParent();
 
-            List defaultCaseStatements = new ArrayList();
+            List<ASTNode> defaultCaseStatements = new ArrayList<>();
             defaultCaseStatements.add(node);
 
             // collect all statements belonging to the default case

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableQuickfix.java

@@ -49,6 +49,7 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
           final int markerStartOffset) {
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(SingleVariableDeclaration node) {
         if (containsPosition(node, markerStartOffset) && !Modifier.isFinal(node.getModifiers())) {
@@ -60,6 +61,7 @@ public boolean visit(SingleVariableDeclaration node) {
         return true;
       }
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(VariableDeclarationStatement node) {
         if (containsPosition(node, markerStartOffset) && !Modifier.isFinal(node.getModifiers())) {

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java

@@ -47,6 +47,7 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
 
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(SwitchStatement node) {
         if (containsPosition(lineInfo, node.getStartPosition())) {

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java

@@ -56,6 +56,7 @@ protected ASTVisitor handleGetCorrectingASTVisitor(final IRegion lineInfo,
 
     return new ASTVisitor() {
 
+      @SuppressWarnings("unchecked")
       @Override
       public boolean visit(InfixExpression node) {
 
@@ -117,7 +118,7 @@ private void replaceNode(ASTNode node, ASTNode replacementNode) {
                     + property.substring(1);
             String setterMethodName = "set" + capitalizedProperty;
 
-            Class testClass = node.getClass();
+            Class<?> testClass = node.getClass();
 
             while (testClass != null) {
 
@@ -134,7 +135,8 @@ private void replaceNode(ASTNode node, ASTNode replacementNode) {
           } else if (node.getLocationInParent().isChildListProperty()) {
             Method listMethod = node.getParent().getClass()
                     .getMethod(node.getLocationInParent().getId(), (Class<?>[]) null);
-            List list = (List) listMethod.invoke(node.getParent(), (Object[]) null);
+            @SuppressWarnings("unchecked")
+            List<ASTNode> list = (List<ASTNode>) listMethod.invoke(node.getParent(), (Object[]) null);
             list.set(list.indexOf(node), replacementNode);
           }
         } catch (InvocationTargetException e) {