#145 Update to Checkstyle 8.19

Author: Calixte

net.sf.eclipsecs.checkstyle/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry exported="true" kind="lib" path="checkstyle-8.18-all.jar" sourcepath="checkstyle-checkstyle-8.18.zip"/>
+	<classpathentry exported="true" kind="lib" path="checkstyle-8.19-all.jar" sourcepath="checkstyle-checkstyle-8.19.zip"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8">
 		<attributes>
 			<attribute name="maven.pomderived" value="true"/>

net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF

@@ -46,5 +46,5 @@ Export-Package: .,
  com.puppycrawl.tools.checkstyle.utils,
  org.apache.commons.beanutils;version="8.18.0"
 Bundle-ClassPath: .,
- checkstyle-8.18-all.jar
+ checkstyle-8.19-all.jar
 Automatic-Module-Name: net.sf.eclipsecs.checkstyle

net.sf.eclipsecs.checkstyle/build.properties

@@ -1,6 +1,6 @@
 bin.includes = META-INF/,\
                .,\
                license/,\
-               checkstyle-8.18-all.jar
+               checkstyle-8.19-all.jar
 jars.compile.order = .
 source.. = metadata/

net.sf.eclipsecs.checkstyle/checkstyle-8.18-all.jar

@@ -96,11 +96,13 @@
             <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationLocationCheck" />
             <description>%AnnotationLocation.desc</description>
             <property-metadata name="tokens" datatype="MultiCheck"
-                default-value="CLASS_DEF,INTERFACE_DEF,ENUM_DEF,METHOD_DEF,CTOR_DEF,VARIABLE_DEF">
+                default-value="CLASS_DEF,INTERFACE_DEF,PACKAGE_DEF,ENUM_CONSTANT_DEF,ENUM_DEF,METHOD_DEF,CTOR_DEF,VARIABLE_DEF">
                 <description>%AnnotationLocation.tokens</description>
                 <enumeration>
                     <property-value-option value="CLASS_DEF" />
                     <property-value-option value="INTERFACE_DEF" />
+                    <property-value-option value="PACKAGE_DEF" />
+                    <property-value-option value="ENUM_CONSTANT_DEF" />
                     <property-value-option value="ENUM_DEF" />
                     <property-value-option value="METHOD_DEF" />
                     <property-value-option value="CTOR_DEF" />

net.sf.eclipsecs.checkstyle/checkstyle-8.19-all.jar

@@ -9,8 +9,8 @@ Checker.localeLanguage = locale language for messages
 Checker.charset        = name of the file charset (Note: eclipse-cs plugin sets this property to the projects default charset)
 Checker.fileExtensions = file extensions that are accepted (comma separated)
 Checker.haltOnException = Controls whether exceptions should halt execution or not.
+Checker.tabWidth       = number of expanded spaces for a tab character ('\t'); used in messages and Checks that print violations on files with tabs
 
 TreeWalker.name           = TreeWalker
 TreeWalker.desc           = FileSetCheck TreeWalker checks individual Java source files and defines properties that are applicable to checking such files.
-TreeWalker.tabWidth       = number of expanded spaces for a tab character ('\t'); used in messages and Checks that require a tab width, such as LineLength
 TreeWalker.fileExtensions = file type extension to identify java files. Setting this property is typically only required if your java source code is preprocessed before compilation and the original files do not have the extension .java

net.sf.eclipsecs.checkstyle/checkstyle-checkstyle-8.18.zip renamed to net.sf.eclipsecs.checkstyle/checkstyle-checkstyle-8.19.zip

@@ -29,15 +29,15 @@
             <property-metadata name="haltOnException" datatype="Boolean" default-value="true">
                 <description>%Checker.haltOnException</description>
             </property-metadata>
+            <property-metadata name="tabWidth" datatype="Integer" default-value="8">
+                <description>%Checker.tabWidth</description>
+            </property-metadata>
         </rule-metadata>
 
         <rule-metadata name="%TreeWalker.name" internal-name="TreeWalker" parent="Checker"
             singleton="true">
             <alternative-name internal-name="com.puppycrawl.tools.checkstyle.TreeWalker"/>
             <description>%TreeWalker.desc</description>
-            <property-metadata name="tabWidth" datatype="Integer" default-value="8">
-                <description>%TreeWalker.tabWidth</description>
-            </property-metadata>
             <property-metadata name="fileExtensions" datatype="String" default-value="java">
                 <description>%TreeWalker.fileExtensions</description>
             </property-metadata>

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/annotation/checkstyle-metadata.xml

@@ -115,7 +115,7 @@ public final class ConfigurationReader {
     map.put(DTD_PUBLIC_CS_ID_1_1, DTD_CONFIGURATION_NAME_1_1);
     map.put(DTD_PUBLIC_CS_ID_1_2, DTD_CONFIGURATION_NAME_1_2);
     map.put(DTD_PUBLIC_CS_ID_1_3, DTD_CONFIGURATION_NAME_1_3);
-    
+
     PUBLIC2INTERNAL_DTD_MAP = map;
   }
 
@@ -172,7 +172,7 @@ public static AdditionalConfigData getAdditionalConfigData(InputSource in)
     for (final Module module : modules) {
 
       if ((module.getMetaData() != null)
-              && module.getMetaData().getInternalName().equals(XMLTags.TREEWALKER_MODULE)) {
+              && module.getMetaData().getInternalName().equals(XMLTags.CHECKER_MODULE)) {
 
         final ConfigProperty prop = module.getProperty("tabWidth"); //$NON-NLS-1$