Skip to content

Commit 580835b

Browse files
BananeweizenCalixte
authored andcommitted
Infra: Use Maven wrapper
The Maven wrapper allows running Maven without it being installed, and to specify the version being used. That way all developers and CI systems can use the same version easily. Travis supports mvnw: https://docs.travis-ci.com/user/languages/java/#maven-dependency-management As a developer, use "./mvnw goals" instead of "mvn goals" in the future, please.
1 parent 4d8d229 commit 580835b

File tree

11 files changed

+559
-32
lines changed

11 files changed

+559
-32
lines changed

.github/workflows/maven.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
java-version: 11
2929

3030
- name: Build with Maven
31-
run: mvn --errors --no-transfer-progress install
31+
run: ./mvnw --errors --no-transfer-progress install
3232

3333
- name: Difference Check
3434
run: ./.ci/validation.sh git-diff

.mvn/wrapper/maven-wrapper.jar

61.1 KB
Binary file not shown.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.1/apache-maven-3.9.1-bin.zip
18+
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ jobs:
3030
- jdk: openjdk11
3131
env:
3232
- DESC="install (openjdk11)"
33-
- CMD="mvn --errors --no-transfer-progress install"
33+
- CMD="./mvnw --errors --no-transfer-progress install"
3434

3535
# JDK 17 (most recent Java LTS version)
3636
- jdk: openjdk17
3737
env:
3838
- DESC="install (openjdk17)"
39-
- CMD="mvn --errors --no-transfer-progress install"
39+
- CMD="./mvnw --errors --no-transfer-progress install"
4040

4141
script:
4242
- ./.ci/travis.sh init-m2-repo

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
[![][travis img]][travis]
22

33
# eclipse-cs
4-
The Eclipse Checkstyle plug-in integrates the Checkstyle Java code auditor into the Eclipse IDE.
5-
The plug-in provides real-time feedback to the user about violations of rules that
6-
check for coding style and possible error prone code constructs.
4+
The Eclipse Checkstyle plug-in integrates the Checkstyle Java code auditor into the Eclipse IDE.
5+
The plug-in provides real-time feedback to the user about violations of rules that
6+
check for coding style and possible error prone code constructs.
77

88
[Checkstyle](https://github.com/checkstyle/checkstyle) is an Open Source development tool to help you ensure that your Java code adheres to a set of coding standards. Checkstyle does this by inspecting your Java source code and pointing out items that deviate from a defined set of coding rules.
99

@@ -23,17 +23,17 @@ If you need to install an older version:
2323
- You should now see the available versions of the Checkstyle plugin from which you can select and install.
2424

2525
### What does it do?
26-
With the Checkstyle Eclipse Plugin your code is constantly inspected for coding standard deviations. Within the Eclipse workbench you are immediately notified of problems via the Eclipse Problems View and source code annotations similar to compiler errors or warnings.
26+
With the Checkstyle Eclipse Plugin your code is constantly inspected for coding standard deviations. Within the Eclipse workbench you are immediately notified of problems via the Eclipse Problems View and source code annotations similar to compiler errors or warnings.
2727
This ensures an extremely short feedback loop right at the developers fingertips.
2828

2929
### Why would I use it?
30-
If your development team consists of more than one person, then obviously a common ground for coding standards (formatting rules, line lengths etc.) must be agreed upon - even if it is just for practical reasons to avoid superficial, format related merge conflicts.
30+
If your development team consists of more than one person, then obviously a common ground for coding standards (formatting rules, line lengths etc.) must be agreed upon - even if it is just for practical reasons to avoid superficial, format related merge conflicts.
3131
Checkstyle (and the Eclipse Checkstyle Plugin for that matter) helps you define and easily apply those common rules.
3232

3333
### Build it yourself
3434
Clone the git repository (or create a fork) and import all projects into your Eclipse workspace.
3535

36-
Open a command line in project root directory and run `mvn clean package`.
36+
Open a command line in project root directory and run `./mvnw clean package`.
3737

3838
Find the installable bundle update site archive `net.sf.eclipsecs-updatesite/target/net.sf.eclipsecs-updatesite_X.X.X.YYYYmmDDHHMM.zip`.
3939

docs/partials/index.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,8 @@ <h2>Build it yourself</h2>
213213
workspace.
214214
</p>
215215
<p>
216-
To build an update site bundle package you will require Apache Maven (3.2.x should do fine).
217-
<br />
218216
Open a command line in project root directory and run
219-
<code>mvn clean package</code>
217+
<code>./mvnw clean package</code>
220218
.
221219
<br />
222220
<br />

docs/sitemap.xml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,77 +15,77 @@
1515
-->
1616
<url>
1717
<loc>https://checkstyle.org/eclipse-cs/</loc>
18-
<lastmod>2023-04-15</lastmod>
18+
<lastmod>2023-04-16</lastmod>
1919
<changefreq>weekly</changefreq>
2020
</url>
2121
<url>
2222
<loc>https://checkstyle.org/eclipse-cs/#!/releasenotes</loc>
23-
<lastmod>2023-04-15</lastmod>
23+
<lastmod>2023-04-16</lastmod>
2424
<changefreq>weekly</changefreq>
2525
</url>
2626
<url>
2727
<loc>https://checkstyle.org/eclipse-cs/#!/install</loc>
28-
<lastmod>2023-04-15</lastmod>
28+
<lastmod>2023-04-16</lastmod>
2929
<changefreq>weekly</changefreq>
3030
</url>
3131
<url>
3232
<loc>https://checkstyle.org/eclipse-cs/#!/project-setup</loc>
33-
<lastmod>2023-04-15</lastmod>
33+
<lastmod>2023-04-16</lastmod>
3434
<changefreq>weekly</changefreq>
3535
</url>
3636
<url>
3737
<loc>https://checkstyle.org/eclipse-cs/#!/custom-config</loc>
38-
<lastmod>2023-04-15</lastmod>
38+
<lastmod>2023-04-16</lastmod>
3939
<changefreq>weekly</changefreq>
4040
</url>
4141
<url>
4242
<loc>https://checkstyle.org/eclipse-cs/#!/filters</loc>
43-
<lastmod>2023-04-15</lastmod>
43+
<lastmod>2023-04-16</lastmod>
4444
<changefreq>weekly</changefreq>
4545
</url>
4646
<url>
4747
<loc>https://checkstyle.org/eclipse-cs/#!/configtypes</loc>
48-
<lastmod>2023-04-15</lastmod>
48+
<lastmod>2023-04-16</lastmod>
4949
<changefreq>weekly</changefreq>
5050
</url>
5151
<url>
5252
<loc>https://checkstyle.org/eclipse-cs/#!/properties</loc>
53-
<lastmod>2023-04-15</lastmod>
53+
<lastmod>2023-04-16</lastmod>
5454
<changefreq>weekly</changefreq>
5555
</url>
5656
<url>
5757
<loc>https://checkstyle.org/eclipse-cs/#!/filesets</loc>
58-
<lastmod>2023-04-15</lastmod>
58+
<lastmod>2023-04-16</lastmod>
5959
<changefreq>weekly</changefreq>
6060
</url>
6161
<url>
6262
<loc>https://checkstyle.org/eclipse-cs/#!/preferences</loc>
63-
<lastmod>2023-04-15</lastmod>
63+
<lastmod>2023-04-16</lastmod>
6464
<changefreq>weekly</changefreq>
6565
</url>
6666
<url>
6767
<loc>https://checkstyle.org/eclipse-cs/#!/extensions</loc>
68-
<lastmod>2023-04-15</lastmod>
68+
<lastmod>2023-04-16</lastmod>
6969
<changefreq>weekly</changefreq>
7070
</url>
7171
<url>
7272
<loc>https://checkstyle.org/eclipse-cs/#!/custom-checks</loc>
73-
<lastmod>2023-04-15</lastmod>
73+
<lastmod>2023-04-16</lastmod>
7474
<changefreq>weekly</changefreq>
7575
</url>
7676
<url>
7777
<loc>https://checkstyle.org/eclipse-cs/#!/builtin-config</loc>
78-
<lastmod>2023-04-15</lastmod>
78+
<lastmod>2023-04-16</lastmod>
7979
<changefreq>weekly</changefreq>
8080
</url>
8181
<url>
8282
<loc>https://checkstyle.org/eclipse-cs/#!/custom-filters</loc>
83-
<lastmod>2023-04-15</lastmod>
83+
<lastmod>2023-04-16</lastmod>
8484
<changefreq>weekly</changefreq>
8585
</url>
8686
<url>
8787
<loc>https://checkstyle.org/eclipse-cs/#!/faq</loc>
88-
<lastmod>2023-04-15</lastmod>
88+
<lastmod>2023-04-16</lastmod>
8989
<changefreq>weekly</changefreq>
9090
</url>
9191
</urlset>

0 commit comments

Comments
 (0)