Skip to content

Commit 7353913

Browse files
BananeweizenCalixte
authored andcommitted
infra: downgrade JUnit
Upgrading Maven Surefire to a recent version fails with exceptions in the process launching the test process. That's because we have 2 versions of JUnit: 5.10 from Maven and 5.7.1 from the Eclipse target platform. Surefire seems to be confused by that and tries to use the junit-platform-launcher 5.7 from the target platform to launch the 5.10 JUnit during the Maven run. To avoid this, downgrade the Maven JUnit version to the latest 5.7.x, such that both Maven and Eclipse use the same JUnit version. Also remove some superfluous configuration.
1 parent 1062c88 commit 7353913

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

pom.xml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222
<build-helper-maven-plugin-version>3.4.0</build-helper-maven-plugin-version>
2323
<download-maven-plugin-version>1.7.1</download-maven-plugin-version>
2424
<exec-maven-plugin-version>3.1.0</exec-maven-plugin-version>
25-
<junit-jupiter-version>5.10.0</junit-jupiter-version>
25+
26+
<!-- Maven JUnit version must fit the JUnit version used in the target platform, otherwise Surefire may produce exceptions -->
27+
<junit-jupiter-version>5.7.2</junit-jupiter-version>
2628
<maven-antrun-plugin-version>3.1.0</maven-antrun-plugin-version>
2729
<maven-checkstyle-plugin-version>3.3.0</maven-checkstyle-plugin-version>
2830
<maven-clean-plugin-version>3.3.1</maven-clean-plugin-version>
@@ -33,7 +35,7 @@
3335
<maven-install-plugin-version>3.1.1</maven-install-plugin-version>
3436
<maven-resources-plugin-version>3.3.1</maven-resources-plugin-version>
3537
<maven-site-plugin-version>3.12.1</maven-site-plugin-version>
36-
<maven-surefire-plugin-version>2.22.2</maven-surefire-plugin-version>
38+
<maven-surefire-plugin-version>3.1.2</maven-surefire-plugin-version>
3739
<maven-version>3.6.3</maven-version>
3840
<tycho-version>2.7.5</tycho-version>
3941
<versions-maven-plugin-version>2.16.1</versions-maven-plugin-version>
@@ -377,11 +379,6 @@
377379
<plugin>
378380
<artifactId>maven-surefire-plugin</artifactId>
379381
<version>${maven-surefire-plugin-version}</version>
380-
<configuration>
381-
<includes>
382-
<include>**/*Test.java</include>
383-
</includes>
384-
</configuration>
385382
</plugin>
386383
<plugin>
387384
<artifactId>maven-compiler-plugin</artifactId>

0 commit comments

Comments
 (0)