Issue #221: update to Checkstyle 8.31

Author: Calixte

net.sf.eclipsecs.checkstyle/.classpath

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
-	<classpathentry exported="true" kind="lib" path="checkstyle-8.30-all.jar" sourcepath="checkstyle-checkstyle-8.30.zip"/>
+	<classpathentry exported="true" kind="lib" path="checkstyle-8.31-all.jar" sourcepath="checkstyle-checkstyle-8.31.zip"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8">
 		<attributes>
 			<attribute name="maven.pomderived" value="true"/>

net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF

@@ -46,5 +46,5 @@ Export-Package: .,
  com.puppycrawl.tools.checkstyle.utils,
  org.apache.commons.beanutils;version="8.30.0"
 Bundle-ClassPath: .,
- checkstyle-8.30-all.jar
+ checkstyle-8.31-all.jar
 Automatic-Module-Name: net.sf.eclipsecs.checkstyle

net.sf.eclipsecs.checkstyle/build.properties

@@ -1,6 +1,6 @@
 bin.includes = META-INF/,\
                .,\
                license/,\
-               checkstyle-8.30-all.jar
+               checkstyle-8.31-all.jar
 jars.compile.order = .
 source.. = metadata/

net.sf.eclipsecs.checkstyle/checkstyle-8.30-all.jar renamed to net.sf.eclipsecs.checkstyle/checkstyle-8.31-all.jar

@@ -188,6 +188,10 @@ UnnecessaryParentheses.desc = Checks for the use of unnecessary parentheses.
 UnnecessaryParentheses.name = Unnecessary Parentheses
 UnnecessaryParentheses.tokens = tokens to check
 
+UnnecessarySemicolonAfterOuterTypeDeclaration.desc = Checks if unnecessary semicolon is used after type declaration.
+UnnecessarySemicolonAfterOuterTypeDeclaration.name = Unnecessary semicolon after outer type declaration
+UnnecessarySemicolonAfterOuterTypeDeclaration.tokens = tokens to check
+
 UnnecessarySemicolonAfterTypeMemberDeclaration.desc = Checks if unnecessary semicolon is used after type member declaration.
 UnnecessarySemicolonAfterTypeMemberDeclaration.name = Unnecessary semicolon after type member declaration
 UnnecessarySemicolonAfterTypeMemberDeclaration.tokens = tokens to check

net.sf.eclipsecs.checkstyle/checkstyle-checkstyle-8.30.zip renamed to net.sf.eclipsecs.checkstyle/checkstyle-checkstyle-8.31.zip

@@ -562,6 +562,21 @@
             <message-key key="unnecessary.paren.lambda" />
         </rule-metadata>
 
+        <rule-metadata name="%UnnecessarySemicolonAfterOuterTypeDeclaration.name" internal-name="UnnecessarySemicolonAfterOuterTypeDeclaration" parent="TreeWalker">
+            <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.coding.UnnecessarySemicolonAfterOuterTypeDeclarationCheck" />
+            <description>%UnnecessarySemicolonAfterOuterTypeDeclaration.desc</description> 
+            <property-metadata name="tokens" datatype="MultiCheck" default-value="CLASS_DEF,INTERFACE_DEF,ENUM_DEF,ANNOTATION_DEF">
+                <description>%UnnecessarySemicolonAfterOuterTypeDeclaration.tokens</description>
+                <enumeration>
+                    <property-value-option value="CLASS_DEF"/>
+                    <property-value-option value="INTERFACE_DEF"/>
+                    <property-value-option value="ENUM_DEF"/>
+                    <property-value-option value="ANNOTATION_DEF"/>
+                </enumeration>
+            </property-metadata>
+            <message-key key="unnecessary.semicolon" />
+        </rule-metadata>
+
         <rule-metadata name="%UnnecessarySemicolonAfterTypeMemberDeclaration.name" internal-name="UnnecessarySemicolonAfterTypeMemberDeclaration" parent="TreeWalker">
             <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.coding.UnnecessarySemicolonAfterTypeMemberDeclarationCheck" />
             <description>%UnnecessarySemicolonAfterTypeMemberDeclaration.desc</description> 

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/coding/checkstyle-metadata.properties

@@ -55,7 +55,6 @@
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.core.runtime.OperationCanceledException;
 import org.eclipse.core.runtime.Path;
-import org.eclipse.jdt.core.JavaCore;
 import org.eclipse.jface.text.BadLocationException;
 import org.eclipse.jface.text.IDocument;
 import org.eclipse.jface.text.IRegion;
@@ -143,12 +142,6 @@ public void runAudit(IProject project, IProgressMonitor monitor)
       listener = new CheckstyleAuditListener(project);
       checker.addListener(listener);
 
-      // reconfigure the shared classloader for the current
-      // project
-      if (project.hasNature(JavaCore.NATURE_ID)) {
-        CheckerFactory.getSharedClassLoader().intializeWithProject(project);
-      }
-
       // run the files through the checker
       checker.process(filesToAudit);
 
@@ -158,8 +151,6 @@ public void runAudit(IProject project, IProgressMonitor monitor)
       } else {
         handleCheckstyleFailure(project, e);
       }
-    } catch (CoreException e) {
-      CheckstylePluginException.rethrow(e);
     } catch (RuntimeException e) {
       if (listener != null) {
         listener.cleanup();

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/coding/checkstyle-metadata.xml

@@ -63,19 +63,14 @@ public final class CheckerFactory {
   /** Map containing the modification times of configs. */
   private static Map<String, Long> sModifiedMap;
 
-  /** the shared classloader for the checkers. */
-  private static ProjectClassLoader sSharedClassLoader;
-
-  /**
+  /*
    * Initialize the cache.
    */
   static {
 
     sCheckerMap = CacheBuilder.newBuilder().softValues().build();
 
     sModifiedMap = new ConcurrentHashMap<>();
-
-    sSharedClassLoader = new ProjectClassLoader();
   }
 
   /**
@@ -138,15 +133,6 @@ public static Checker createChecker(ICheckConfiguration config, IProject project
     return checker;
   }
 
-  /**
-   * Returns the shared classloader which is used by all checkers created by this factory.
-   *
-   * @return the shared classloader
-   */
-  public static ProjectClassLoader getSharedClassLoader() {
-    return sSharedClassLoader;
-  }
-
   /**
    * Cleans up the checker cache.
    */
@@ -250,7 +236,6 @@ private static Checker createCheckerInternal(InputSource input, PropertyResolver
     Locale platformLocale = CheckstylePlugin.getPlatformLocale();
     checker.setLocaleLanguage(platformLocale.getLanguage());
     checker.setLocaleCountry(platformLocale.getCountry());
-    checker.setClassLoader(sSharedClassLoader);
 
     checker.configure(configuration);