Skip to content

Commit 91125dd

Browse files
BananeweizenCalixte
authored andcommitted
Infra: re-enable tycho jgit timestamp provider
The Tycho JGit timestamp provider calculates the timestamp based on the last change of any file in the module. It's therefore okay to be different for different child modules, so it was wrong to disable it in the first place. The benefit of this timestamp provider is that it leads to the exact version number each time we re-build the same commit (since that commit defines the timestamp). Without this, rebuilding the same commit leads to the _current_ timestamp (build time) being used, leading to different file names for the same commit.
1 parent ecde1bf commit 91125dd

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pom.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,22 +211,21 @@
211211
<artifactId>tycho-packaging-plugin</artifactId>
212212
<version>${tycho-version}</version>
213213
<dependencies>
214+
<!-- generate timestamps from last git change of any file in this module -->
214215
<dependency>
215216
<groupId>org.eclipse.tycho.extras</groupId>
216217
<artifactId>tycho-buildtimestamp-jgit</artifactId>
217218
<version>${tycho-version}</version>
218219
</dependency>
220+
<!-- automatically add a source references header to the manifest -->
219221
<dependency>
220222
<groupId>org.eclipse.tycho.extras</groupId>
221223
<artifactId>tycho-sourceref-jgit</artifactId>
222224
<version>${tycho-version}</version>
223225
</dependency>
224226
</dependencies>
225227
<configuration>
226-
<!-- <timestampProvider>jgit</timestampProvider> -->
227-
<jgit.ignore>
228-
pom.xml
229-
</jgit.ignore>
228+
<timestampProvider>jgit</timestampProvider>
230229
<jgit.dirtyWorkingTree>ignore</jgit.dirtyWorkingTree>
231230
<sourceReferences>
232231
<generate>true</generate>

0 commit comments

Comments
 (0)