Upgrade dom4j dependency

Use the current release of the Java 8 version of the library. Therefore
some of the SuppressWarnings can be removed now.

Author: Bananeweizen

net.sf.eclipsecs.core/.classpath

@@ -3,6 +3,6 @@
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="src" path="src"/>
-	<classpathentry exported="true" kind="lib" path="lib/dom4j-1.6.1.jar"/>
+	<classpathentry exported="true" kind="lib" path="lib/dom4j-2.1.3.jar"/>
 	<classpathentry kind="output" path="target/classes"/>
 </classpath>

net.sf.eclipsecs.core/META-INF/MANIFEST.MF

@@ -5,7 +5,7 @@ Bundle-SymbolicName: net.sf.eclipsecs.core;singleton:=true
 Bundle-Version: 8.32.0.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-1.8
 Bundle-ClassPath: .,
- lib/dom4j-1.6.1.jar
+ lib/dom4j-2.1.3.jar
 Bundle-Activator: net.sf.eclipsecs.core.CheckstylePlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: Eclipse Checkstyle Project

net.sf.eclipsecs.core/build.properties

@@ -7,6 +7,6 @@ bin.includes = .,\
                plugin.xml,\
                schema/,\
                core.properties,\
-               lib/dom4j-1.6.1.jar
+               lib/dom4j-2.1.3.jar
 source.. = src/
 

net.sf.eclipsecs.core/lib/dom4j-1.6.1.jar

@@ -397,7 +397,6 @@ private static void loadBuiltinConfigurations() {
    *          the root element of the plugins central configuration file
    * @return the global check configurations configured therein
    */
-  @SuppressWarnings("unchecked")
   private static List<ICheckConfiguration> getGlobalCheckConfigurations(Element root) {
 
     List<ICheckConfiguration> configs = new ArrayList<>();

net.sf.eclipsecs.core/lib/dom4j-2.1.3.jar

@@ -191,7 +191,6 @@ public void visit(final Element node) {
 
   private static void addProperties(final Element moduleEl, final Module module) {
 
-    @SuppressWarnings("unchecked")
     final List<Element> propertyEls = moduleEl.elements(XMLTags.PROPERTY_TAG);
 
     for (final Element propertyEl : propertyEls) {
@@ -231,7 +230,6 @@ private static void addProperties(final Element moduleEl, final Module module) {
 
   private static void addMessages(final Element moduleEl, final Module module) {
 
-    @SuppressWarnings("unchecked")
     final List<Element> messageEls = moduleEl.elements(XMLTags.MESSAGE_TAG);
 
     for (final Element messageEl : messageEls) {
@@ -245,7 +243,6 @@ private static void addMessages(final Element moduleEl, final Module module) {
 
   private static void addMetadata(final Element moduleEl, final Module module) {
 
-    @SuppressWarnings("unchecked")
     final List<Element> metaEls = moduleEl.elements(XMLTags.METADATA_TAG);
 
     for (final Element metaEl : metaEls) {

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java

@@ -399,7 +399,6 @@ private static ResourceBundle getMetadataI18NBundle(String metadataFile,
     }
   }
 
-  @SuppressWarnings("unchecked")
   private static void parseMetadata(InputStream metadataStream, ResourceBundle metadataBundle)
           throws DocumentException, CheckstylePluginException {
 
@@ -441,7 +440,6 @@ private static void parseMetadata(InputStream metadataStream, ResourceBundle met
     }
   }
 
-  @SuppressWarnings("unchecked")
   private static void processModules(Element groupElement, RuleGroupMetadata groupMetadata,
           ResourceBundle metadataBundle) throws CheckstylePluginException {
 
@@ -484,7 +482,7 @@ private static void processModules(Element groupElement, RuleGroupMetadata group
       processProperties(moduleEl, module, metadataBundle);
 
       // process alternative names
-      for (Element altNameEl : (List<Element>) moduleEl.elements(XMLTags.ALTERNATIVE_NAME_TAG)) {
+      for (Element altNameEl : moduleEl.elements(XMLTags.ALTERNATIVE_NAME_TAG)) {
 
         String alternativeName = altNameEl.attributeValue(XMLTags.INTERNAL_NAME_TAG);
 
@@ -494,14 +492,14 @@ private static void processModules(Element groupElement, RuleGroupMetadata group
       }
 
       // process quickfixes
-      for (Element quickfixEl : (List<Element>) moduleEl.elements(XMLTags.QUCKFIX_TAG)) {
+      for (Element quickfixEl : moduleEl.elements(XMLTags.QUCKFIX_TAG)) {
 
         String quickfixClassName = quickfixEl.attributeValue(XMLTags.CLASSNAME_TAG);
         module.addQuickfix(quickfixClassName);
       }
 
       // process message keys
-      for (Element quickfixEl : (List<Element>) moduleEl.elements(XMLTags.MESSAGEKEY_TAG)) {
+      for (Element quickfixEl : moduleEl.elements(XMLTags.MESSAGEKEY_TAG)) {
 
         String messageKey = quickfixEl.attributeValue(XMLTags.KEY_TAG);
         module.addMessageKey(messageKey);
@@ -568,7 +566,7 @@ private static void processProperties(Element moduleElement, RuleMetadata module
         }
 
         // get explicit enumeration option values
-        for (Element optionEl : (List<Element>) enumEl
+        for (Element optionEl : enumEl
                 .elements(XMLTags.PROPERTY_VALUE_OPTIONS_TAG)) {
           property.getPropertyEnumeration().add(optionEl.attributeValue(XMLTags.VALUE_TAG));
         }

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java

@@ -202,7 +202,6 @@ private static IProjectConfiguration getProjectConfiguration(InputStream in, IPr
             syncFormatter);
   }
 
-  @SuppressWarnings("unchecked")
   private static List<ICheckConfiguration> getLocalCheckConfigs(Element root, IProject project) {
 
     List<ICheckConfiguration> configurations = new ArrayList<>();
@@ -255,7 +254,6 @@ private static List<ICheckConfiguration> getLocalCheckConfigs(Element root, IPro
     return configurations;
   }
 
-  @SuppressWarnings("unchecked")
   private static List<FileSet> getFileSets(Element root,
           List<ICheckConfiguration> localCheckConfigs) throws CheckstylePluginException {
 
@@ -305,7 +303,6 @@ private static List<FileSet> getFileSets(Element root,
     return fileSets;
   }
 
-  @SuppressWarnings("unchecked")
   private static List<IFilter> getFilters(Element root) {
 
     List<IFilter> filters = new ArrayList<>();