Fix new violations

These violations are shown with the most recent 10.14.1 by the eclipse
plugin itself, but are not part of the github verification due to an
older version being used there.

Author: Bananeweizen

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java

@@ -66,7 +66,7 @@ public static void writeNewConfiguration(OutputStream out, ICheckConfiguration c
 
     // write an empty list of modules
     // mandatory modules are added automatically
-    write(out, new ArrayList<Module>(), checkConfig);
+    write(out, new ArrayList<>(), checkConfig);
   }
 
   /**
@@ -141,8 +141,6 @@ public static void write(OutputStream out, List<Module> modules, ICheckConfigura
   private static void writeModule(Module module, Branch parent, Severity parentSeverity,
           List<Module> remainingModules) {
 
-    Severity severity = parentSeverity;
-
     // remove this module from the list of modules to write
     remainingModules.remove(module);
 
@@ -161,6 +159,7 @@ private static void writeModule(Module module, Branch parent, Severity parentSev
     }
 
     // Write severity only if it differs from the parents severity
+    Severity severity = parentSeverity;
     if (module.getSeverity() != null && !Severity.inherit.equals(module.getSeverity())) {
 
       Element propertyEl = moduleEl.addElement(XMLTags.PROPERTY_TAG);

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java

@@ -488,16 +488,18 @@ public void widgetDefaultSelected(SelectionEvent e) {
     protected Control createDialogArea(Composite parent) {
       Composite composite = (Composite) super.createDialogArea(parent);
       Label messageLabel = createMessageArea(composite);
-      CheckboxTreeViewer treeViewer = createTreeViewer(composite);
+      if (mIsEmpty) {
+        messageLabel.setEnabled(false);
+      }
 
+      CheckboxTreeViewer treeViewer = createTreeViewer(composite);
       GridData data = new GridData(GridData.FILL_BOTH);
       data.widthHint = convertWidthInCharsToPixels(mWidth);
       data.heightHint = convertHeightInCharsToPixels(mHeight);
       Tree treeWidget = treeViewer.getTree();
       treeWidget.setLayoutData(data);
       treeWidget.setFont(parent.getFont());
       if (mIsEmpty) {
-        messageLabel.setEnabled(false);
         treeWidget.setEnabled(false);
       }
       return composite;

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java

@@ -72,15 +72,14 @@ public boolean visit(InfixExpression node) {
             return true;
           }
 
-          Expression replacementNode = null;
-
           MethodInvocation equalsInvocation = node.getAST().newMethodInvocation();
           equalsInvocation.setName(node.getAST().newSimpleName("equals")); //$NON-NLS-1$
           equalsInvocation.setExpression((Expression) ASTNode.copySubtree(node.getAST(), literal));
           equalsInvocation.arguments().add(ASTNode.copySubtree(node.getAST(), otherOperand));
 
           // if the string was compared with != create a not
           // expression
+          final Expression replacementNode;
           if (node.getOperator().equals(InfixExpression.Operator.NOT_EQUALS)) {
             PrefixExpression prefixExpression = node.getAST().newPrefixExpression();
             prefixExpression.setOperator(PrefixExpression.Operator.NOT);