Skip to content

Commit a7e9f47

Browse files
BananeweizenBananeweizen
committed
supplemental: fix all Eclipse IDE warnings
* Have all available preferences in jdt.core.prefs and pde.prefs to ensure JDT and PDE compiler settings are version controlled * set most compiler warnings to error to avoid re-introducing any of them * ignore all deprecation warnings, they are not fixable when we want to remain compatible with old Eclipse versions * fix all remaining warnings * add lifecycle mapping for Eclipse m2e to avoid Maven lifecycle mapping warnings
1 parent 3a75379 commit a7e9f47

File tree

24 files changed

+878
-126
lines changed

24 files changed

+878
-126
lines changed

‎.gitignore‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
bin/
22
target/
3-
metadata-gen/
4-
net.sf.eclipsecs.core/lib/metadata-gen-1.0-SNAPSHOT.jar
53
.idea/
64
*.iml
7-
*.prefs
85
show.patch
96
*.DS_Store
107
net.sf.eclipsecs-updatesite/workspace

‎net.sf.eclipsecs.branding/.project‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
</arguments>
2222
</buildCommand>
2323
<buildCommand>
24-
<name>org.eclipse.m2e.core.maven2Builder</name>
24+
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
2525
<arguments>
2626
</arguments>
2727
</buildCommand>
2828
<buildCommand>
29-
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
29+
<name>org.eclipse.m2e.core.maven2Builder</name>
3030
<arguments>
3131
</arguments>
3232
</buildCommand>

‎net.sf.eclipsecs.branding/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 412 additions & 0 deletions
Large diffs are not rendered by default.

‎net.sf.eclipsecs.branding/.settings/org.eclipse.pde.prefs‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
compilers.f.unresolved-features=1
2+
compilers.f.unresolved-plugins=1
3+
compilers.incompatible-environment=0
4+
compilers.p.build=0
5+
compilers.p.build.bin.includes=0
6+
compilers.p.build.encodings=0
7+
compilers.p.build.java.compiler=2
8+
compilers.p.build.java.compliance=0
9+
compilers.p.build.missing.output=2
10+
compilers.p.build.output.library=0
11+
compilers.p.build.source.library=0
12+
compilers.p.build.src.includes=0
13+
compilers.p.deprecated=2
14+
compilers.p.discouraged-class=0
15+
compilers.p.exec-env-too-low=1
16+
compilers.p.internal=0
17+
compilers.p.missing-packages=2
18+
compilers.p.missing-version-export-package=2
19+
compilers.p.missing-version-import-package=2
20+
compilers.p.missing-version-require-bundle=2
21+
compilers.p.no-required-att=0
22+
compilers.p.no.automatic.module=0
23+
compilers.p.not-externalized-att=2
24+
compilers.p.service.component.without.lazyactivation=0
25+
compilers.p.unknown-attribute=0
26+
compilers.p.unknown-class=0
27+
compilers.p.unknown-element=0
28+
compilers.p.unknown-identifier=0
29+
compilers.p.unknown-resource=0
30+
compilers.p.unresolved-ex-points=0
31+
compilers.p.unresolved-import=0
32+
compilers.s.create-docs=false
33+
compilers.s.doc-folder=doc
34+
compilers.s.open-tags=1
35+
eclipse.preferences.version=1

‎net.sf.eclipsecs.checkstyle/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 103 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,116 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
3+
org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled
4+
org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
5+
org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull
6+
org.eclipse.jdt.core.compiler.annotation.nonnull.secondary=
7+
org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault
8+
org.eclipse.jdt.core.compiler.annotation.nonnullbydefault.secondary=
9+
org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable
10+
org.eclipse.jdt.core.compiler.annotation.nullable.secondary=
11+
org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
212
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
313
org.eclipse.jdt.core.compiler.codegen.targetPlatform=11
414
org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
515
org.eclipse.jdt.core.compiler.compliance=11
616
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
717
org.eclipse.jdt.core.compiler.debug.localVariable=generate
818
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
19+
org.eclipse.jdt.core.compiler.problem.APILeak=error
20+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
21+
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=error
922
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
23+
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
24+
org.eclipse.jdt.core.compiler.problem.comparingIdentical=error
25+
org.eclipse.jdt.core.compiler.problem.deadCode=error
26+
org.eclipse.jdt.core.compiler.problem.deprecation=ignore
27+
org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
28+
org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
29+
org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
30+
org.eclipse.jdt.core.compiler.problem.emptyStatement=error
1031
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
11-
org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning
12-
org.eclipse.jdt.core.compiler.release=disabled
32+
org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore
33+
org.eclipse.jdt.core.compiler.problem.fallthroughCase=error
34+
org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
35+
org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore
36+
org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
37+
org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=error
38+
org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
39+
org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=error
40+
org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
41+
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=error
42+
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=error
43+
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
44+
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
45+
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
46+
org.eclipse.jdt.core.compiler.problem.missingDefaultCase=error
47+
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=error
48+
org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
49+
org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
50+
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
51+
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
52+
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=error
53+
org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
54+
org.eclipse.jdt.core.compiler.problem.noEffectAssignment=error
55+
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=error
56+
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
57+
org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning
58+
org.eclipse.jdt.core.compiler.problem.nonnullTypeVariableFromLegacyInvocation=warning
59+
org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
60+
org.eclipse.jdt.core.compiler.problem.nullReference=error
61+
org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
62+
org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
63+
org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=error
64+
org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
65+
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
66+
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=error
67+
org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
68+
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
69+
org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
70+
org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
71+
org.eclipse.jdt.core.compiler.problem.redundantNullCheck=error
72+
org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore
73+
org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=error
74+
org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
75+
org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore
76+
org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
77+
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
78+
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
79+
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
80+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=info
81+
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
82+
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
83+
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=error
84+
org.eclipse.jdt.core.compiler.problem.typeParameterHiding=error
85+
org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
86+
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
87+
org.eclipse.jdt.core.compiler.problem.unclosedCloseable=error
88+
org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
89+
org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=error
90+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentType=error
91+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentTypeStrict=disabled
92+
org.eclipse.jdt.core.compiler.problem.unlikelyEqualsArgumentType=error
93+
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
94+
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
95+
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
96+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=error
97+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
98+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
99+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=disabled
100+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
101+
org.eclipse.jdt.core.compiler.problem.unusedExceptionParameter=ignore
102+
org.eclipse.jdt.core.compiler.problem.unusedImport=error
103+
org.eclipse.jdt.core.compiler.problem.unusedLabel=error
104+
org.eclipse.jdt.core.compiler.problem.unusedLocal=error
105+
org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=warning
106+
org.eclipse.jdt.core.compiler.problem.unusedParameter=error
107+
org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
108+
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
109+
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
110+
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=error
111+
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
112+
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=error
113+
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=error
13114
org.eclipse.jdt.core.compiler.source=11
14115
org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines=2147483647
15116
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

‎net.sf.eclipsecs.checkstyle/.settings/org.eclipse.pde.prefs‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
compilers.f.unresolved-features=1
2+
compilers.f.unresolved-plugins=1
3+
compilers.incompatible-environment=0
4+
compilers.p.build=0
5+
compilers.p.build.bin.includes=0
6+
compilers.p.build.encodings=0
7+
compilers.p.build.java.compiler=2
8+
compilers.p.build.java.compliance=0
9+
compilers.p.build.missing.output=2
10+
compilers.p.build.output.library=0
11+
compilers.p.build.source.library=0
12+
compilers.p.build.src.includes=0
13+
compilers.p.deprecated=2
14+
compilers.p.discouraged-class=0
15+
compilers.p.exec-env-too-low=1
16+
compilers.p.internal=0
17+
compilers.p.missing-packages=2
18+
compilers.p.missing-version-export-package=2
19+
compilers.p.missing-version-import-package=2
20+
compilers.p.missing-version-require-bundle=2
21+
compilers.p.no-required-att=0
22+
compilers.p.no.automatic.module=0
23+
compilers.p.not-externalized-att=2
24+
compilers.p.service.component.without.lazyactivation=0
25+
compilers.p.unknown-attribute=0
26+
compilers.p.unknown-class=0
27+
compilers.p.unknown-element=0
28+
compilers.p.unknown-identifier=0
29+
compilers.p.unknown-resource=0
30+
compilers.p.unresolved-ex-points=0
31+
compilers.p.unresolved-import=0
32+
compilers.s.create-docs=false
33+
compilers.s.doc-folder=doc
34+
compilers.s.open-tags=1
35+
eclipse.preferences.version=1

‎net.sf.eclipsecs.checkstyle/build.properties‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ bin.includes = META-INF/,\
44
checkstyle-10.3.3-all.jar
55
jars.compile.order = .
66
source.. = metadata/
7+
javacDefaultEncoding.. = UTF-8

‎net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,17 @@ public void testMetadataFiles() throws Exception {
4242
assertTrue(new File(getEclipseCsPath(p, "")).exists(), "folder " + p + " must exist in eclipsecs");
4343

4444
final Set<Class<?>> packgeModules = CheckUtil.getModulesInPackage(modules, p);
45+
assertTrue(packgeModules.size() > 0, "package must have modules");
4546

46-
validateEclipseCsMetaXmlFile(new File(getEclipseCsPath(p, "/checkstyle-metadata.xml")), p,
47-
new HashSet<>(packgeModules));
47+
validateEclipseCsMetaXmlFile(new File(getEclipseCsPath(p, "/checkstyle-metadata.xml")), p);
4848

4949
validateEclipseCsMetaPropFile(
50-
new File(getEclipseCsPath(p, "/checkstyle-metadata.properties")), p,
51-
new HashSet<>(packgeModules));
50+
new File(getEclipseCsPath(p, "/checkstyle-metadata.properties")), p);
5251
}
5352
}
5453

55-
private static void validateEclipseCsMetaXmlFile(File file, String packge,
56-
Set<Class<?>> packgeModules) throws Exception {
57-
assertTrue(file.exists(), "'checkstyle-metadata.xml' must exist in eclipsecs in inside " + packge);
54+
private static void validateEclipseCsMetaXmlFile(File file, String packge) throws Exception {
55+
assertTrue(file.exists(), "'checkstyle-metadata.xml' must exist in eclipsecs inside " + packge);
5856

5957
final String input = new String(Files.readAllBytes(file.toPath()), UTF_8);
6058
final Document document = XmlUtil.getRawXml(file.getAbsolutePath(), input, input);
@@ -71,9 +69,8 @@ private static void validateEclipseCsMetaXmlFile(File file, String packge,
7169
}
7270
}
7371

74-
private static void validateEclipseCsMetaPropFile(File file, String packge,
75-
Set<Class<?>> packgeModules) throws Exception {
76-
assertTrue(file.exists(), "'checkstyle-metadata.properties' must exist in eclipsecs in inside " + packge);
72+
private static void validateEclipseCsMetaPropFile(File file, String packge) throws Exception {
73+
assertTrue(file.exists(), "'checkstyle-metadata.properties' must exist in eclipsecs inside " + packge);
7774

7875
final Properties prop = new Properties();
7976
prop.load(new FileInputStream(file));

0 commit comments

Comments
 (0)