Fix #84: upgrade to checkstyle 8.11

Author: valfirst

net.sf.eclipsecs.checkstyle/.classpath

@@ -8,7 +8,7 @@
 	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="src" path="metadata/"/>
     <classpathentry kind="src" path="test"/>
-	<classpathentry exported="true" kind="lib" path="checkstyle-8.10.1-all.jar" sourcepath="checkstyle-checkstyle-8.10.1.zip"/>
+	<classpathentry exported="true" kind="lib" path="checkstyle-8.11-all.jar" sourcepath="checkstyle-checkstyle-8.11.zip"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/4"/>
 	<classpathentry kind="output" path="target/classes"/>
 </classpath>

net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF

@@ -46,5 +46,5 @@ Export-Package: .,
  com.puppycrawl.tools.checkstyle.utils,
  org.apache.commons.beanutils;version="8.10.1"
 Bundle-ClassPath: .,
- checkstyle-8.10.1-all.jar
+ checkstyle-8.11-all.jar
 Automatic-Module-Name: net.sf.eclipsecs.checkstyle

net.sf.eclipsecs.checkstyle/build.properties

@@ -1,6 +1,6 @@
 bin.includes = META-INF/,\
                .,\
                license/,\
-               checkstyle-8.10.1-all.jar
+               checkstyle-8.11-all.jar
 jars.compile.order = .
 source.. = metadata/

net.sf.eclipsecs.checkstyle/checkstyle-8.11-all.jar

@@ -91,4 +91,8 @@ AbbreviationAsWordInName.tokens = Tokens to check.
 
 CatchParameterName.name = Catch Parameter Name
 CatchParameterName.desc =  Checks that catch parameter names conform to a format specified by the format property. Default pattern has the following characteristic:<ul><li>allows names beginning with two lowercase letters followed by at least one uppercase or lowercase letter</li><li>allows e abbreviation (suitable for exceptions end errors)</li><li>allows ex abbreviation (suitable for exceptions)</li><li>allows t abbreviation (suitable for throwables)</li><li>prohibits numbered abbreviations like e1 or t2</li><li>prohibits one letter prefixes like pException</li><li>prohibits two letter abbreviations like ie or ee</li><li>prohibits any other characters than letters</li></ul>
-CatchParameterName.format = Specifies valid identifiers.
+CatchParameterName.format = Specifies valid identifiers.
+
+LambdaParameterName.name = Lambda parameter names
+LambdaParameterName.desc = Checks that lambda parameter names follow naming convention.
+LambdaParameterName.format = Regular expression defining required naming pattern.

net.sf.eclipsecs.checkstyle/checkstyle-checkstyle-8.11.zip

@@ -269,6 +269,15 @@
             </property-metadata>
             <message-key key="name.invalidPattern"/>
         </rule-metadata>
+
+        <rule-metadata name="%LambdaParameterName.name" internal-name="LambdaParameterName" parent="TreeWalker">
+            <alternative-name internal-name="com.puppycrawl.tools.checkstyle.checks.naming.LambdaParameterNameCheck"/>
+            <description>%LambdaParameterName.desc</description>
+            <property-metadata name="format" datatype="Regex" default-value="^[a-z][a-zA-Z0-9]*$">
+                <description>%LambdaParameterName.format</description>
+            </property-metadata>
+            <message-key key="name.invalidPattern"/>
+        </rule-metadata>
     </rule-group-metadata>
 
 </checkstyle-metadata>

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/naming/checkstyle-metadata.properties

@@ -3,7 +3,7 @@
 import static java.nio.charset.StandardCharsets.UTF_8;
 
 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
-import com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtils;
+import com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -105,10 +105,10 @@ private static void validateEclipseCsMetaXmlFileRules(String packge, Set<Class<?
       final Node parentAttribute = attributes.getNamedItem("parent");
       final String parentValue;
 
-      if (ModuleReflectionUtils.isCheckstyleTreeWalkerCheck(module)
-              || ModuleReflectionUtils.isTreeWalkerFilterModule(module)) {
+      if (ModuleReflectionUtil.isCheckstyleTreeWalkerCheck(module)
+              || ModuleReflectionUtil.isTreeWalkerFilterModule(module)) {
         parentValue = "TreeWalker";
-      } else if (ModuleReflectionUtils.isRootModule(module)) {
+      } else if (ModuleReflectionUtil.isRootModule(module)) {
         parentValue = "Root";
       } else {
         parentValue = "Checker";

net.sf.eclipsecs.checkstyle/metadata/com/puppycrawl/tools/checkstyle/checks/naming/checkstyle-metadata.xml

@@ -8,9 +8,9 @@
 import com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck;
 import com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck;
 import com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck;
-import com.puppycrawl.tools.checkstyle.utils.JavadocUtils;
-import com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtils;
-import com.puppycrawl.tools.checkstyle.utils.TokenUtils;
+import com.puppycrawl.tools.checkstyle.utils.JavadocUtil;
+import com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil;
+import com.puppycrawl.tools.checkstyle.utils.TokenUtil;
 
 import java.beans.PropertyDescriptor;
 import java.lang.reflect.Field;
@@ -44,7 +44,7 @@ public static String getSimpleCheckstyleModuleName(Class<?> module) {
 
   public static Set<Class<?>> getCheckstyleModules() throws Exception {
     final ClassLoader loader = Thread.currentThread().getContextClassLoader();
-    return ModuleReflectionUtils.getCheckstyleModules(PackageNamesLoader.getPackageNames(loader),
+    return ModuleReflectionUtil.getCheckstyleModules(PackageNamesLoader.getPackageNames(loader),
             loader);
   }
 
@@ -188,15 +188,15 @@ public static Set<Field> getCheckMessages(Class<?> module) throws ClassNotFoundE
 
   public static String getTokenText(int[] tokens, int... subtractions) {
     String tokenText = null;
-    if (subtractions.length == 0 && Arrays.equals(tokens, TokenUtils.getAllTokenIds())) {
+    if (subtractions.length == 0 && Arrays.equals(tokens, TokenUtil.getAllTokenIds())) {
       tokenText = "TokenTypes";
     } else {
 
       Arrays.sort(subtractions);
 
       tokenText = Arrays.stream(tokens)
               .filter(token -> Arrays.binarySearch(subtractions, token) < 0)
-              .mapToObj(TokenUtils::getTokenName).collect(Collectors.joining(","));
+              .mapToObj(TokenUtil::getTokenName).collect(Collectors.joining(","));
     }
     return tokenText.length() == 0 ? null : tokenText;
   }
@@ -207,7 +207,7 @@ public static String getJavadocTokenText(int[] tokens, int... subtractions) {
 
     String tokenText = Arrays.stream(tokens)
             .filter(token -> Arrays.binarySearch(subtractions, token) < 0)
-            .mapToObj(JavadocUtils::getTokenName).collect(Collectors.joining(","));
+            .mapToObj(JavadocUtil::getTokenName).collect(Collectors.joining(","));
 
     if (tokenText.length() == 0) {
       tokenText = "empty";