enable automatic save actions in Eclipse

This change enables automatic save actions on eclipse-cs core and ui. I
noticed that some recent changes had introduced unused imports and was
surprised to discover they are not automatically removed in eclipse-cs.

Both the core and ui project now have the same automated cleanup on
save. It has been applied to the complete sources already, so later
commits will not have unwanted cleanups mixed their functional change.
There are no functional changes in this commit.

The configuration for the cleanup is rather conservative. E.g. it
disables
* organize imports (since the import order seems not to be the default
import order in many files)
* remove trailing whitespace (many of the Javadocs contain trailing
whitespace)
* remove unnecessary casts (this one is especially important because our
compilation target platform is different than our development target
platform)

Author: Bananeweizen

net.sf.eclipsecs.core/.settings/org.eclipse.jdt.ui.prefs

@@ -21,21 +21,23 @@ cleanup.make_local_variable_final=true
 cleanup.make_parameters_final=true
 cleanup.make_private_fields_final=true
 cleanup.make_type_abstract_if_missing_method=false
-cleanup.make_variable_declarations_final=true
+cleanup.make_variable_declarations_final=false
 cleanup.never_use_blocks=false
 cleanup.never_use_parentheses_in_expressions=true
-cleanup.organize_imports=true
+cleanup.organize_imports=false
 cleanup.qualify_static_field_accesses_with_declaring_class=false
 cleanup.qualify_static_member_accesses_through_instances_with_declaring_class=true
 cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=true
 cleanup.qualify_static_member_accesses_with_declaring_class=true
 cleanup.qualify_static_method_accesses_with_declaring_class=false
 cleanup.remove_private_constructors=true
+cleanup.remove_redundant_modifiers=false
+cleanup.remove_redundant_semicolons=true
 cleanup.remove_redundant_type_arguments=true
 cleanup.remove_trailing_whitespaces=false
 cleanup.remove_trailing_whitespaces_all=true
 cleanup.remove_trailing_whitespaces_ignore_empty=false
-cleanup.remove_unnecessary_casts=true
+cleanup.remove_unnecessary_casts=false
 cleanup.remove_unnecessary_nls_tags=true
 cleanup.remove_unused_imports=true
 cleanup.remove_unused_local_variables=false
@@ -54,9 +56,68 @@ cleanup.use_this_for_non_static_field_access=false
 cleanup.use_this_for_non_static_field_access_only_if_necessary=true
 cleanup.use_this_for_non_static_method_access=false
 cleanup.use_this_for_non_static_method_access_only_if_necessary=true
-cleanup.use_type_arguments=false
-cleanup_profile=_eclipse-cs net.sf.eclipsecs.core
+cleanup_profile=_eclipse-cs
 cleanup_settings_version=2
 eclipse.preferences.version=1
+editor_save_participant_org.eclipse.jdt.ui.postsavelistener.cleanup=true
 formatter_profile=_Checkstyle
 formatter_settings_version=13
+sp_cleanup.add_default_serial_version_id=true
+sp_cleanup.add_generated_serial_version_id=false
+sp_cleanup.add_missing_annotations=true
+sp_cleanup.add_missing_deprecated_annotations=true
+sp_cleanup.add_missing_methods=false
+sp_cleanup.add_missing_nls_tags=false
+sp_cleanup.add_missing_override_annotations=true
+sp_cleanup.add_missing_override_annotations_interface_methods=true
+sp_cleanup.add_serial_version_id=false
+sp_cleanup.always_use_blocks=true
+sp_cleanup.always_use_parentheses_in_expressions=false
+sp_cleanup.always_use_this_for_non_static_field_access=false
+sp_cleanup.always_use_this_for_non_static_method_access=false
+sp_cleanup.convert_functional_interfaces=false
+sp_cleanup.convert_to_enhanced_for_loop=false
+sp_cleanup.correct_indentation=false
+sp_cleanup.format_source_code=false
+sp_cleanup.format_source_code_changes_only=false
+sp_cleanup.insert_inferred_type_arguments=false
+sp_cleanup.make_local_variable_final=true
+sp_cleanup.make_parameters_final=false
+sp_cleanup.make_private_fields_final=true
+sp_cleanup.make_type_abstract_if_missing_method=false
+sp_cleanup.make_variable_declarations_final=false
+sp_cleanup.never_use_blocks=false
+sp_cleanup.never_use_parentheses_in_expressions=true
+sp_cleanup.on_save_use_additional_actions=true
+sp_cleanup.organize_imports=false
+sp_cleanup.qualify_static_field_accesses_with_declaring_class=false
+sp_cleanup.qualify_static_member_accesses_through_instances_with_declaring_class=true
+sp_cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=true
+sp_cleanup.qualify_static_member_accesses_with_declaring_class=false
+sp_cleanup.qualify_static_method_accesses_with_declaring_class=false
+sp_cleanup.remove_private_constructors=true
+sp_cleanup.remove_redundant_modifiers=false
+sp_cleanup.remove_redundant_semicolons=true
+sp_cleanup.remove_redundant_type_arguments=true
+sp_cleanup.remove_trailing_whitespaces=true
+sp_cleanup.remove_trailing_whitespaces_all=true
+sp_cleanup.remove_trailing_whitespaces_ignore_empty=false
+sp_cleanup.remove_unnecessary_casts=true
+sp_cleanup.remove_unnecessary_nls_tags=true
+sp_cleanup.remove_unused_imports=true
+sp_cleanup.remove_unused_local_variables=false
+sp_cleanup.remove_unused_private_fields=true
+sp_cleanup.remove_unused_private_members=false
+sp_cleanup.remove_unused_private_methods=true
+sp_cleanup.remove_unused_private_types=true
+sp_cleanup.sort_members=false
+sp_cleanup.sort_members_all=false
+sp_cleanup.use_anonymous_class_creation=false
+sp_cleanup.use_blocks=false
+sp_cleanup.use_blocks_only_for_return_and_throw=false
+sp_cleanup.use_lambda=true
+sp_cleanup.use_parentheses_in_expressions=false
+sp_cleanup.use_this_for_non_static_field_access=false
+sp_cleanup.use_this_for_non_static_field_access_only_if_necessary=true
+sp_cleanup.use_this_for_non_static_method_access=false
+sp_cleanup.use_this_for_non_static_method_access_only_if_necessary=true

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java

@@ -123,7 +123,7 @@ private static class MissingPropertyCollector implements PropertyResolver {
             "project_loc"); //$NON-NLS-1$
 
     /** The list of unresolved properties. */
-    private List<ResolvableProperty> mUnresolvedProperties = new ArrayList<ResolvableProperty>();
+    private List<ResolvableProperty> mUnresolvedProperties = new ArrayList<>();
 
     /**
      * {@inheritDoc}

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java

@@ -73,10 +73,10 @@ public class CheckConfigurationWorkingCopy implements ICheckConfiguration, Clone
   private String mEditedDescription;
 
   /** The list of resolvable properties. */
-  private List<ResolvableProperty> mProperties = new ArrayList<ResolvableProperty>();
+  private List<ResolvableProperty> mProperties = new ArrayList<>();
 
   /** The map of additional data for this configuration. */
-  private Map<String, String> mAdditionalData = new HashMap<String, String>();
+  private Map<String, String> mAdditionalData = new HashMap<>();
 
   /** flags if the configuration is dirty. */
   private boolean mHasConfigChanged;
@@ -375,10 +375,10 @@ public CheckConfigurationWorkingCopy clone() {
     try {
       clone = (CheckConfigurationWorkingCopy) super.clone();
 
-      clone.mAdditionalData = new HashMap<String, String>();
+      clone.mAdditionalData = new HashMap<>();
       clone.mAdditionalData.putAll(this.mAdditionalData);
 
-      clone.mProperties = new ArrayList<ResolvableProperty>();
+      clone.mProperties = new ArrayList<>();
 
       for (ResolvableProperty prop : mProperties) {
         clone.mProperties.add(prop.clone());

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java

@@ -82,8 +82,8 @@ public class GlobalCheckConfigurationWorkingSet implements ICheckConfigurationWo
   GlobalCheckConfigurationWorkingSet(List<ICheckConfiguration> checkConfigs,
           ICheckConfiguration defaultConfig, ICheckConfiguration defaultBuiltInCheckConfiguration) {
 
-    mWorkingCopies = new ArrayList<CheckConfigurationWorkingCopy>();
-    mDeletedConfigurations = new ArrayList<CheckConfigurationWorkingCopy>();
+    mWorkingCopies = new ArrayList<>();
+    mDeletedConfigurations = new ArrayList<>();
     mDefaultBuiltInCheckConfig = defaultBuiltInCheckConfiguration;
 
     for (ICheckConfiguration cfg : checkConfigs) {
@@ -211,7 +211,7 @@ public boolean isDirty() {
   @Override
   public Collection<IProject> getAffectedProjects() throws CheckstylePluginException {
 
-    Set<IProject> projects = new HashSet<IProject>();
+    Set<IProject> projects = new HashSet<>();
 
     CheckConfigurationWorkingCopy[] workingCopies = this.getWorkingCopies();
     for (int i = 0; i < workingCopies.length; i++) {

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java

@@ -47,7 +47,7 @@ public class Module implements Cloneable {
   private RuleMetadata mMetaData;
 
   /** the properties of the modules. */
-  private List<ConfigProperty> mProperties = new ArrayList<ConfigProperty>();
+  private List<ConfigProperty> mProperties = new ArrayList<>();
 
   /** the comment of the module. */
   private String mComment;
@@ -56,7 +56,7 @@ public class Module implements Cloneable {
   private String mId;
 
   /** the custom messages for this module. */
-  private final Map<String, String> mCustomMessages = new HashMap<String, String>();
+  private final Map<String, String> mCustomMessages = new HashMap<>();
 
   /** the severity level. */
   private Severity mSeverityLevel = Severity.inherit;
@@ -65,7 +65,7 @@ public class Module implements Cloneable {
   private Severity mLastEnabledSeverity;
 
   /** map containing unknown custom metadata of the module. */
-  private final Map<String, String> mCustomMetaData = new HashMap<String, String>();
+  private final Map<String, String> mCustomMetaData = new HashMap<>();
 
   //
   // constructors
@@ -303,7 +303,7 @@ public Map<String, String> getCustomMetaData() {
   public Module clone() {
     try {
       Module clone = (Module) super.clone();
-      clone.mProperties = new ArrayList<ConfigProperty>();
+      clone.mProperties = new ArrayList<>();
 
       for (ConfigProperty prop : mProperties) {
         clone.getProperties().add(prop.clone());

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationTypes.java

@@ -71,7 +71,7 @@ public final class ConfigurationTypes {
    */
   static {
 
-    CONFIGURATION_TYPES = new LinkedHashMap<String, IConfigurationType>();
+    CONFIGURATION_TYPES = new LinkedHashMap<>();
 
     IExtensionRegistry pluginRegistry = Platform.getExtensionRegistry();
 
@@ -116,7 +116,7 @@ private ConfigurationTypes() {
    * @return the configuration types.
    */
   public static IConfigurationType[] getCreatableConfigTypes() {
-    List<IConfigurationType> creatableTypes = new ArrayList<IConfigurationType>();
+    List<IConfigurationType> creatableTypes = new ArrayList<>();
 
     for (IConfigurationType type : CONFIGURATION_TYPES.values()) {
       if (type.isCreatable()) {
@@ -135,7 +135,7 @@ public static IConfigurationType[] getCreatableConfigTypes() {
    */
   public static IConfigurationType[] getConfigurableConfigTypes() {
 
-    List<IConfigurationType> configurableTypes = new ArrayList<IConfigurationType>();
+    List<IConfigurationType> configurableTypes = new ArrayList<>();
     configurableTypes.addAll(Arrays.asList(getCreatableConfigTypes()));
 
     IConfigurationType remoteType = getByInternalName("remote"); //$NON-NLS-1$

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/MultiPropertyResolver.java

@@ -39,7 +39,7 @@
 public class MultiPropertyResolver implements PropertyResolver, IContextAware {
 
   /** The list of PropertyResolvers. */
-  private List<PropertyResolver> mChildResolver = new ArrayList<PropertyResolver>();
+  private List<PropertyResolver> mChildResolver = new ArrayList<>();
 
   /**
    * Adds a PropertyResolver to this aggregation property resolver.

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/AllTokensProvider.java

@@ -35,7 +35,7 @@
 public class AllTokensProvider implements IOptionProvider {
 
   /** the list of options. */
-  private static List<String> sAllOptions = new ArrayList<String>();
+  private static List<String> sAllOptions = new ArrayList<>();
 
   /** Static initializer. Builds the option list. */
   static {

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/ConfigPropertyMetadata.java

@@ -46,7 +46,7 @@ public class ConfigPropertyMetadata {
   private String mDescription;
 
   /** The list of possible property values. */
-  private List<String> mEnumeration = new ArrayList<String>();
+  private List<String> mEnumeration = new ArrayList<>();
 
   /**
    * Creates the property metadata.

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/RuleMetadata.java

@@ -57,7 +57,7 @@ public class RuleMetadata {
   private final Severity mDefaultSeverityLevel;
 
   /** The list of property metadata. */
-  private final List<ConfigPropertyMetadata> mConfigPropMetadata = new LinkedList<ConfigPropertyMetadata>();
+  private final List<ConfigPropertyMetadata> mConfigPropMetadata = new LinkedList<>();
 
   /** The group. */
   private final RuleGroupMetadata mGroup;
@@ -106,9 +106,9 @@ public RuleMetadata(String ruleName, String internalName, String parent, Severit
     mHasSeverity = hasSeverity;
     mIsDeletable = deletable;
     mGroup = group;
-    mAlternativeNames = new ArrayList<String>();
-    mQuickfixes = new ArrayList<String>();
-    mMessageKeys = new ArrayList<String>();
+    mAlternativeNames = new ArrayList<>();
+    mQuickfixes = new ArrayList<>();
+    mMessageKeys = new ArrayList<>();
     mIsSingleton = isSingleton;
   }