resolve OverridableMethodInConstructor violations

Author: Calixte

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigProperty.java

@@ -28,16 +28,16 @@
 public class ConfigProperty implements Comparable<ConfigProperty>, Cloneable {
 
   /** The name of the property. */
-  private String mName;
+  private String name;
 
   /** The value of the property. */
-  private String mValue;
+  private String value;
 
   /** The meta data of the property. */
-  private ConfigPropertyMetadata mMetaData;
+  private ConfigPropertyMetadata metaData;
 
   /** Signals that the property value is actually a ${}-like reference. */
-  private boolean mPropertyReference;
+  private boolean propertyReference;
 
   /**
    * Constructor.
@@ -46,10 +46,9 @@ public class ConfigProperty implements Comparable<ConfigProperty>, Cloneable {
    *          the property meta data
    */
   public ConfigProperty(ConfigPropertyMetadata metaData) {
-
     this(metaData.getName(), metaData.getOverrideDefault() != null ? metaData.getOverrideDefault()
             : metaData.getDefaultValue());
-    setMetaData(metaData);
+    this.metaData = metaData;
   }
 
   /**
@@ -61,8 +60,8 @@ public ConfigProperty(ConfigPropertyMetadata metaData) {
    *          Property value.
    */
   public ConfigProperty(String name, String value) {
-    setName(name);
-    setValue(value);
+    this.name = name;
+    this.value = value;
   }
 
   /**
@@ -71,7 +70,7 @@ public ConfigProperty(String name, String value) {
    * @return The name
    */
   public String getName() {
-    return mName;
+    return name;
   }
 
   /**
@@ -81,7 +80,7 @@ public String getName() {
    *          The new name.
    */
   public void setName(String name) {
-    mName = name;
+    this.name = name;
   }
 
   /**
@@ -90,7 +89,7 @@ public void setName(String name) {
    * @return String
    */
   public String getValue() {
-    return mValue;
+    return value;
   }
 
   /**
@@ -100,7 +99,7 @@ public String getValue() {
    *          The value to set
    */
   public void setValue(String value) {
-    mValue = value;
+    this.value = value;
   }
 
   /**
@@ -109,7 +108,7 @@ public void setValue(String value) {
    * @return the meta data
    */
   public ConfigPropertyMetadata getMetaData() {
-    return mMetaData;
+    return metaData;
   }
 
   /**
@@ -119,7 +118,7 @@ public ConfigPropertyMetadata getMetaData() {
    *          the meta data
    */
   public void setMetaData(ConfigPropertyMetadata metaData) {
-    mMetaData = metaData;
+    this.metaData = metaData;
   }
 
   /**
@@ -128,7 +127,7 @@ public void setMetaData(ConfigPropertyMetadata metaData) {
    * @return <code>true</code> if the value is a property reference, <code>false</code> otherwise
    */
   public boolean isPropertyReference() {
-    return mPropertyReference;
+    return propertyReference;
   }
 
   /**
@@ -138,12 +137,12 @@ public boolean isPropertyReference() {
    *          <code>true</code> if the value is a property reference, <code>false</code> otherwise
    */
   public void setPropertyReference(boolean propertyReference) {
-    this.mPropertyReference = propertyReference;
+    this.propertyReference = propertyReference;
   }
 
   @Override
   public int compareTo(ConfigProperty obj) {
-    return this.mName.compareTo(obj.mName);
+    return this.name.compareTo(obj.name);
   }
 
   @Override

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java

@@ -33,10 +33,10 @@
 public class ResolvableProperty implements Cloneable {
 
   /** The name of the property. */
-  private String mPropertyName;
+  private String propertyName;
 
   /** The property value. */
-  private String mValue;
+  private String value;
 
   /**
    * Creates a resolvable property.
@@ -47,38 +47,38 @@ public class ResolvableProperty implements Cloneable {
    *          the value of the property
    */
   public ResolvableProperty(String propertyName, String value) {
-    setPropertyName(propertyName);
-    setValue(value);
+    this.propertyName = propertyName;
+    this.value = value;
   }
 
   /**
    * @return The value of the property.
    */
   public String getValue() {
-    return mValue;
+    return value;
   }
 
   /**
    * @return The property's name.
    */
   public String getPropertyName() {
-    return mPropertyName;
+    return propertyName;
   }
 
   /**
-   * @param string
+   * @param value
    *          Value for the property.
    */
-  public void setValue(String string) {
-    mValue = string;
+  public void setValue(String value) {
+    this.value = value;
   }
 
   /**
-   * @param string
+   * @param propertyName
    *          The property's name.
    */
-  public void setPropertyName(String string) {
-    mPropertyName = string;
+  public void setPropertyName(String propertyName) {
+    this.propertyName = propertyName;
   }
 
   @Override
@@ -90,12 +90,12 @@ public boolean equals(Object obj) {
       return true;
     }
     ResolvableProperty rhs = (ResolvableProperty) obj;
-    return Objects.equals(mPropertyName, rhs.mPropertyName) && Objects.equals(mValue, rhs.mValue);
+    return Objects.equals(propertyName, rhs.propertyName) && Objects.equals(value, rhs.value);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(mPropertyName, mValue);
+    return Objects.hash(propertyName, value);
   }
 
   @Override
@@ -111,7 +111,7 @@ public ResolvableProperty clone() {
 
   @Override
   public String toString() {
-    return MoreObjects.toStringHelper(this).add("propertyName", mPropertyName).add("value", mValue)
+    return MoreObjects.toStringHelper(this).add("propertyName", propertyName).add("value", value)
             .toString();
   }
 }

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/FileMatchPattern.java

@@ -35,11 +35,11 @@
  */
 public class FileMatchPattern implements Cloneable {
 
-  private boolean mIsIncludePattern = true;
+  private boolean isIncludePattern = true;
 
-  private Pattern mRegexPattern;
+  private Pattern regexPattern;
 
-  private String mPatternString;
+  private String patternString;
 
   /**
    * Construct a new <code>FileMatchPattern</code>.
@@ -59,7 +59,7 @@ public FileMatchPattern(String pattern) throws CheckstylePluginException {
    * @return String
    */
   public String getMatchPattern() {
-    return mRegexPattern.pattern();
+    return regexPattern.pattern();
   }
 
   /**
@@ -70,13 +70,13 @@ public String getMatchPattern() {
    * @throws CheckstylePluginException
    *           Error during processing
    */
-  public void setMatchPattern(String pattern) throws CheckstylePluginException {
+  public final void setMatchPattern(String pattern) throws CheckstylePluginException {
     if ((pattern == null) || (pattern.trim().length() == 0)) {
       throw new CheckstylePluginException(Messages.errorEmptyPattern);
     }
     try {
-      mRegexPattern = Pattern.compile(pattern);
-      mPatternString = pattern;
+      regexPattern = Pattern.compile(pattern);
+      patternString = pattern;
     } catch (PatternSyntaxException ex) {
       // wrap the exception
       CheckstylePluginException.rethrow(ex);
@@ -93,7 +93,7 @@ public void setMatchPattern(String pattern) throws CheckstylePluginException {
   public boolean isMatch(String fileName) {
     boolean result = false;
 
-    Matcher matcher = mRegexPattern.matcher(fileName);
+    Matcher matcher = regexPattern.matcher(fileName);
     result = matcher.find();
 
     return result;
@@ -105,7 +105,7 @@ public boolean isMatch(String fileName) {
    * @return boolean
    */
   public boolean isIncludePattern() {
-    return mIsIncludePattern;
+    return isIncludePattern;
   }
 
   /**
@@ -115,7 +115,7 @@ public boolean isIncludePattern() {
    *          The isIncludePattern to set
    */
   public void setIsIncludePattern(boolean isIncludePattern) {
-    mIsIncludePattern = isIncludePattern;
+    this.isIncludePattern = isIncludePattern;
   }
 
   /**
@@ -143,18 +143,18 @@ public boolean equals(Object obj) {
     }
 
     FileMatchPattern rhs = (FileMatchPattern) obj;
-    return Objects.equals(mIsIncludePattern, rhs.mIsIncludePattern)
-            && Objects.equals(mPatternString, rhs.mPatternString);
+    return Objects.equals(isIncludePattern, rhs.isIncludePattern)
+            && Objects.equals(patternString, rhs.patternString);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(mIsIncludePattern, mPatternString);
+    return Objects.hash(isIncludePattern, patternString);
   }
 
   @Override
   public String toString() {
-    return MoreObjects.toStringHelper(this).add("patternString", mPatternString)
-            .add("isIncludePattern", mIsIncludePattern).toString();
+    return MoreObjects.toStringHelper(this).add("patternString", patternString)
+            .add("isIncludePattern", isIncludePattern).toString();
   }
 }