Skip to content

Commit c6ef26d

Browse files
BananeweizenCalixte
authored andcommitted
Improve preference export description
* use better icon * add description * use Eclipse terms Also remove invalid Javadoc part of preference page.
1 parent e65f035 commit c6ef26d

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

net.sf.eclipsecs.ui/OSGI-INF/l10n/bundle.properties

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@ MarkerStatsView.name = Checkstyle violations
3939

4040
VotingPage.name = Voting
4141

42-
CheckstylePreferenceTransfer.name = Checkstyle settings
43-
CheckstylePreferenceTransfer.description = Copies the workspace configuration for the Eclipse Checkstyle Plugin
42+
CheckstylePreferenceTransfer.name = Checkstyle Preferences
43+
CheckstylePreferenceTransfer.description = General Checkstyle preferences. Does NOT include Checkstyle configurations. Use the "Export" button next to the configurations table to export those.
44+
CheckstylePreferenceTransfer.settingsDescription = Copies the workspace configuration for the Eclipse Checkstyle Plugin
4445

4546
PurgeCaches.label = Purge Checkstyle caches
4647
PurgeCaches.tooltip = Purges internal Checkstyle caches to force reloading of auxiliary configuration files (e.g. suppression.xml)

net.sf.eclipsecs.ui/plugin.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,15 @@
7272
<transfer
7373
id="net.sf.eclipsecs.ui.transfer"
7474
name="%CheckstylePreferenceTransfer.name"
75-
icon="icons/checkstyle_error.gif">
75+
icon="icons/checkstyle_command.png">
7676
<mapping
7777
scope="instance" >
7878
<entry node="net.sf.eclipsecs.core"/>
7979
<entry node="net.sf.eclipsecs.ui"/>
8080
</mapping>
81+
<description>
82+
%CheckstylePreferenceTransfer.description
83+
</description>
8184
</transfer>
8285
<settingsTransfer
8386
id="net.sf.eclipsecs.settings"

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@
7171
import net.sf.eclipsecs.ui.util.SWTUtil;
7272

7373
/**
74-
* This class represents a preference page that is contributed to the Preferences dialog. By
75-
* subclassing <samp>FieldEditorPreferencePage </samp>, we can use the field support built into
76-
* JFace that allows us to create a page that is small and knows how to save, restore and apply
77-
* itself.
78-
*
74+
* This class represents a preference page that is contributed to the Preferences dialog.
7975
* <p>
8076
* This page is used to modify preferences only. They are stored in the preference store that
8177
* belongs to the main plug-in class. That way, preferences can be accessed directly via the

0 commit comments

Comments
 (0)