minor: fix several deprecations

Author: Bananeweizen

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java

@@ -389,7 +389,7 @@ public static RuleMetadata createGenericMetadata(Module module) {
       Class<?> checkClass = CheckstylePlugin.getDefault().getAddonExtensionClassLoader()
               .loadClass(module.getName());
 
-      Object moduleInstance = checkClass.newInstance();
+      Object moduleInstance = checkClass.getDeclaredConstructor().newInstance();
 
       if (moduleInstance instanceof AbstractFileSetCheck) {
         parent = XMLTags.CHECKER_MODULE;
@@ -841,7 +841,7 @@ private static void processProperties(Element moduleElement, RuleMetadata module
 
             if (IOptionProvider.class.isAssignableFrom(providerClass)) {
 
-              IOptionProvider provider = (IOptionProvider) providerClass.newInstance();
+              IOptionProvider provider = (IOptionProvider) providerClass.getDeclaredConstructor().newInstance();
               property.getPropertyEnumeration().addAll(provider.getOptions());
             } else if (Enum.class.isAssignableFrom(providerClass)) {
 

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleTransformer.java

@@ -99,15 +99,15 @@ private void loadTransformationClasses(final List<String> classnames)
       try {
         transformationClass = CheckstylePlugin.getDefault().getAddonExtensionClassLoader()
                 .loadClass(name);
-        final CTransformationClass transObj = (CTransformationClass) transformationClass
+        final CTransformationClass transObj = (CTransformationClass) transformationClass.getDeclaredConstructor()
                 .newInstance();
         transObj.setRule(rule);
         mTransformationClasses.add(transObj);
         // Logger.writeln("using " + name + " to transform rule \""
         // + rule.getName() + "\"");
       } catch (final ClassNotFoundException e) {
         // NOOP there is just no appropriate transformer class
-      } catch (final InstantiationException | IllegalAccessException e) {
+      } catch (final ReflectiveOperationException e) {
         CheckstylePluginException.rethrow(e);
       }
     }

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterTransformer.java

@@ -97,7 +97,7 @@ private void loadTransformationClasses(final List<String> classnames)
         transformationClass = CheckstylePlugin.getDefault().getAddonExtensionClassLoader()
                 .loadClass(name);
 
-        final FTransformationClass transObj = (FTransformationClass) transformationClass
+        final FTransformationClass transObj = (FTransformationClass) transformationClass.getDeclaredConstructor()
                 .newInstance();
 
         transObj.setValue(mFormatterSetting.getFormatterSettings().get(rule));
@@ -106,7 +106,7 @@ private void loadTransformationClasses(final List<String> classnames)
 
       } catch (final ClassNotFoundException e) {
         // NOOP no appropriate transformer class present
-      } catch (final InstantiationException | IllegalAccessException e) {
+      } catch (final ReflectiveOperationException e) {
         CheckstylePluginException.rethrow(e);
       }
     }

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPlugin.java

@@ -43,6 +43,7 @@
 import org.eclipse.ui.IWorkbenchPage;
 import org.eclipse.ui.IWorkbenchPartReference;
 import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.plugin.AbstractUIPlugin;
 import org.osgi.framework.BundleContext;
 
@@ -81,7 +82,7 @@ public void start(BundleContext context) throws Exception {
             QUICKFIX_PROVIDER_EXT_PT_ID);
 
     // add listeners for the Check-On-Open support
-    final IWorkbench workbench = getWorkbench();
+    final IWorkbench workbench = PlatformUI.getWorkbench();
     workbench.getDisplay().asyncExec(new Runnable() {
       @Override
       public void run() {

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java

@@ -39,7 +39,7 @@
 /**
  * Register for the configuration types ui thats use the
  * <i>net.sf.eclipsecs.ui.configtypesui </i> extension point.
- * 
+ *
  * @author Lars Ködderitzsch
  */
 public final class ConfigurationTypesUI {
@@ -106,7 +106,7 @@ private ConfigurationTypesUI() {
 
   /**
    * Creates the editor for a given configuration type.
-   * 
+   *
    * @param configType
    *          the configuration type
    * @return the editor
@@ -122,9 +122,9 @@ public static ICheckConfigurationEditor getNewEditor(IConfigurationType configTy
     if (editorClass != null) {
 
       try {
-        ICheckConfigurationEditor editor = editorClass.newInstance();
+        ICheckConfigurationEditor editor = editorClass.getDeclaredConstructor().newInstance();
         return editor;
-      } catch (InstantiationException | IllegalAccessException | ClassCastException e) {
+      } catch (ClassCastException | ReflectiveOperationException e) {
         CheckstylePluginException.rethrow(e);
       }
     }
@@ -134,7 +134,7 @@ public static ICheckConfigurationEditor getNewEditor(IConfigurationType configTy
 
   /**
    * Return an image for the given configuration type.
-   * 
+   *
    * @param configType
    *          the configuration type
    * @return the image representing the configuration type or <code>null</code>

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java

@@ -34,7 +34,7 @@
 /**
  * Register for the filter editors thats use the
  * <i>net.sf.eclipsecs.ui.filtereditors </i> extension point.
- * 
+ *
  * @author Lars Ködderitzsch
  */
 public final class PluginFilterEditors {
@@ -84,7 +84,7 @@ private PluginFilterEditors() {
 
   /**
    * Determines if a given filter has an editor.
-   * 
+   *
    * @param filter
    *          the filter
    * @return <code>true</code> if the filter has an editor, <code>false</code>
@@ -96,7 +96,7 @@ public static boolean hasEditor(IFilter filter) {
 
   /**
    * Creates the filter editor for a given filter.
-   * 
+   *
    * @param filter
    *          the filter
    * @return the filter editor
@@ -110,9 +110,9 @@ public static IFilterEditor getNewEditor(IFilter filter) throws CheckstylePlugin
     if (editorClass != null) {
 
       try {
-        IFilterEditor editor = editorClass.newInstance();
+        IFilterEditor editor = editorClass.getDeclaredConstructor().newInstance();
         return editor;
-      } catch (InstantiationException | IllegalAccessException | ClassCastException e) {
+      } catch (ClassCastException | ReflectiveOperationException | SecurityException e) {
         CheckstylePluginException.rethrow(e);
       }
     }

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java

@@ -36,7 +36,7 @@
 
 /**
  * Profides marker resolutions (quickfixes) for Checkstyle markers.
- * 
+ *
  * @author Lars Ködderitzsch
  */
 public class CheckstyleMarkerResolutionGenerator implements IMarkerResolutionGenerator2 {
@@ -104,11 +104,11 @@ private List<ICheckstyleMarkerResolution> getInstantiatedQuickfixes(RuleMetadata
         Class<?> quickfixClass = CheckstyleUIPlugin.getDefault().getQuickfixExtensionClassLoader()
                 .loadClass(quickfixClassName);
 
-        ICheckstyleMarkerResolution fix = (ICheckstyleMarkerResolution) quickfixClass.newInstance();
+        ICheckstyleMarkerResolution fix = (ICheckstyleMarkerResolution) quickfixClass.getDeclaredConstructor().newInstance();
         fix.setRuleMetaData(ruleMetadata);
         fixes.add(fix);
       }
-    } catch (InstantiationException | ClassNotFoundException | IllegalAccessException e) {
+    } catch (ReflectiveOperationException | IllegalArgumentException | SecurityException e) {
       CheckstyleLog.log(e);
     }
     return fixes;

net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java

@@ -28,8 +28,6 @@
 import java.util.List;
 
 import net.sf.eclipsecs.core.builder.CheckstyleMarker;
-import net.sf.eclipsecs.ui.CheckstyleUIPlugin;
-
 import org.eclipse.core.resources.IMarker;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
@@ -39,6 +37,7 @@
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.dialogs.IDialogSettings;
 import org.eclipse.ui.IWorkingSet;
+import org.eclipse.ui.PlatformUI;
 
 /**
  * Filter class for Checkstyle markers. This filter is used by the Checkstyle statistics views.
@@ -380,7 +379,7 @@ public void restoreState(IDialogSettings dialogSettings) {
 
       setting = settings.get(TAG_WORKING_SET);
       if (setting != null) {
-        setWorkingSet(CheckstyleUIPlugin.getDefault().getWorkbench().getWorkingSetManager()
+        setWorkingSet(PlatformUI.getWorkbench().getWorkingSetManager()
                 .getWorkingSet(setting));
       }