#282 set taget to JDK 1.8 but still test and compile with 1.8 and 11

Author: BerndFarkaDyna

.travis.yml

@@ -24,7 +24,10 @@ matrix:
   include:
     - jdk: openjdk11
       env: CMD="./.ci/travis.sh install"
-
+   
+    - jdk: openjdk8
+      env: CMD="./.ci/travis.sh install"
+    
     - jdk: openjdk11
       env: CMD="./.ci/travis.sh integration-tests"
 

pom.xml

@@ -103,7 +103,7 @@
       8.28
     </maven.sevntu.checkstyle.plugin.checkstyle.version>
     <maven.jacoco.plugin.version>0.8.5</maven.jacoco.plugin.version>
-    <java.version>11</java.version>
+    <java.version>1.8</java.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <!-- we disable ITs by default as it need download of 200MB sonar application jar -->
     <skipITs>true</skipITs>

src/it/java/org/checkstyle/plugins/sonar/RunPluginTest.java

@@ -19,6 +19,7 @@
 
 package org.checkstyle.plugins.sonar;
 
+import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.junit.Assert.fail;
 
 import java.io.File;
@@ -157,7 +158,9 @@ private static void executeBuildWithCommonProperties(Build<?> build, boolean bui
 
     private static void assertNoDifferences() {
         try {
-            final String differences = Files.readString(Paths.get(litsDifferencesPath()));
+            final String differences = new String(Files
+                    .readAllBytes(new File(litsDifferencesPath()).toPath()), UTF_8);
+
             Assertions.assertThat(differences)
                     .isEmpty();
         }

src/test/java/org/sonar/plugins/checkstyle/CheckstyleConstantsTest.java

@@ -31,7 +31,7 @@ public class CheckstyleConstantsTest {
     public void privateConstructor() throws ReflectiveOperationException {
         final Constructor<CheckstyleConstants> constructor = CheckstyleConstants.class
                 .getDeclaredConstructor();
-        assertThat(constructor.canAccess(null)).isFalse();
+        assertThat(constructor.isAccessible()).isFalse();
         constructor.setAccessible(true);
         constructor.newInstance();
     }

src/test/java/org/sonar/plugins/checkstyle/CheckstyleSeverityUtilsTest.java

@@ -71,7 +71,8 @@ public void testFromSeverity() {
     public void privateConstructor() throws ReflectiveOperationException {
         final Constructor<CheckstyleSeverityUtils> constructor = CheckstyleSeverityUtils.class
                 .getDeclaredConstructor();
-        assertThat(constructor.canAccess(null)).isFalse();
+
+        assertThat(constructor.isAccessible()).isFalse();
         constructor.setAccessible(true);
         constructor.newInstance();
     }

src/test/java/org/sonar/plugins/checkstyle/internal/ChecksTest.java

@@ -19,6 +19,8 @@
 
 package org.sonar.plugins.checkstyle.internal;
 
+import static java.nio.charset.StandardCharsets.UTF_8;
+
 import java.beans.PropertyDescriptor;
 import java.io.File;
 import java.io.FileInputStream;
@@ -98,7 +100,7 @@ private static void validateSonarRules(Set<Class<?>> modules)
         Assert.assertTrue(RULES_PATH + " must exist", rulesFile.exists());
 
         try {
-            final String input = Files.readString(rulesFile.toPath());
+            final String input = new String(Files.readAllBytes(rulesFile.toPath()), UTF_8);
             final Document document = XmlUtil.getRawXml(rulesFile.getAbsolutePath(), input, input);
             validateSonarRules(document, modules);
         }