Issue #274: update forbiddenapis

Author: Daniel Muehlbachler

pom.xml

@@ -497,7 +497,7 @@
       <plugin>
         <groupId>de.thetaphi</groupId>
         <artifactId>forbiddenapis</artifactId>
-        <version>2.2</version>
+        <version>2.7</version>
         <configuration>
           <targetVersion>${java.version}</targetVersion>
           <failOnUnsupportedJava>false</failOnUnsupportedJava>

src/it/java/org/checkstyle/plugins/sonar/RunPluginTest.java

@@ -27,6 +27,7 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.stream.Collectors;
 
@@ -241,7 +242,8 @@ private File prepareProject() throws IOException {
                     .setParam("repositories", "checkstyle")
                     .executeUnsafely();
             if (!activateRulesResponse.isSuccessful()) {
-                fail(String.format("Failed to activate all rules. %s",
+                fail(String.format(Locale.ROOT,
+                        "Failed to activate all rules. %s",
                         activateRulesResponse.getBodyAsString()));
             }
             // deactivate some rules for test project
@@ -254,7 +256,8 @@ private File prepareProject() throws IOException {
                         .setParam("profile_key", profileKey)
                         .executeUnsafely();
                 if (!deactivateRulesResponse.isSuccessful()) {
-                    fail(String.format("Failed to deactivate rule %s. %s",
+                    fail(String.format(Locale.ROOT,
+                            "Failed to deactivate rule %s. %s",
                             ruleKey,
                             deactivateRulesResponse.getBodyAsString()));
                 }
@@ -272,7 +275,8 @@ private File prepareProject() throws IOException {
                 .setParam("projectKey", PROJECT_KEY)
                 .executeUnsafely();
         if (!assignQpResponse.isSuccessful()) {
-            fail(String.format("Failed to add project to quality profile. %s",
+            fail(String.format(Locale.ROOT,
+                    "Failed to add project to quality profile. %s",
                     assignQpResponse.getBodyAsString()));
         }
 

src/test/java/org/sonar/plugins/checkstyle/CheckstyleConstantsTest.java

@@ -31,7 +31,7 @@ public class CheckstyleConstantsTest {
     public void privateConstructor() throws ReflectiveOperationException {
         final Constructor<CheckstyleConstants> constructor = CheckstyleConstants.class
                 .getDeclaredConstructor();
-        assertThat(constructor.isAccessible()).isFalse();
+        assertThat(constructor.canAccess(null)).isFalse();
         constructor.setAccessible(true);
         constructor.newInstance();
     }

src/test/java/org/sonar/plugins/checkstyle/CheckstyleSeverityUtilsTest.java

@@ -71,7 +71,7 @@ public void testFromSeverity() {
     public void privateConstructor() throws ReflectiveOperationException {
         final Constructor<CheckstyleSeverityUtils> constructor = CheckstyleSeverityUtils.class
                 .getDeclaredConstructor();
-        assertThat(constructor.isAccessible()).isFalse();
+        assertThat(constructor.canAccess(null)).isFalse();
         constructor.setAccessible(true);
         constructor.newInstance();
     }