Issue #353: update to CS 8.40

Author: muhlba91

README.md

@@ -21,6 +21,7 @@ Compatibility matrix from checkstyle team:
 
 Checkstyle Plugin|Sonar min|Sonar max|Checkstyle|Jdk
 -----------------|---------|---------|----------|---
+8.40|7.9  |7.9+|8.40|1.8
 8.39|7.9  |7.9+|8.39|1.8
 8.38|7.9  |7.9+|8.38|1.8
 8.37|7.9  |7.9+|8.37|1.8

pom.xml

@@ -93,7 +93,7 @@
   </ciManagement>
 
   <properties>
-    <checkstyle.version>8.39</checkstyle.version>
+    <checkstyle.version>8.40</checkstyle.version>
     <sonar.version>7.9</sonar.version>
     <sonar-java.version>6.0.0.20538</sonar-java.version>
     <maven.checkstyle.plugin.version>3.1.1</maven.checkstyle.plugin.version>

src/main/resources/org/sonar/l10n/checkstyle.properties

@@ -34,6 +34,7 @@ rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.sizes.OuterTypeNumberChec
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.sizes.OuterTypeNumberCheck.param.max=maximum allowable number of outer types. Default is 1.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck.name=Design For Extension
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck.param.ignoredAnnotations=Annotations which allow the check to skip the method from validation.
+rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck.param.requiredJavadocPhrase=Specify the comment text pattern which qualifies a method as designed for extension. Supports multi-line regex.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.IllegalThrowsCheck.name=Illegal Throws
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.IllegalThrowsCheck.param.illegalClassNames=throw class names to reject
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.IllegalThrowsCheck.param.ignoredMethodNames=names of methods to ignore. Default is "finalize".

src/main/resources/org/sonar/plugins/checkstyle/rules.xml

@@ -493,6 +493,9 @@
     <param key="ignoredAnnotations" type="s{}">
       <defaultValue>Test,Before,After,BeforeClass,AfterClass</defaultValue>
     </param>
+    <param key="requiredJavadocPhrase" type="REGULAR_EXPRESSION">
+      <defaultValue>.*</defaultValue>
+    </param>
   </rule>
 
   <rule key="com.puppycrawl.tools.checkstyle.checks.blocks.EmptyBlockCheck">

src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java

@@ -80,7 +80,7 @@ public void test() {
         // such number should not change during checkstyle version upgrade
         assertThat(duplicatedRuleWithTemplate).hasSize(174);
         // all new Rules should fall in this group
-        assertThat(rulesWithDuplicateTemplate).hasSize(8);
+        assertThat(rulesWithDuplicateTemplate).hasSize(9);
 
         for (RulesDefinition.Rule rule : rules) {
             assertThat(rule.key()).isNotNull();