minor: resolve IntelijIdea inspections (Single character alternation; Scope of variable is too broad; Annotator)

Author: romani

checkstyle-sonar-plugin/config/intellij-idea-inspections.xml

@@ -1977,6 +1977,8 @@
                 <option value="deprecation" />
                 <option value="unchecked" />
                 <option value="rawtypes" />
+                <!-- Locale changes and caching, requires storage of value in advance in final -->
+                <option value="TooBroadScope" />
             </list>
         </option>
     </inspection_tool>

checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java

@@ -60,9 +60,9 @@ public CheckstyleExecutor(CheckstyleConfiguration configuration,
 
     /**
      * Execute Checkstyle and return the generated XML report.
+     * @noinspection TooBroadScope
      */
     public void execute() {
-
         final Locale initialLocale = Locale.getDefault();
         Locale.setDefault(Locale.ENGLISH);
         final ClassLoader initialClassLoader = Thread.currentThread().getContextClassLoader();

checkstyle-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java

@@ -111,8 +111,13 @@ private static JavaResourceLocator createJavaResourceLocator() {
         return new DefaultJavaResourceLocator(null, javaClasspath, null);
     }
 
+    /**
+     * This is fake description just to keep noinspection.
+     * @noinspection TooBroadScope
+     * @throws Exception all could happen
+     */
     @Test
-    public void canGenerateXmlReportInEnglish() throws Exception {
+    public void generateXmlReportInEnglish() throws Exception {
         final Locale initialLocale = Locale.getDefault();
         Locale.setDefault(Locale.FRENCH);
 
@@ -140,7 +145,7 @@ public void canGenerateXmlReportInEnglish() throws Exception {
     }
 
     @Test
-    public void canGenerateXmlReportNull() throws CheckstyleException {
+    public void generateXmlReportNull() throws CheckstyleException {
         final CheckstyleConfiguration conf = mockConf();
         final File report = new File("target/test-tmp/checkstyle-report.xml");
         // delete if exists from a previous run

checkstyle-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/internal/ChecksTest.java

@@ -281,7 +281,7 @@ private static void validateSonarProperties(Map<Object, Object> properties,
             Assert.assertFalse("sonar properties value must not have single quote: "
                             + keyName, keyValue.matches(".*[^'{}]'[^'{}].*"));
             Assert.assertFalse("sonar properties value must not have unescaped braces: "
-                            + keyName, keyValue.matches(".*[^'](\\{|\\})[^'].*"));
+                            + keyName, keyValue.matches(".*[^'](\\{|})[^'].*"));
 
             final String moduleName;