Issue #286: update CS 8.30

Author: Daniel Muehlbachler

README.md

@@ -21,6 +21,7 @@ Compatibility matrix from checkstyle team:
 
 Checkstyle Plugin|Sonar min|Sonar max|Checkstyle|Jdk
 -----------------|---------|---------|----------|---
+4.30|7.9  |7.9+|8.30|1.8
 4.29|7.9  |7.9+|8.29|1.8
 4.28|7.9  |7.9+|8.28|11
 4.27|6.7  |7.7+|8.27|1.8

pom.xml

@@ -93,7 +93,7 @@
   </ciManagement>
 
   <properties>
-    <checkstyle.version>8.29</checkstyle.version>
+    <checkstyle.version>8.30</checkstyle.version>
     <sonar.version>7.9</sonar.version>
     <sonar-java.version>6.0.0.20538</sonar-java.version>
     <maven.checkstyle.plugin.version>3.1.0</maven.checkstyle.plugin.version>

src/it/java/org/checkstyle/plugins/sonar/CheckJarTest.java

@@ -26,7 +26,7 @@
 import org.junit.Test;
 
 public class CheckJarTest {
-    private static final String VERSION = "4.29";
+    private static final String VERSION = "4.30";
 
     @Test
     public void testJarPresence() {

src/main/resources/com/sonar/sqale/checkstyle-model.xml

@@ -1575,6 +1575,19 @@
           <txt>min</txt>
         </prop>
       </chc>
+      <chc>
+        <rule-repo>checkstyle</rule-repo>
+        <rule-key>com.puppycrawl.tools.checkstyle.checks.coding.AvoidDoubleBraceInitializationCheck</rule-key>
+        <prop>
+          <key>remediationFunction</key>
+          <txt>CONSTANT_ISSUE</txt>
+        </prop>
+        <prop>
+          <key>offset</key>
+          <val>20</val>
+          <txt>min</txt>
+        </prop>
+      </chc>
       <chc>
         <rule-repo>checkstyle</rule-repo>
         <rule-key>com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck</rule-key>

src/main/resources/org/sonar/l10n/checkstyle.properties

@@ -152,6 +152,7 @@ rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.AvoidNoArgumentSup
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.NestedTryDepthCheck.name=Nested Try Depth
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.NestedTryDepthCheck.param.max=allowed nesting depth. Default is 1.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.NoArrayTrailingCommaCheck.name=No Array Trailing Comma
+rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.coding.AvoidDoubleBraceInitializationCheck.name=Avoid Double Brace Initialization
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck.name=Trailing Comment
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck.param.legalComment=pattern for text of trailing comment which is allowed. (this patter will not be applied to multiline comments and text of comment will be trimmed before matching)
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck.param.format=pattern for string allowed before comment.

src/main/resources/org/sonar/l10n/checkstyle/rules/checkstyle/com.puppycrawl.tools.checkstyle.checks.coding.AvoidDoubleBraceInitializationCheck.html

@@ -0,0 +1,7 @@
+<p>
+    Detects double brace initialization.
+    <br>
+    Rationale: Double brace initialization (set of Instance Initializers in class body) may look cool, but it is
+    considered as anti-pattern and should be avoided. This is also can lead to a hard-to-detect memory leak, if the
+    anonymous class instance is returned outside and other object(s) hold reference to it.
+</p>

src/main/resources/org/sonar/plugins/checkstyle/rules.xml

@@ -1299,6 +1299,13 @@
     <status>READY</status>
   </rule>
 
+  <rule key="com.puppycrawl.tools.checkstyle.checks.coding.AvoidDoubleBraceInitializationCheck">
+    <priority>MAJOR</priority>
+    <name><![CDATA[Avoid Double Brace Initialization]]></name>
+    <configKey><![CDATA[Checker/TreeWalker/AvoidDoubleBraceInitialization]]></configKey>
+    <status>READY</status>
+  </rule>
+
   <rule key="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck">
     <priority>MINOR</priority>
     <name><![CDATA[Newline At End Of File]]></name>

src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java

@@ -61,7 +61,7 @@ public void test() {
         assertThat(repository.language()).isEqualTo("java");
 
         final List<RulesDefinition.Rule> rules = repository.rules();
-        assertThat(rules).hasSize(170);
+        assertThat(rules).hasSize(171);
 
         for (RulesDefinition.Rule rule : rules) {
             assertThat(rule.key()).isNotNull();