Skip to content

Commit 912220d

Browse files
committed
Issue #534: update checkstyle to 10.19.0
1 parent 21b7548 commit 912220d

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Compatibility matrix from Checkstyle:
1717

1818
| Checkstyle Plugin | Sonar min | Sonar max | Checkstyle | Jdk |
1919
|-------------------|-----------|-----------|------------|-----|
20+
| 10.19.0 | 9.9 | 10.7+ | 10.19.0 | 11 |
2021
| 10.17.0 | 9.9 | 10.0+ | 10.17.0 | 11 |
2122
| 10.16.0 | 9.9 | 10.0+ | 10.16.0 | 11 |
2223
| 10.15.0 | 9.9 | 10.0+ | 10.15.0 | 11 |

config/ant-phase-verify.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<property key="checkstyle.importcontroltest.file" file="config/import-control-test.xml"/>
3636
<property key="checkstyle.suppressions.file" file="config/suppressions.xml"/>
3737
<property key="checkstyle.suppressions-xpath.file" file="config/suppressions-xpath.xml"/>
38+
<property key="checkstyle.java.version" value="11"/>
3839
</checkstyle>
3940

4041
<tstamp>

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@
9393
</ciManagement>
9494

9595
<properties>
96-
<checkstyle.version>10.17.0</checkstyle.version>
96+
<checkstyle.version>10.19.0</checkstyle.version>
9797
<sonar.version>9.9.4.87374</sonar.version>
9898
<sonar.api-version>9.9.0.229</sonar.api-version>
9999
<maven.sevntu.checkstyle.plugin.version>1.44.1</maven.sevntu.checkstyle.plugin.version>
100100
<!-- it should be a version of checkstyle that is compatible/compiled with sevntu -->
101101
<maven.sevntu.checkstyle.plugin.checkstyle.version>
102-
10.17.0
102+
10.19.0
103103
</maven.sevntu.checkstyle.plugin.checkstyle.version>
104104
<antrun.plugin.version>3.1.0</antrun.plugin.version>
105105
<checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle-checks.xml</checkstyle.configLocation>

src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void test() {
7676
// such number should not change during checkstyle version upgrade
7777
assertThat(duplicatedRuleWithTemplate).hasSize(0);
7878
// all new Rules should fall in this group
79-
assertThat(rulesWithDuplicateTemplate).hasSize(186);
79+
assertThat(rulesWithDuplicateTemplate).hasSize(192);
8080

8181
for (RulesDefinition.Rule rule : rules) {
8282
assertThat(rule.key()).isNotNull();

0 commit comments

Comments
 (0)