Issue #367: upgrade to checkstyle 8.42

Author: muhlba91

README.md

@@ -21,6 +21,7 @@ Compatibility matrix from checkstyle team:
 
 Checkstyle Plugin|Sonar min|Sonar max|Checkstyle|Jdk
 -----------------|---------|---------|----------|---
+8.42|7.9  |7.9+|8.42|1.8
 8.41.1|7.9  |7.9+|8.41.1|1.8
 8.40|7.9  |7.9+|8.40|1.8
 8.39|7.9  |7.9+|8.39|1.8

pom.xml

@@ -93,11 +93,11 @@
   </ciManagement>
 
   <properties>
-    <checkstyle.version>8.41.1</checkstyle.version>
+    <checkstyle.version>8.42</checkstyle.version>
     <sonar.version>7.9</sonar.version>
     <sonar-java.version>6.0.0.20538</sonar-java.version>
-    <maven.checkstyle.plugin.version>3.1.1</maven.checkstyle.plugin.version>
-    <maven.sevntu.checkstyle.plugin.version>1.37.1</maven.sevntu.checkstyle.plugin.version>
+    <maven.checkstyle.plugin.version>3.1.2</maven.checkstyle.plugin.version>
+    <maven.sevntu.checkstyle.plugin.version>1.40.0</maven.sevntu.checkstyle.plugin.version>
     <!-- it should be a version of checkstyle that is compatible/compiled with sevntu -->
     <maven.sevntu.checkstyle.plugin.checkstyle.version>
       8.35

src/main/resources/org/sonar/l10n/checkstyle.properties

@@ -90,8 +90,7 @@ rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodChec
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.tokens=definitions to check
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.allowMissingReturnTag=whether to ignore errors when a method returns non-void type does have a return tag in the javadoc. Default is false.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.allowMissingParamTags=whether to ignore errors when a method has parameters but does not have matching param tags in the javadoc. Default is false.
-rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.scope=visibility scope where Javadoc comments are checked
-rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.excludeScope=visibility scope where Javadoc comments are not checked
+rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.accessModifiers=visibility scope where Javadoc comments are checked
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.allowedAnnotations=List of annotations that could allow missed documentation
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.param.validateThrows=Allows validating throws tags
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocContentLocationCheck.name=Javadoc Content Location

src/main/resources/org/sonar/plugins/checkstyle/rules.xml

@@ -857,11 +857,9 @@
     <param key="validateThrows" type="BOOLEAN">
       <defaultValue>false</defaultValue>
     </param>
-    <param key="scope" type="s[nothing,public,protected,package,private,anoninner]">
+    <param key="accessModifiers" type="s[nothing,public,protected,package,private,anoninner]">
       <defaultValue>private</defaultValue>
     </param>
-    <param key="excludeScope" type="s[nothing,public,protected,package,private,anoninner]">
-    </param>
     <param key="allowMissingParamTags" type="BOOLEAN">
       <defaultValue>false</defaultValue>
     </param>

test-resources/docker-compose.yml

@@ -4,6 +4,8 @@ version: "3"
 services:
   sonarqube:
     image: sonarqube:7.9-community
+    # next line is for arm64 devices when testing since SQ does not officially release multi-arch images
+    #image: mwizner/sonarqube:8.7.1-community
     restart: unless-stopped
     depends_on:
       - db