config: upgrade sevntu to 1.44.1

Author: rnveach

config/intellij-idea-inspections.xml

@@ -1184,7 +1184,7 @@
     <option name="IGNORE_JAVADOC_PERIOD" value="true" />
     <option name="IGNORE_DUPLICATED_THROWS" value="false" />
     <option name="IGNORE_POINT_TO_ITSELF" value="false" />
-    <option name="myAdditionalJavadocTags" value="" />
+    <option name="myAdditionalJavadocTags" value="noinspectionreason" />
   </inspection_tool>
   <inspection_tool class="JavaFxDefaultTag" enabled="true" level="ERROR" enabled_by_default="true" />
   <inspection_tool class="JavaFxUnresolvedFxIdReference" enabled="true" level="ERROR" enabled_by_default="true" />

pom.xml

@@ -96,10 +96,10 @@
     <checkstyle.version>10.4</checkstyle.version>
     <sonar.version>8.9.0.43852</sonar.version>
     <sonar-java.version>7.2.0.26923</sonar-java.version>
-    <maven.sevntu.checkstyle.plugin.version>1.42.0</maven.sevntu.checkstyle.plugin.version>
+    <maven.sevntu.checkstyle.plugin.version>1.44.1</maven.sevntu.checkstyle.plugin.version>
     <!-- it should be a version of checkstyle that is compatible/compiled with sevntu -->
     <maven.sevntu.checkstyle.plugin.checkstyle.version>
-      10.0
+      10.4
     </maven.sevntu.checkstyle.plugin.checkstyle.version>
     <antrun.plugin.version>3.1.0</antrun.plugin.version>
     <checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${maven.sevntu.checkstyle.plugin.checkstyle.version}/config/checkstyle_checks.xml</checkstyle.configLocation>

src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java

@@ -65,6 +65,7 @@ public CheckstyleExecutor(CheckstyleConfiguration configuration,
      * Execute Checkstyle and return the generated XML report.
      *
      * @noinspection TooBroadScope
+     * @noinspectionreason Cache the value of the default locale.
      */
     public void execute(SensorContext context) {
         if (Objects.nonNull(listener)) {

src/main/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadata.java

@@ -240,8 +240,8 @@ else if ("anyTokenTypesSet".equals(paramType)) {
      */
     private static boolean isMoreThanVarCharSizeLimit(String... values) {
         int totalByteSize = 0;
-        for (String x : values) {
-            final String tokenString = x + COMMA_STRING;
+        for (String value : values) {
+            final String tokenString = value + COMMA_STRING;
             totalByteSize += tokenString.getBytes(StandardCharsets.UTF_8).length;
         }
         totalByteSize += "'SINGLE_SELECT_LIST,multiple=true,values=\""
@@ -345,9 +345,10 @@ public static String getFullCheckName(String checkName) {
             result.append(MODULE_NAME_EXCEPTIONS.get(checkName));
         }
         else {
-            for (int i = 0; i < checkName.length(); i++) {
-                result.append(checkName.charAt(i));
-                if (i + 1 < checkName.length() && Character.isUpperCase(checkName.charAt(i + 1))) {
+            for (int index = 0; index < checkName.length(); index++) {
+                result.append(checkName.charAt(index));
+                if (index + 1 < checkName.length()
+                        && Character.isUpperCase(checkName.charAt(index + 1))) {
                     result.append(' ');
                 }
             }

src/test/java/org/sonar/plugins/checkstyle/CheckstyleAuditListenerTest.java

@@ -76,39 +76,32 @@ public void before() {
         when(predicates.hasAbsolutePath(anyString())).thenReturn(filePredicate);
     }
 
-    /**
-     * We do suppression to keep code the same in view
-     *
-     * @noinspection TooBroadScope
-     */
     @Test
     public void testUtilityMethods() {
-        AuditEvent eventTest;
-
-        eventTest = new AuditEvent(this, "", new Violation(0, "", "", null, "",
+        final AuditEvent event1 = new AuditEvent(this, "", new Violation(0, "", "", null, "",
                 CheckstyleAuditListenerTest.class, "msg"));
-        assertThat(CheckstyleAuditListener.getLineId(eventTest)).isEqualTo(1);
-        assertThat(CheckstyleAuditListener.getMessage(eventTest)).isEqualTo("msg");
-        assertThat(CheckstyleAuditListener.getRuleKey(eventTest)).isEqualTo(
+        assertThat(CheckstyleAuditListener.getLineId(event1)).isEqualTo(1);
+        assertThat(CheckstyleAuditListener.getMessage(event1)).isEqualTo("msg");
+        assertThat(CheckstyleAuditListener.getRuleKey(event1)).isEqualTo(
                 CheckstyleAuditListenerTest.class.getName());
 
-        eventTest = new AuditEvent(this, "", new Violation(1, "", "", null, "",
+        final AuditEvent event2 = new AuditEvent(this, "", new Violation(1, "", "", null, "",
                 CheckstyleAuditListenerTest.class, "msg"));
-        assertThat(CheckstyleAuditListener.getLineId(eventTest)).isEqualTo(1);
-        assertThat(CheckstyleAuditListener.getMessage(eventTest)).isEqualTo("msg");
-        assertThat(CheckstyleAuditListener.getRuleKey(eventTest)).isEqualTo(
+        assertThat(CheckstyleAuditListener.getLineId(event2)).isEqualTo(1);
+        assertThat(CheckstyleAuditListener.getMessage(event2)).isEqualTo("msg");
+        assertThat(CheckstyleAuditListener.getRuleKey(event2)).isEqualTo(
                 CheckstyleAuditListenerTest.class.getName());
 
-        eventTest = new AuditEvent(this);
-        assertThat(CheckstyleAuditListener.getLineId(eventTest)).isEqualTo(1);
-        assertThat(CheckstyleAuditListener.getMessage(eventTest)).isNull();
-        assertThat(CheckstyleAuditListener.getRuleKey(eventTest)).isNull();
+        final AuditEvent event3 = new AuditEvent(this);
+        assertThat(CheckstyleAuditListener.getLineId(event3)).isEqualTo(1);
+        assertThat(CheckstyleAuditListener.getMessage(event3)).isNull();
+        assertThat(CheckstyleAuditListener.getRuleKey(event3)).isNull();
 
-        eventTest = new AuditEvent(this, "", new Violation(0, "", "", null, "module",
+        final AuditEvent event4 = new AuditEvent(this, "", new Violation(0, "", "", null, "module",
                 CheckstyleAuditListenerTest.class, "msg"));
-        assertThat(CheckstyleAuditListener.getLineId(eventTest)).isEqualTo(1);
-        assertThat(CheckstyleAuditListener.getMessage(eventTest)).isEqualTo("msg");
-        assertThat(CheckstyleAuditListener.getRuleKey(eventTest)).isEqualTo("module");
+        assertThat(CheckstyleAuditListener.getLineId(event4)).isEqualTo(1);
+        assertThat(CheckstyleAuditListener.getMessage(event4)).isEqualTo("msg");
+        assertThat(CheckstyleAuditListener.getRuleKey(event4)).isEqualTo("module");
     }
 
     @Test

src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java

@@ -107,6 +107,7 @@ public void getUrlException() throws URISyntaxException {
      * We do suppression as we need to cache value initialLocale
      *
      * @noinspection TooBroadScope
+     * @noinspectionreason Cache the value of the default locale.
      */
     @Test
     public void generateXmlReportInEnglish() throws Exception {