Issue #292: update to CS 8.32

Author: Daniel Muehlbachler

README.md

@@ -21,6 +21,7 @@ Compatibility matrix from checkstyle team:
 
 Checkstyle Plugin|Sonar min|Sonar max|Checkstyle|Jdk
 -----------------|---------|---------|----------|---
+4.32|7.9  |7.9+|8.32|1.8
 4.31|7.9  |7.9+|8.31|1.8
 4.30|7.9  |7.9+|8.30|1.8
 4.29|7.9  |7.9+|8.29|1.8

pom.xml

@@ -93,7 +93,7 @@
   </ciManagement>
 
   <properties>
-    <checkstyle.version>8.31</checkstyle.version>
+    <checkstyle.version>8.32</checkstyle.version>
     <sonar.version>7.9</sonar.version>
     <sonar-java.version>6.0.0.20538</sonar-java.version>
     <maven.checkstyle.plugin.version>3.1.0</maven.checkstyle.plugin.version>

src/main/resources/com/sonar/sqale/checkstyle-model.xml

@@ -1076,6 +1076,19 @@
           <txt>min</txt>
         </prop>
       </chc>
+      <chc>
+        <rule-repo>checkstyle</rule-repo>
+        <rule-key>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingWhitespaceAfterAsteriskCheck</rule-key>
+        <prop>
+          <key>remediationFunction</key>
+          <txt>CONSTANT_ISSUE</txt>
+        </prop>
+        <prop>
+          <key>offset</key>
+          <val>30</val>
+          <txt>min</txt>
+        </prop>
+      </chc>
       <chc>
         <rule-repo>checkstyle</rule-repo>
         <rule-key>com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck</rule-key>

src/main/resources/org/sonar/l10n/checkstyle.properties

@@ -97,6 +97,7 @@ rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocContentLoc
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocContentLocationCheck.param.location=Specify the policy on placement of the Javadoc content
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocBlockTagLocationCheck.name=Javadoc Block Tag Location
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocBlockTagLocationCheck.param.tags=Specify the javadoc tags to process.
+rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingWhitespaceAfterAsteriskCheck.name=Javadoc Missing Whitespace After Asterisk
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck.name=Missing Javadoc Method
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck.param.tokens=definitions to check
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck.param.scope=visibility scope where Javadoc comments are checked
@@ -479,6 +480,7 @@ rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWord
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.allowedAbbreviations=list of abbreviations that must be skipped for checking. Abbreviations should be separated by comma, no spaces are allowed.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.ignoreFinal=allow to skip variables with final modifier.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.ignoreStatic=allow to skip variables with static modifier.
+rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.ignoreStaticFinal=Allow to skip variables with both static and final modifiers.
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.ignoreOverriddenMethods=Allows to ignore methods tagged with @Override annotation (that usually mean inherited name).
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.param.tokens=tokens to check
 rule.checkstyle.com.puppycrawl.tools.checkstyle.checks.AvoidEscapedUnicodeCharactersCheck.name=Avoid Escaped Unicode Characters

src/main/resources/org/sonar/l10n/checkstyle/rules/checkstyle/com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingWhitespaceAfterAsteriskCheck.html

@@ -0,0 +1,5 @@
+<p>
+    Checks that there is at least one whitespace after the leading asterisk. Although spaces after asterisks are
+    optional in the Javadoc comments, their absence makes the documentation difficult to read. It is the de facto
+    standard to put at least one whitespace after the leading asterisk.
+</p>

src/main/resources/org/sonar/plugins/checkstyle/rules.xml

@@ -868,6 +868,14 @@
     <status>READY</status>
   </rule>
 
+  <rule key="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingWhitespaceAfterAsteriskCheck">
+    <priority>MAJOR</priority>
+    <name><![CDATA[Javadoc Missing Whitespace After Asterisk]]></name>
+    <tag>comment</tag>
+    <configKey><![CDATA[Checker/TreeWalker/JavadocMissingWhitespaceAfterAsterisk]]></configKey>
+    <status>READY</status>
+  </rule>
+
   <rule key="com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck">
     <priority>MAJOR</priority>
     <name><![CDATA[Missing Javadoc Method]]></name>
@@ -1339,8 +1347,8 @@
     <param key="allowLineBreaks" type="BOOLEAN">
       <defaultValue>false</defaultValue>
     </param>
-    <param key="tokens" type="s[COMMA,SEMI,POST_INC,POST_DEC,DOT,GENERIC_START,GENERIC_END,ELLIPSIS,METHOD_REF]">
-      <defaultValue>COMMA,SEMI,POST_INC,POST_DEC,ELLIPSIS</defaultValue>
+    <param key="tokens" type="s[COMMA,SEMI,POST_INC,POST_DEC,DOT,GENERIC_START,GENERIC_END,ELLIPSIS,LABELED_STAT,METHOD_REF]">
+      <defaultValue>COMMA,SEMI,POST_INC,POST_DEC,ELLIPSIS,LABELED_STAT</defaultValue>
     </param>
   </rule>
 
@@ -1910,6 +1918,9 @@
     <param key="ignoreStatic" type="BOOLEAN">
       <defaultValue>true</defaultValue>
     </param>
+    <param key="ignoreStaticFinal" type="BOOLEAN">
+      <defaultValue>true</defaultValue>
+    </param>
     <param key="ignoreOverriddenMethods" type="BOOLEAN">
       <defaultValue>true</defaultValue>
     </param>

src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java

@@ -61,7 +61,7 @@ public void test() {
         assertThat(repository.language()).isEqualTo("java");
 
         final List<RulesDefinition.Rule> rules = repository.rules();
-        assertThat(rules).hasSize(172);
+        assertThat(rules).hasSize(173);
 
         for (RulesDefinition.Rule rule : rules) {
             assertThat(rule.key()).isNotNull();