trying to add ruby 3.4 pipeline in chef-cli

Signed-off-by: nikhil2611 <[email protected]>

Author: nikhil2611

.expeditor/verify.pipeline.yml

@@ -27,6 +27,14 @@ steps:
       docker:
         image: ruby:3.3
 
+- label: run-specs-ruby-3.4
+  command:
+    - .expeditor/run_linux_tests.sh rspec
+  expeditor:
+    executor:
+      docker:
+        image: ruby:3.4
+
 - label: run-specs-windows-3.1
   command:
     - powershell .expeditor/run_windows_tests.ps1 rspec
@@ -46,6 +54,16 @@ steps:
         shell: ["powershell", "-Command"]
         image: rubydistros/windows-2019:3.3
 
+- label: run-specs-windows-ruby-3.4
+  command:
+    - powershell .expeditor/run_windows_tests.ps1 rspec
+  expeditor:
+    executor:
+      docker:
+        host_os: windows
+        shell: ["powershell", "-Command"]
+        image: rubydistros/windows-2019:3.4
+
 - label: cookstyle-generator-cb-tests-ruby-3.1
   command:
     - .expeditor/run_linux_tests.sh "rake style:cookstyle"
@@ -54,10 +72,26 @@ steps:
       docker:
         image: ruby:3.1
 
+- label: cookstyle-generator-cb-tests-ruby-3.4
+  command:
+    - .expeditor/run_linux_tests.sh "rake style:cookstyle"
+  expeditor:
+    executor:
+      docker:
+        image: ruby:3.4
+
 - label: chefstyle-tests-ruby-3.1
   command:
     - .expeditor/run_linux_tests.sh "rake style:chefstyle"
   expeditor:
     executor:
       docker:
         image: ruby:3.1
+
+- label: chefstyle-tests-ruby-3.4
+  command:
+    - .expeditor/run_linux_tests.sh "rake style:chefstyle"
+  expeditor:
+    executor:
+      docker:
+        image: ruby:3.4

Gemfile

@@ -4,6 +4,8 @@ gemspec
 
 gem "logger", "< 1.6" # 1.6 causes errors with mixlib-log < 3.1.1
 gem "chefspec"
+gem "syslog"
+
 group :test do
   gem "rake"
   gem "rspec", "=3.12.0"

spec/unit/policyfile/cookbook_location_specification_spec.rb

@@ -182,7 +182,7 @@
       expect(cookbook_location_spec).to_not be_valid
       expect(cookbook_location_spec.errors.size).to eq(1)
       error = cookbook_location_spec.errors.first
-      expect(error).to eq("Cookbook `my_cookbook' has invalid source options `{:herp=>\"derp\"}'")
+      expect(error).to eq("Cookbook `my_cookbook' has invalid source options `{herp: \"derp\"}'")
     end
 
   end

spec/unit/policyfile_demands_spec.rb

@@ -301,7 +301,7 @@
         it "emits an error" do
           message = <<~MESSAGE
             The installed cookbooks do not contain all the recipes required by your run list(s):
-            Cookbook 'remote-cb' = 1.1.1 {:artifactserver=>"https://supermarket.example/c/remote-cb/1.1.1/download", :version=>"1.1.1"}
+            Cookbook 'remote-cb' = 1.1.1 {artifactserver: "https://supermarket.example/c/remote-cb/1.1.1/download", version: "1.1.1"}
             is missing the following required recipes:
             * this_recipe_doesnt_exist
 
@@ -332,7 +332,7 @@
         it "emits an error" do
           message = <<~MESSAGE
             The installed cookbooks do not contain all the recipes required by your run list(s):
-            Cookbook 'remote-cb' = 1.1.1 {:artifactserver=>"https://supermarket.example/c/remote-cb/1.1.1/download", :version=>"1.1.1"}
+            Cookbook 'remote-cb' = 1.1.1 {artifactserver: "https://supermarket.example/c/remote-cb/1.1.1/download", version: "1.1.1"}
             is missing the following required recipes:
             * this_recipe_doesnt_exist
 
@@ -364,7 +364,7 @@
         it "emits an error" do
           message = <<~MESSAGE
             The installed cookbooks do not contain all the recipes required by your run list(s):
-            Cookbook 'remote-cb' = 1.1.1 {:artifactserver=>"https://supermarket.example/c/remote-cb/1.1.1/download", :version=>"1.1.1"}
+            Cookbook 'remote-cb' = 1.1.1 {artifactserver: "https://supermarket.example/c/remote-cb/1.1.1/download", version: "1.1.1"}
             is missing the following required recipes:
             * this_recipe_doesnt_exist
             * this_also_doesnt_exist

spec/unit/policyfile_evaluation_spec.rb

@@ -72,7 +72,7 @@
                 1: raise 'oops'
 
               Backtrace:
-                TestPolicyfile.rb:1:in `eval_policyfile'
+                TestPolicyfile.rb:1:in 'ChefCLI::Policyfile::DSL#eval_policyfile'
           E
           expect(policyfile.errors.first).to eq(expected_message)
         end
@@ -213,7 +213,7 @@
 
         it "has an invalid source error" do
           expect(policyfile.errors.size).to eq(1)
-          message = "Cookbook `foo' has invalid source options `{:herp=>\"derp\"}'"
+          message = "Cookbook `foo' has invalid source options `{herp: \"derp\"}'"
           expect(policyfile.errors.first).to eq(message)
         end
       end
@@ -546,8 +546,8 @@
         expected = <<~EOH
           Cookbook 'foo' assigned to conflicting sources
 
-          Previous source: {:path=>"local_cookbooks/foo"}
-          Conflicts with: {:chef_server=>"https://mychefserver.example.com"}
+          Previous source: {path: "local_cookbooks/foo"}
+          Conflicts with: {chef_server: "https://mychefserver.example.com"}
         EOH
         expect(policyfile.errors.size).to eq(1)
         expect(policyfile.errors.first).to eq(expected)
@@ -586,7 +586,7 @@
              2: metadata
 
            Backtrace:
-             TestPolicyfile.rb:2:in `eval_policyfile'
+             TestPolicyfile.rb:2:in 'ChefCLI::Policyfile::DSL#eval_policyfile'
         EOH
         expect(File).to receive(:exist?).with("./metadata.rb").and_return(false)
         expect(File).to receive(:exist?).with("./metadata.json").and_return(false)
@@ -612,7 +612,7 @@
              2: metadata
 
            Backtrace:
-             TestPolicyfile.rb:2:in `eval_policyfile'
+             TestPolicyfile.rb:2:in 'ChefCLI::Policyfile::DSL#eval_policyfile'
         EOH
         expect(File).to receive(:exist?).with("./metadata.rb").and_return(true)
         expect(File).to receive(:exist?).with("./metadata.json").and_return(true)