add back ruby platform in gemfile.lock

Remove chef gem form Gemfile, update comments, fix spec

Signed-off-by: neha-p6 <[email protected]>

Author: neha-p6

oc-chef-pedant/Gemfile

@@ -8,11 +8,6 @@ gem "pry-stack_explorer"
 gem "rake"
 gem "rest-client", git: "https://github.com/chef/rest-client.git", branch: "jfm/ucrt_update1"
 
-# We require chef internally to get the version in
-# lib/pedant/request.rb. It's really strange code and it should be
-# revisited.
-# gem "chef", "18.8.46" - commmenting this out to get past loading that enormous gem to only get a version number.
-
 # For "rake chef_zero_spec"
 # PR #352 merged to main but not released yet - use main branch
 gem 'chef-zero', git: "https://github.com/chef/chef-zero.git", branch: "main"

oc-chef-pedant/Gemfile.lock

@@ -60,6 +60,7 @@ GEM
     diff-lcs (1.6.2)
     domain_name (0.6.20240107)
     erubis (2.7.0)
+    ffi (1.17.2)
     ffi (1.17.2-arm64-darwin)
     ffi (1.17.2-x64-mingw-ucrt)
     ffi-win32-extensions (1.0.4)
@@ -131,6 +132,7 @@ GEM
     wmi-lite (1.0.7)
 
 PLATFORMS
+  ruby
   arm64-darwin-23
   x64-mingw-ucrt
 

oc-chef-pedant/lib/pedant/request.rb

@@ -35,7 +35,7 @@ def server_api_version
       $server_api_version
     end
 
-    KNIFE_VERSION = "18.8.46" # Hardcoded for now since we removed chef from the Gemfile. Why on earth would we need the entire chef gem just to get a version number?
+    KNIFE_VERSION = "18.8.46" # This version should be updated manually to point to valid chef release. We've removed chef gem from the Gemfile. Why on earth would we need the entire chef gem just to get a version number?
     # FYI, this must be a valid, shipping version of Chef, or the server will reject requests.
 
     # Headers that are added to all requests

oc-chef-pedant/spec/org_creation/validate_acls_spec.rb

@@ -135,7 +135,7 @@ def self.should_have_default_acls_for(endpoint, *tags, &additional_examples)
     end
 
     context "[default clients]" do
-      should_have_default_acls_for "/clients/#{Pedant::Config.pedant_platform.test_org.name}-validator" do
+      should_have_default_acls_for "/clients/#{validator_name}" do
         let(:create_groups) { admin_groups }
         let(:read_groups)   { user_groups }
         let(:update_groups) { admin_groups }