Skip to content

Commit daa5d51

Browse files
committed
add back ruby platform in gemfile.lock
Remove chef gem form Gemfile, update commentsm fix spec Signed-off-by: neha-p6 <neha.pansare@progress.com>
1 parent 12cd90e commit daa5d51

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

oc-chef-pedant/Gemfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ gem "pry-stack_explorer"
88
gem "rake"
99
gem "rest-client", git: "https://github.com/chef/rest-client.git", branch: "jfm/ucrt_update1"
1010

11-
# We require chef internally to get the version in
12-
# lib/pedant/request.rb. It's really strange code and it should be
13-
# revisited.
14-
# gem "chef", "18.8.46" - commmenting this out to get past loading that enormous gem to only get a version number.
15-
1611
# For "rake chef_zero_spec"
1712
# PR #352 merged to main but not released yet - use main branch
1813
gem 'chef-zero', git: "https://github.com/chef/chef-zero.git", branch: "main"

oc-chef-pedant/Gemfile.lock

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ GEM
131131
wmi-lite (1.0.7)
132132

133133
PLATFORMS
134+
ruby
134135
arm64-darwin-23
135136
x64-mingw-ucrt
136137

oc-chef-pedant/lib/pedant/request.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def server_api_version
3535
$server_api_version
3636
end
3737

38-
KNIFE_VERSION = "18.8.46" # Hardcoded for now since we removed chef from the Gemfile. Why on earth would we need the entire chef gem just to get a version number?
38+
KNIFE_VERSION = "18.8.46" # This version should be updated manually to point to valid chef release. We've removed chef gem from the Gemfile. Why on earth would we need the entire chef gem just to get a version number?
3939
# FYI, this must be a valid, shipping version of Chef, or the server will reject requests.
4040

4141
# Headers that are added to all requests

oc-chef-pedant/spec/org_creation/validate_acls_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def self.should_have_default_acls_for(endpoint, *tags, &additional_examples)
135135
end
136136

137137
context "[default clients]" do
138-
should_have_default_acls_for "/clients/#{Pedant::Config.pedant_platform.test_org.name}-validator" do
138+
should_have_default_acls_for "/clients/#{validator_name}" do
139139
let(:create_groups) { admin_groups }
140140
let(:read_groups) { user_groups }
141141
let(:update_groups) { admin_groups }

0 commit comments

Comments
 (0)