Merge pull request #265 from chef/rishichawda/handle-ruby-34-warnings

assign @stdout, @stderr and @process_status to mutable strings in preparation for ruby 4.0

Author: tpowell-progress

lib/mixlib/shellout.rb

@@ -170,7 +170,8 @@ class ShellOut
     #   cmd = Mixlib::ShellOut.new("apachectl", "start", :user => 'www', :env => nil, :cwd => '/tmp')
     #   cmd.run_command # etc.
     def initialize(*command_args)
-      @stdout, @stderr, @process_status = "", "", ""
+      # Since ruby 4.0 will freeze string literals by default, we are assigning mutable strings here.
+      @stdout, @stderr, @process_status = String.new(""), String.new(""), String.new("")
       @live_stdout = @live_stderr = nil
       @input = nil
       @log_level = :debug

lib/mixlib/shellout/windows/core_ext.rb

@@ -447,7 +447,6 @@ def destroy_environment_block(env_pointer)
 
     def create_process_as_user(token, app, cmd, process_security,
       thread_security, inherit, creation_flags, env, cwd, startinfo, procinfo)
-
       bool = CreateProcessAsUserW(
         token,            # User token handle
         app,              # App name
@@ -479,7 +478,6 @@ def create_process_as_user(token, app, cmd, process_security,
 
     def create_process_with_logon(logon, domain, passwd, logon_flags, app, cmd,
       creation_flags, env, cwd, startinfo, procinfo)
-
       bool = CreateProcessWithLogonW(
         logon,           # User
         domain,          # Domain
@@ -501,7 +499,6 @@ def create_process_with_logon(logon, domain, passwd, logon_flags, app, cmd,
 
     def create_process(app, cmd, process_security, thread_security, inherit,
       creation_flags, env, cwd, startinfo, procinfo)
-
       bool = CreateProcessW(
         app,               # App name
         cmd,               # Command line

spec/mixlib/shellout_spec.rb

@@ -1613,4 +1613,3 @@ def ruby_wo_shell(code)
     end
   end
 end
-