Add mergeable for PRs

Failing a PR because of a merge conflict/bad build/test failure, should
be addressed properly by the PR owner.

Author: chelmertz

internal/github/github.go

@@ -40,6 +40,7 @@ type prSearchResultGraphQl struct {
 		}
 	}
 	ReviewDecision string
+	Mergeable      bool
 	UpdatedAt      string
 	Author         struct {
 		Login string
@@ -264,6 +265,7 @@ func QueryGithub(token string, username string, logger *slog.Logger) ([]types.Vi
 			RepoOwner:                pr.Repository.Owner.Login,
 			RepoUrl:                  pr.Repository.Url,
 			IsDraft:                  pr.IsDraft,
+			Mergeable:                pr.Mergeable,
 			LastUpdated:              updatedAt,
 			LastPrCommenter:          lastPrCommenter,
 			ThreadsActionable:        threadsActionable,
@@ -362,6 +364,7 @@ func querySearchPrsInvolvingUser(username string) string {
             }
           }
           reviewDecision
+          mergeable
           updatedAt
           author {
             login

internal/points/points.go

@@ -57,6 +57,10 @@ func StandardPrPoints(pr types.ViewPr, username string) *Points {
 			// at it
 			points.Add(10, "You should add reviewers")
 		}
+
+		if !pr.Mergeable {
+			points.Add(150, "Some checks failed (failed build/test, merge conflicts, github actions, etc.)")
+		}
 	} else {
 		// someone else's pr, or our but the username is not set
 		if pr.ReviewStatus == "APPROVED" {
@@ -92,6 +96,10 @@ func StandardPrPoints(pr types.ViewPr, username string) *Points {
 		case diff > 300:
 			points.Add(10, fmt.Sprintf("PR is bigish, %d loc changed is >300", diff))
 		}
+
+		if !pr.Mergeable {
+			points.Remove(150, "Some checks failed (failed build/test, merge conflicts, github actions, etc.)")
+		}
 	}
 
 	if pr.ThreadsActionable > 0 {

internal/storage/models.go

@@ -11,6 +11,7 @@ insert into prs (
     repo_owner,
     repo_url,
     is_draft,
+    mergeable,
     last_updated,
     last_pr_commenter,
     threads_actionable,
@@ -20,7 +21,7 @@ insert into prs (
     review_requested_from_users,
     buried
 ) values (
-    ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
+    ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
 ) returning *;
 
 -- name: DeletePrs :exec

internal/storage/query.sql

@@ -7,6 +7,7 @@ create table if not exists prs (
     repo_owner text not null,
     repo_url text not null,
     is_draft boolean not null,
+    mergeable boolean not null,
     last_updated text not null,
     last_pr_commenter text not null,
     threads_actionable integer not null,

internal/storage/query.sql.go

@@ -117,6 +117,7 @@ func (s *Storage) StoreRepoPrs(orderedPrs []types.ViewPr) error {
 			RepoName:                 pr.RepoName,
 			RepoOwner:                pr.RepoOwner,
 			RepoUrl:                  pr.RepoUrl,
+			Mergeable:                pr.Mergeable,
 			IsDraft:                  pr.IsDraft,
 			LastUpdated:              pr.LastUpdated.Format(time.RFC3339),
 			LastPrCommenter:          pr.LastPrCommenter,

internal/storage/schema.sql

@@ -17,6 +17,7 @@ type ViewPr struct {
 	RepoOwner                string
 	RepoUrl                  string
 	IsDraft                  bool
+	Mergeable                bool
 	LastUpdated              time.Time
 	LastPrCommenter          string
 	ThreadsActionable        int