refactor(XMLPatch): streamline element addition logic for improved clarity and maintainability

Author: chemodun

XMLPatch/Program.cs

@@ -441,6 +441,7 @@ private void ApplyAdd(XElement addElement, XElement originalRoot)
               switch (pos)
               {
                 case "before":
+                case "after":
                   if (
                     (ParsedOptions == null || !ParsedOptions.AllowDoubles)
                     && targetElement
@@ -455,48 +456,19 @@ private void ApplyAdd(XElement addElement, XElement originalRoot)
                     Logger.Warn($"Element '{clonedInfo}' already exists in '{parentInfo}'. Skipping.");
                     continue;
                   }
-                  targetElement.AddBeforeSelf(cloned);
-                  Logger.Info($"Added new element '{clonedInfo}' before '{targetInfo}' in '{parentInfo}'.");
-                  latestAdded = cloned;
-                  break;
-                case "after":
-                  if (
-                    (ParsedOptions == null || !ParsedOptions.AllowDoubles)
-                    && targetElement
-                      .Parent!.Elements()
-                      .Any(e =>
-                        e.Name == cloned.Name
-                        && e.Attributes().All(a => cloned.Attribute(a.Name)?.Value == a.Value)
-                        && cloned.Attributes().All(a => e.Attribute(a.Name)?.Value == a.Value)
-                      )
-                  )
+                  if (pos == "before")
                   {
-                    Logger.Warn($"Element '{clonedInfo}' already exists in '{parentInfo}'. Skipping.");
-                    continue;
+                    targetElement.AddBeforeSelf(cloned);
+                    Logger.Info($"Added new element '{clonedInfo}' before '{targetInfo}' in '{parentInfo}'.");
                   }
-                  targetElement.AddAfterSelf(cloned);
-                  Logger.Info($"Added new element '{clonedInfo}' after '{targetInfo}' in '{parentInfo}'.");
-                  latestAdded = cloned;
-                  break;
-                case "prepend":
-                  if (
-                    (ParsedOptions == null || !ParsedOptions.AllowDoubles)
-                    && targetElement
-                      .Elements()
-                      .Any(e =>
-                        e.Name == cloned.Name
-                        && e.Attributes().All(a => cloned.Attribute(a.Name)?.Value == a.Value)
-                        && cloned.Attributes().All(a => e.Attribute(a.Name)?.Value == a.Value)
-                      )
-                  )
+                  else
                   {
-                    Logger.Warn($"Element '{clonedInfo}' already exists in '{targetInfo}'. Skipping.");
-                    continue;
+                    targetElement.AddAfterSelf(cloned);
+                    Logger.Info($"Added new element '{clonedInfo}' after '{targetInfo}' in '{parentInfo}'.");
                   }
-                  targetElement.AddFirst(cloned);
-                  Logger.Info($"Prepended new element '{clonedInfo}' to '{targetInfo}'.");
                   latestAdded = cloned;
                   break;
+                case "prepend":
                 case "append":
                   if (
                     (ParsedOptions == null || !ParsedOptions.AllowDoubles)
@@ -512,8 +484,16 @@ private void ApplyAdd(XElement addElement, XElement originalRoot)
                     Logger.Warn($"Element '{clonedInfo}' already exists in '{targetInfo}'. Skipping.");
                     continue;
                   }
-                  targetElement.Add(cloned);
-                  Logger.Info($"Appended new element '{clonedInfo}' to '{targetInfo}'.");
+                  if (pos == "prepend")
+                  {
+                    targetElement.AddFirst(cloned);
+                    Logger.Info($"Prepended new element '{clonedInfo}' to '{targetInfo}'.");
+                  }
+                  else
+                  {
+                    targetElement.Add(cloned);
+                    Logger.Info($"Appended new element '{clonedInfo}' to '{targetInfo}'.");
+                  }
                   latestAdded = cloned;
                   break;
                 default: