fix(XMLDiff): correct matchedEnough logic for child element comparison to avoid infinity looping

chemodun · chemodun · commit e4de925b7023 · 2025-01-16T15:16:18.000+02:00
diff --git a/XMLDiff/Program.cs b/XMLDiff/Program.cs
@@ -418,7 +418,7 @@ private static bool CompareElements(XDocument original, XDocument modified, XEle
                 var originalChild = originalChildren[i];
                 var modifiedChild = modifiedChildren[j];
 
-                bool matchedEnough = true;
+                bool matchedEnough = false;
                 if (originalChild.Name == modifiedChild.Name)
                 {
                     var originalAttributes = originalChild.Attributes().ToDictionary(a => a.Name.LocalName, a => a.Value);
@@ -428,6 +428,8 @@ private static bool CompareElements(XDocument original, XDocument modified, XEle
 
                     XElement? savedOp = null;
 
+                    matchedEnough = true;
+
                     foreach (var attr in modifiedAttributes)
                     {
                         Logger.Debug($"Checking attribute '{attr.Key}' in original element '{originalAttributes.Keys}'.");

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ private static bool CompareElements(XDocument original, XDocument modified, XEle`
`418`	`418`	`var originalChild = originalChildren[i];`
`419`	`419`	`var modifiedChild = modifiedChildren[j];`
`420`	`420`
`421`		`- bool matchedEnough = true;`
	`421`	`+ bool matchedEnough = false;`
`422`	`422`	`if (originalChild.Name == modifiedChild.Name)`
`423`	`423`	`{`
`424`	`424`	`var originalAttributes = originalChild.Attributes().ToDictionary(a => a.Name.LocalName, a => a.Value);`
`@@ -428,6 +428,8 @@ private static bool CompareElements(XDocument original, XDocument modified, XEle`
`428`	`428`
`429`	`429`	`XElement? savedOp = null;`
`430`	`430`
	`431`	`+ matchedEnough = true;`
	`432`	`+`
`431`	`433`	`foreach (var attr in modifiedAttributes)`
`432`	`434`	`{`
`433`	`435`	`Logger.Debug($"Checking attribute '{attr.Key}' in original element '{originalAttributes.Keys}'.");`