fix: implement IDisposable for TabInfo

Author: chemodun

MainWindow.xaml.cs

@@ -672,6 +672,9 @@ private void CloseTab(TabInfo tabInfo)
       // Remove it from our collection
       tabs.Remove(tabInfo);
 
+      // Properly dispose of the TabInfo to clean up memory and event handlers
+      tabInfo.Dispose();
+
       // If there are no more tabs, consider adding a default one
       if (tabs.Count == 0 && _currentLogFile != null)
       {
@@ -725,6 +728,12 @@ private void LoadProfile(string profilePath)
           {
             tabControl.Items.Remove(item);
           }
+
+          // Dispose all existing tabs before clearing
+          foreach (var tab in tabs)
+          {
+            tab.Dispose();
+          }
           tabs.Clear();
 
           // Clear and load auto tab configurations
@@ -758,6 +767,12 @@ private void LoadProfile(string profilePath)
             {
               tabControl.Items.Remove(item);
             }
+
+            // Dispose all existing tabs before clearing
+            foreach (var tab in tabs)
+            {
+              tab.Dispose();
+            }
             tabs.Clear();
             autoTabConfigs.Clear();
             MenuAutoTabs_Click(this, new RoutedEventArgs());
@@ -1875,6 +1890,20 @@ private void MainWindow_Closing(object? sender, System.ComponentModel.CancelEven
       // Stop forced refresh timer if it's running
       StopForcedRefresh();
 
+      // Dispose all tabs to clean up memory and event handlers
+      foreach (var tab in tabs)
+      {
+        try
+        {
+          tab.Dispose();
+        }
+        catch (Exception ex)
+        {
+          Debug.WriteLine($"Error disposing tab: {ex.Message}");
+        }
+      }
+      tabs.Clear();
+
       // Save current application configuration
       try
       {

TabInfo.cs

@@ -13,10 +13,12 @@ namespace X4LogWatcher
   /// <summary>
   /// Class to hold all information related to a tab in the log watcher
   /// </summary>
-  public class TabInfo : INotifyPropertyChanged
+  public class TabInfo : INotifyPropertyChanged, IDisposable
   {
     public event PropertyChangedEventHandler? PropertyChanged;
 
+    private bool _disposed = false;
+
     private string _regexPattern = string.Empty;
     public string RegexPattern
     {
@@ -301,6 +303,9 @@ private void WatchingCheckBox_Unchecked(object sender, RoutedEventArgs e)
     /// </summary>
     public void AppendContent(string text)
     {
+      if (_disposed)
+        return;
+
       ContentTextBox.AppendText(text);
       ContentTextBox.ScrollToEnd();
     }
@@ -310,6 +315,9 @@ public void AppendContent(string text)
     /// </summary>
     public void ClearContent()
     {
+      if (_disposed)
+        return;
+
       ContentTextBox.Clear();
     }
 
@@ -330,5 +338,76 @@ private void UpdateNewContentIndicator()
       // Just update the tab header text which includes the indicator when HasNewContent is true
       UpdateTabHeader();
     }
+
+    #region IDisposable Implementation
+
+    /// <summary>
+    /// Dispose of resources and unsubscribe from event handlers
+    /// </summary>
+    public void Dispose()
+    {
+      Dispose(true);
+      GC.SuppressFinalize(this);
+    }
+
+    /// <summary>
+    /// Protected dispose method
+    /// </summary>
+    /// <param name="disposing">True if disposing from Dispose() method, false if from finalizer</param>
+    protected virtual void Dispose(bool disposing)
+    {
+      if (!_disposed && disposing)
+      {
+        try
+        {
+          // Unsubscribe from all event handlers to prevent memory leaks
+          if (RegexTextBox != null)
+          {
+            RegexTextBox.TextChanged -= RegexTextBox_TextChanged;
+          }
+
+          if (NameTextBox != null)
+          {
+            NameTextBox.TextChanged -= NameTextBox_TextChanged;
+          }
+
+          if (AfterLinesNumericUpDown != null)
+          {
+            AfterLinesNumericUpDown.ValueChanged -= AfterLinesNumericUpDown_ValueChanged;
+          }
+
+          if (WatchingCheckBox != null)
+          {
+            WatchingCheckBox.Unchecked -= WatchingCheckBox_Unchecked;
+          }
+
+          // Clear property change event handlers
+          PropertyChanged = null;
+
+          // Force garbage collection of large content if present
+          if (ContentTextBox != null && ContentTextBox.Text.Length > 10_000_000) // 10MB threshold
+          {
+            ContentTextBox.Clear();
+          }
+        }
+        catch (Exception ex)
+        {
+          // Log but don't throw during disposal
+          System.Diagnostics.Debug.WriteLine($"Error during TabInfo disposal: {ex.Message}");
+        }
+
+        _disposed = true;
+      }
+    }
+
+    /// <summary>
+    /// Finalizer to ensure disposal if Dispose() wasn't called
+    /// </summary>
+    ~TabInfo()
+    {
+      Dispose(false);
+    }
+
+    #endregion
   }
 }