feat: support extended eval result

Author: chen-keinan

validator/fixture/deny_strict.policy

@@ -1,8 +1,8 @@
 package itsio
-default allow = false
-allow {
+allow :={"name":namespace_name,"allow_policy":allow_policy} {
+	namespace_name:= input.items[0].metadata.namespace
 	some i
 	input.items[i].kind == "PeerAuthentication"
 	mtlsMode := input.items[i].spec.mtls.mode
-	mtlsMode ==  "STRICT"
- }
+	allow_policy = mtlsMode ==  "STRICT"
+  }

validator/policyeval.go

@@ -61,13 +61,12 @@ func (pe policyEval) EvaluatePolicy(queryParam []string, policy string, data str
 	}
 	validateResult := make([]*ValidateResult, 0)
 	if len(res) > 0 {
-		validateResult = append(validateResult, &ValidateResult{Value: res[0].Expressions[0].Value.(bool), ValidateProperty: res[0].Expressions[0].Text})
+		validateResult = append(validateResult, &ValidateResult{ExpressionValue: res[0].Expressions})
 	}
 	return validateResult, nil
 }
 
 //ValidateResult opa validation results
 type ValidateResult struct {
-	Value            bool
-	ValidateProperty string
+	ExpressionValue []*rego.ExpressionValue
 }

validator/policyeval_test.go

@@ -3,6 +3,7 @@ package validator
 import (
 	"fmt"
 	"io/ioutil"
+	"reflect"
 	"testing"
 )
 
@@ -13,15 +14,15 @@ func Test_PolicyEval(t *testing.T) {
 		policy     string
 		pkgName    string
 		policyRule []string
-		want       bool
+		want       interface{}
 		wantError  error
 	}{
 		{name: "test validate policy deny pod name json format", data: "./fixture/pod.json", policyRule: []string{"example.deny"}, policy: "./fixture/pod_policy_deny", want: true, wantError: nil},
 		{name: "test validate policy deny pod name yaml format", data: "./fixture/pod.yaml", policyRule: []string{"example.deny"}, policy: "./fixture/pod_policy_deny", want: true, wantError: nil},
 		{name: "test validate policy allow pod name", data: "./fixture/allow_pod.json", policyRule: []string{"example.deny"}, policy: "./fixture/pod_policy_deny", want: false, wantError: nil},
 		{name: "test validate policy bad data", data: "./fixture/badJson.json", policyRule: []string{"example.deny"}, policy: "./fixture/pod_policy_deny", want: false, wantError: nil},
 		{name: "test validate policy bad policy", data: "./fixture/badJson.json", policyRule: []string{"example.deny"}, policy: "./fixture/pod_policy_deny_bad", want: false, wantError: fmt.Errorf("1 error occurred: eval.rego:5: rego_parse_error: unexpected } token\n\t}\n\t^")},
-		{name: "test validate policy bad policy", data: "./fixture/strict_policy.json", policyRule: []string{"itsio.allow"}, policy: "./fixture/deny_strict.policy", want: true, wantError: nil},
+		{name: "test validate policy bad policy", data: "./fixture/strict_policy.json", policyRule: []string{"itsio.allow"}, policy: "./fixture/deny_strict.policy", want: map[string]interface{}{"allow_policy": true, "name": "foo"}, wantError: nil},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -41,7 +42,7 @@ func Test_PolicyEval(t *testing.T) {
 				}
 			}
 			if err == nil {
-				if got[0].Value != tt.want {
+				if eq := reflect.DeepEqual(got[0].ExpressionValue[0].Value, tt.want); !eq {
 					t.Errorf("Test_PolicyEval() = %v, want %v", got[0], tt.want)
 				}
 			}