Merge pull request #25 from chenmingyong0423/feature/build

chenmingyong0423 · web-flow · commit f4dc843ab292 · 2024-04-07T15:47:55.000+08:00
refactor(aggregation/add): overhaul add function parameter
diff --git a/builder/aggregation/bson_construction_without_key.go b/builder/aggregation/bson_construction_without_key.go
@@ -49,7 +49,7 @@ func MaxWithoutKey(expression any) bson.D {
 	return bson.D{{Key: types.AggregationMax, Value: expression}}
 }
 
-func AddWithoutKey(expression any) bson.D {
+func AddWithoutKey(expression ...any) bson.D {
 	return bson.D{{Key: types.AggregationAdd, Value: expression}}
 }
 
diff --git a/builder/aggregation/bson_construction_without_key_test.go b/builder/aggregation/bson_construction_without_key_test.go
@@ -202,7 +202,7 @@ func TestAddWithoutKey(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			got := AddWithoutKey(tc.expressions)
+			got := AddWithoutKey(tc.expressions...)
 			assert.Equal(t, tc.want, got)
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func MaxWithoutKey(expression any) bson.D {`
`49`	`49`	`return bson.D{{Key: types.AggregationMax, Value: expression}}`
`50`	`50`	`}`
`51`	`51`
`52`		`-func AddWithoutKey(expression any) bson.D {`
	`52`	`+func AddWithoutKey(expression ...any) bson.D {`
`53`	`53`	`return bson.D{{Key: types.AggregationAdd, Value: expression}}`
`54`	`54`	`}`
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ func TestAddWithoutKey(t *testing.T) {`
`202`	`202`
`203`	`203`	`for _, tc := range testCases {`
`204`	`204`	`t.Run(tc.name, func(t *testing.T) {`
`205`		`- got := AddWithoutKey(tc.expressions)`
	`205`	`+ got := AddWithoutKey(tc.expressions...)`
`206`	`206`	`assert.Equal(t, tc.want, got)`
`207`	`207`	`})`
`208`	`208`	`}`