Skip to content

Commit 55cf3ba

Browse files
chenneschennes
committed
Sketcher Tests: add [[maybe_unused]]
1 parent c0569a3 commit 55cf3ba

File tree

1 file changed

+34
-17
lines changed

1 file changed

+34
-17
lines changed

‎tests/src/Mod/Sketcher/App/SketchObject.cpp‎

Lines changed: 34 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ TEST_F(SketchObjectTest, testGetPointFromGeomPoint)
134134
auto ptMid = Sketcher::SketchObject::getPoint(&point, Sketcher::PointPos::mid);
135135
auto ptEnd = Sketcher::SketchObject::getPoint(&point, Sketcher::PointPos::end);
136136
// TODO: Maybe we want this to give an error instead of some default value
137-
auto ptNone = Sketcher::SketchObject::getPoint(&point, Sketcher::PointPos::none);
137+
[[maybe_unused]] auto ptNone =
138+
Sketcher::SketchObject::getPoint(&point, Sketcher::PointPos::none);
138139

139140
// Assert
140141
EXPECT_DOUBLE_EQ(ptStart[0], 1.0);
@@ -156,10 +157,12 @@ TEST_F(SketchObjectTest, testGetPointFromGeomLineSegment)
156157
// Act
157158
auto ptStart = Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::start);
158159
// TODO: Maybe we want this to give an error instead of some default value
159-
auto ptMid = Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::mid);
160+
[[maybe_unused]] auto ptMid =
161+
Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::mid);
160162
auto ptEnd = Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::end);
161163
// TODO: Maybe we want this to give an error instead of some default value
162-
auto ptNone = Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::none);
164+
[[maybe_unused]] auto ptNone =
165+
Sketcher::SketchObject::getPoint(&lineSeg, Sketcher::PointPos::none);
163166

164167
// Assert
165168
EXPECT_DOUBLE_EQ(ptStart[0], 1.0);
@@ -184,7 +187,8 @@ TEST_F(SketchObjectTest, testGetPointFromGeomCircle)
184187
// TODO: Maybe we want this to give an error instead of some default value
185188
auto ptEnd = Sketcher::SketchObject::getPoint(&circle, Sketcher::PointPos::end);
186189
// TODO: Maybe we want this to give an error instead of some default value
187-
auto ptNone = Sketcher::SketchObject::getPoint(&circle, Sketcher::PointPos::none);
190+
[[maybe_unused]] auto ptNone =
191+
Sketcher::SketchObject::getPoint(&circle, Sketcher::PointPos::none);
188192

189193
// Assert
190194
// NOTE: Presently, start/end points of a circle are defined as the point on circle right of the
@@ -215,7 +219,8 @@ TEST_F(SketchObjectTest, testGetPointFromGeomEllipse)
215219
// TODO: Maybe we want this to give an error instead of some default value
216220
auto ptEnd = Sketcher::SketchObject::getPoint(&ellipse, Sketcher::PointPos::end);
217221
// TODO: Maybe we want this to give an error instead of some default value
218-
auto ptNone = Sketcher::SketchObject::getPoint(&ellipse, Sketcher::PointPos::none);
222+
[[maybe_unused]] auto ptNone =
223+
Sketcher::SketchObject::getPoint(&ellipse, Sketcher::PointPos::none);
219224

220225
// Assert
221226
// NOTE: Presently, start/end points of an ellipse are defined as the point on the major axis in
@@ -243,7 +248,8 @@ TEST_F(SketchObjectTest, testGetPointFromGeomArcOfCircle)
243248
auto ptMid = Sketcher::SketchObject::getPoint(&arcOfCircle, Sketcher::PointPos::mid);
244249
auto ptEnd = Sketcher::SketchObject::getPoint(&arcOfCircle, Sketcher::PointPos::end);
245250
// TODO: Maybe we want this to give an error instead of some default value
246-
auto ptNone = Sketcher::SketchObject::getPoint(&arcOfCircle, Sketcher::PointPos::none);
251+
[[maybe_unused]] auto ptNone =
252+
Sketcher::SketchObject::getPoint(&arcOfCircle, Sketcher::PointPos::none);
247253

248254
// Assert
249255
// NOTE: parameters for arc of circle are CCW angles from positive x-axis
@@ -273,7 +279,8 @@ TEST_F(SketchObjectTest, testGetPointFromGeomArcOfEllipse)
273279
auto ptMid = Sketcher::SketchObject::getPoint(&arcOfEllipse, Sketcher::PointPos::mid);
274280
auto ptEnd = Sketcher::SketchObject::getPoint(&arcOfEllipse, Sketcher::PointPos::end);
275281
// TODO: Maybe we want this to give an error instead of some default value
276-
auto ptNone = Sketcher::SketchObject::getPoint(&arcOfEllipse, Sketcher::PointPos::none);
282+
[[maybe_unused]] auto ptNone =
283+
Sketcher::SketchObject::getPoint(&arcOfEllipse, Sketcher::PointPos::none);
277284

278285
// Assert
279286
// NOTE: parameters for arc of ellipse are CCW angles from positive x-axis
@@ -299,11 +306,14 @@ TEST_F(SketchObjectTest, testGetPointFromGeomArcOfHyperbola)
299306
arcOfHyperbola.setRange(startParam, endParam, true);
300307

301308
// Act
302-
auto ptStart = Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::start);
309+
[[maybe_unused]] auto ptStart =
310+
Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::start);
303311
auto ptMid = Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::mid);
304-
auto ptEnd = Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::end);
312+
[[maybe_unused]] auto ptEnd =
313+
Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::end);
305314
// TODO: Maybe we want this to give an error instead of some default value
306-
auto ptNone = Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::none);
315+
[[maybe_unused]] auto ptNone =
316+
Sketcher::SketchObject::getPoint(&arcOfHyperbola, Sketcher::PointPos::none);
307317

308318
// Assert
309319
// FIXME: Figure out how this is defined
@@ -327,11 +337,14 @@ TEST_F(SketchObjectTest, testGetPointFromGeomArcOfParabola)
327337
arcOfParabola.setRange(startParam, endParam, true);
328338

329339
// Act
330-
auto ptStart = Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::start);
340+
[[maybe_unused]] auto ptStart =
341+
Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::start);
331342
auto ptMid = Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::mid);
332-
auto ptEnd = Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::end);
343+
[[maybe_unused]] auto ptEnd =
344+
Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::end);
333345
// TODO: Maybe we want this to give an error instead of some default value
334-
auto ptNone = Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::none);
346+
[[maybe_unused]] auto ptNone =
347+
Sketcher::SketchObject::getPoint(&arcOfParabola, Sketcher::PointPos::none);
335348

336349
// Assert
337350
// FIXME: Figure out how this is defined
@@ -366,10 +379,12 @@ TEST_F(SketchObjectTest, testGetPointFromGeomBSplineCurveNonPeriodic)
366379
// Act
367380
auto ptStart = Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::start);
368381
// TODO: Maybe we want this to give an error instead of some default value
369-
auto ptMid = Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::mid);
382+
[[maybe_unused]] auto ptMid =
383+
Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::mid);
370384
auto ptEnd = Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::end);
371385
// TODO: Maybe we want this to give an error instead of some default value
372-
auto ptNone = Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::none);
386+
[[maybe_unused]] auto ptNone =
387+
Sketcher::SketchObject::getPoint(&nonPeriodicBSpline, Sketcher::PointPos::none);
373388

374389
// Assert
375390
EXPECT_DOUBLE_EQ(ptStart[0], poles.front()[0]);
@@ -402,11 +417,13 @@ TEST_F(SketchObjectTest, testGetPointFromGeomBSplineCurvePeriodic)
402417
// TODO: Maybe we want this to give an error instead of some default value
403418
auto ptStart = Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::start);
404419
// TODO: Maybe we want this to give an error instead of some default value
405-
auto ptMid = Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::mid);
420+
[[maybe_unused]] auto ptMid =
421+
Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::mid);
406422
// TODO: Maybe we want this to give an error instead of some default value
407423
auto ptEnd = Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::end);
408424
// TODO: Maybe we want this to give an error instead of some default value
409-
auto ptNone = Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::none);
425+
[[maybe_unused]] auto ptNone =
426+
Sketcher::SketchObject::getPoint(&periodicBSpline, Sketcher::PointPos::none);
410427

411428
// Assert
412429
// With non-trivial values for weights, knots, mults, etc, getting the coordinates is

0 commit comments

Comments
 (0)