Addon Manager: Linter cleanup of new test code

Author: chennes

src/Mod/AddonManager/AddonManagerTest/gui/test_change_branch.py

@@ -21,6 +21,10 @@
 # *                                                                         *
 # ***************************************************************************
 
+""" Test the Change Branch GUI code"""
+
+# pylint: disable=wrong-import-position, deprecated-module, too-many-return-statements
+
 import sys
 import unittest
 from unittest.mock import patch, Mock, MagicMock
@@ -45,11 +49,14 @@
 
 
 class MockFilter(QtCore.QSortFilterProxyModel):
+    """Replaces a filter with a non-filter that simply always returns whatever it's given"""
+
     def mapToSource(self, something):
         return something
 
 
 class MockChangeBranchDialogModel(QtCore.QAbstractTableModel):
+    """Replace a data-connected model with a static one for testing"""
 
     branches = [
         {"ref_name": "ref1", "upstream": "us1"},
@@ -64,16 +71,20 @@ def __init__(self, _: str, parent=None) -> None:
         super().__init__(parent)
 
     def rowCount(self, parent: QtCore.QModelIndex = QtCore.QModelIndex()) -> int:
+        """Number of rows: should always return 3"""
         if parent.isValid():
             return 0
         return len(self.branches)
 
     def columnCount(self, parent: QtCore.QModelIndex = QtCore.QModelIndex()) -> int:
+        """Number of columns (identical to non-mocked version)"""
         if parent.isValid():
             return 0
         return 3  # Local name, remote name, date
 
     def data(self, index: QtCore.QModelIndex, role: int = QtCore.Qt.DisplayRole):
+        """Mock returns static untranslated strings for DisplayRole, no tooltips at all, and otherwise matches
+        the non-mock version"""
         if not index.isValid():
             return None
         row = index.row()
@@ -98,6 +109,7 @@ def headerData(
         orientation: QtCore.Qt.Orientation,
         role: int = QtCore.Qt.DisplayRole,
     ):
+        """Mock returns untranslated strings for DisplayRole, and no tooltips at all"""
         if orientation == QtCore.Qt.Vertical:
             return None
         if role != QtCore.Qt.DisplayRole:
@@ -106,12 +118,13 @@ def headerData(
             return "Local"
         if section == 1:
             return "Remote tracking"
-        elif section == 2:
+        if section == 2:
             return "Last Updated"
-        else:
-            return None
+        return None
 
     def currentBranch(self) -> str:
+        """Mock returns a static string stored in the class: that string could be modified to return something else
+        by tests that require it."""
         return self.current_branch