能否直接在handleClose中 remove channel?

[CottonTnT]

void TcpConnection::handleClose()
{
  loop_->assertInLoopThread();
  LOG_TRACE << "fd = " << channel_->fd() << " state = " << stateToString();
  assert(state_ == kConnected || state_ == kDisconnecting);
  // we don't close fd, leave it to dtor, so we can find leaks easily.
  setState(kDisconnected);
  channel_->disableAll();
  channel->remove();
  TcpConnectionPtr guardThis(shared_from_this());
  //connectionCallback_(guardThis);
  // must be the last line
  closeCallback_(guardThis);
}

为了支持上面的写法我对TcpServer做了如下改造

class TcpServer : std::enable_shared_from_this<TcpServer>

其次是在TcpServer::newConnection注册TcpConnection的closeCallback_时

   conn->setCloseCallback([user_conn_cb = connectionCallback_,a = std::weak_ptr<TcpServer> {shared_from_this()}](const TcpConnectionPtr& conn) {
       // 执行用户回调
       user_conn_cb(conn);
        if (auto guard = a.lock(); guard != nullptr)
        {
            // 执行TcpServer内部的连接移除操作
            guard->removeConnection_(conn);
            return;
        }
    });

然后在TcpServer析构时，比相比重前的muduo在 TcpServer::~TcpServer直接强制关闭连接

TcpServer::~TcpServer()
{
  loop_->assertInLoopThread();
  LOG_TRACE << "TcpServer::~TcpServer [" << name_ << "] destructing";

  for (auto& item : connections_)
  {
    //TcpConnectionPtr conn(item.second);
    //item.second.reset();
    //conn->getLoop()->runInLoop(
    //  std::bind(&TcpConnection::connectDestroyed, conn));
  //
   conn->getLoop()->runInLoop([guard_conn = conn] {
            if (guard_conn->state_ != TcpConnection::kDisconnected)
            {
                guard_conn->handleClose();
            }
        });
   }
}

然后为了保证 一个tcpconnection 只属于一个evenloop, 还是保留了这个函数， 确保其在对应的eventloop 里 析构(虽然感觉没什么必要。。。)

void TcpConnection::connectDestroyed()
{
  loop_->assertInLoopThread();
 // if (state_ == kConnected)
 //{
 //   setState(kDisconnected);
 //  channel_->disableAll();

 //   connectionCallback_(shared_from_this());
 //}
 // channel_->remove();
}