Commit 84f22aa
fix(ws): add NoteDeleteAck and FileDeleteAck to prevent hash orphan on disconnect
Previously, noteDelete/fileDelete removed hash from hashManager in the on-send
callback (when message entered TCP buffer), before server confirmation. If TCP
dropped between send and server receipt, the hash was permanently gone — on
reconnect, the path skipped delNotes and the server file became a permanent orphan.
Introduce NoteDeleteAck/FileDeleteAck responses (symmetric with existing
NoteModifyAck/NoteRenameAck pattern): server sends Ack with lastTime and path
after processing the delete. Client defers hash removal to Ack receipt; on
reconnect, unconfirmed paths remain in hashManager and flow into delNotes naturally.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 29154ce commit 84f22aa
5 files changed
Lines changed: 28 additions & 2 deletions
File tree
- internal
- dto
- routers/websocket_router
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
78 | 85 | | |
79 | 86 | | |
80 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
139 | 142 | | |
140 | 143 | | |
141 | 144 | | |
| |||
166 | 169 | | |
167 | 170 | | |
168 | 171 | | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
169 | 175 | | |
170 | 176 | | |
171 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
415 | | - | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
416 | 419 | | |
417 | 420 | | |
418 | 421 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
527 | | - | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
528 | 531 | | |
529 | 532 | | |
530 | 533 | | |
| |||
0 commit comments