Skip to content

Commit f644f2c

Browse files
committed
Avoid passing Option<&MarkFrame<'_>>.
Two functions take arguments of this type, but the `Option` is always `Some`, so we can just pass `&MarkFrame<'_>` instead.
1 parent 8392220 commit f644f2c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

compiler/rustc_query_system/src/dep_graph/graph.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ impl<D: Deps> DepGraphData<D> {
873873
&self,
874874
qcx: Qcx,
875875
parent_dep_node_index: SerializedDepNodeIndex,
876-
frame: Option<&MarkFrame<'_>>,
876+
frame: &MarkFrame<'_>,
877877
) -> Option<()> {
878878
let get_dep_dep_node = || self.previous.index_to_node(parent_dep_node_index);
879879

@@ -911,7 +911,7 @@ impl<D: Deps> DepGraphData<D> {
911911
);
912912

913913
let node_index =
914-
self.try_mark_previous_green(qcx, parent_dep_node_index, dep_dep_node, frame);
914+
self.try_mark_previous_green(qcx, parent_dep_node_index, dep_dep_node, Some(frame));
915915

916916
if node_index.is_some() {
917917
debug!("managed to MARK dependency {dep_dep_node:?} as green");
@@ -976,7 +976,7 @@ impl<D: Deps> DepGraphData<D> {
976976
let prev_deps = self.previous.edge_targets_from(prev_dep_node_index);
977977

978978
for dep_dep_node_index in prev_deps {
979-
self.try_mark_parent_green(qcx, dep_dep_node_index, Some(&frame))?;
979+
self.try_mark_parent_green(qcx, dep_dep_node_index, &frame)?;
980980
}
981981

982982
// If we got here without hitting a `return` that means that all
@@ -1397,14 +1397,14 @@ impl DepNodeColorMap {
13971397

13981398
#[inline(never)]
13991399
#[cold]
1400-
pub(crate) fn print_markframe_trace<D: Deps>(graph: &DepGraph<D>, frame: Option<&MarkFrame<'_>>) {
1400+
pub(crate) fn print_markframe_trace<D: Deps>(graph: &DepGraph<D>, frame: &MarkFrame<'_>) {
14011401
let data = graph.data.as_ref().unwrap();
14021402

14031403
eprintln!("there was a panic while trying to force a dep node");
14041404
eprintln!("try_mark_green dep node stack:");
14051405

14061406
let mut i = 0;
1407-
let mut current = frame;
1407+
let mut current = Some(frame);
14081408
while let Some(frame) = current {
14091409
let node = data.previous.index_to_node(frame.index);
14101410
eprintln!("#{i} {node:?}");

compiler/rustc_query_system/src/dep_graph/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ pub trait DepContext: Copy {
6363
self,
6464
dep_node: DepNode,
6565
prev_index: SerializedDepNodeIndex,
66-
frame: Option<&MarkFrame<'_>>,
66+
frame: &MarkFrame<'_>,
6767
) -> bool {
6868
let cb = self.dep_kind_info(dep_node.kind);
6969
if let Some(f) = cb.force_from_dep_node {

0 commit comments

Comments
 (0)