apply suggestions from gemini

Author: chenyushuo

tests/buffer/sql_test.py

@@ -43,6 +43,8 @@ async def test_sql_exp_buffer_read_write(self, enable_replay: bool) -> None:
             config.replay_buffer = ReplayBufferConfig(enable=True)
         writer_config = deepcopy(config)
         writer_config.batch_size = put_batch_size
+        # Create buffer by writer, so buffer.batch_size will be set to put_batch_size
+        # This will check whether read_batch_size tasks effect
         sql_writer = SQLWriter(writer_config.to_storage_config())
         sql_reader = SQLReader(config.to_storage_config())
         exps = [

trinity/buffer/storage/sql.py

@@ -197,7 +197,7 @@ def read(self, batch_size: Optional[int] = None, **kwargs) -> List[Experience]:
         if self.stopped:
             raise StopIteration()
 
-        batch_size = batch_size or self.batch_size
+        batch_size = self.batch_size if batch_size is None else batch_size
         return self._read_method(batch_size, **kwargs)
 
     @classmethod
@@ -248,7 +248,7 @@ def read(self, batch_size: Optional[int] = None) -> List[Task]:
             raise StopIteration()
         if self.offset > self.total_samples:
             raise StopIteration()
-        batch_size = batch_size or self.batch_size
+        batch_size = self.batch_size if batch_size is None else batch_size
         with retry_session(self.session, self.max_retry_times, self.max_retry_interval) as session:
             query = (
                 session.query(self.table_model_cls)