Skip to content

Commit 10ddae1

Browse files
committed
Fix span modifier can be overridden
1 parent 906ef14 commit 10ddae1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

grid/src/commonMain/kotlin/com/cheonjaeung/compose/grid/BoxGridSpanModifier.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ internal class BoxGridSpanNode(
3939
) : Modifier.Node(), ParentDataModifierNode {
4040
override fun Density.modifyParentData(parentData: Any?): Any {
4141
val p = parentData as? BoxGridParentData ?: BoxGridParentData()
42-
span?.let {
43-
p.span = it
42+
if (p.span == null) {
43+
p.span = span
4444
}
4545
return p
4646
}

grid/src/commonMain/kotlin/com/cheonjaeung/compose/grid/HorizontalVerticalGridSpanModifier.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ internal class HorizontalVerticalGridSpanNode(
3939
) : Modifier.Node(), ParentDataModifierNode {
4040
override fun Density.modifyParentData(parentData: Any?): Any {
4141
val p = parentData as? HorizontalVerticalGridParentData ?: HorizontalVerticalGridParentData()
42-
p.span = span
42+
if (p.span == HorizontalVerticalGridParentData.DefaultSpan) {
43+
p.span = span
44+
}
4345
return p
4446
}
4547
}

0 commit comments

Comments
 (0)