Skip to content

Commit de1602c

Browse files
committed
fix: add --no-tree-shake-icons flag and disable duplicate release jobs
- Add --no-tree-shake-icons to Flutter builds in package scripts Fixes build failure: "Avoid non-constant invocations of IconData" - Disable build and release jobs in release.yml workflow These jobs duplicated CLI binaries without UI - Update pages job to build Flutter web independently No longer depends on disabled build job This fixes desktop builds (.dmg, .deb) that were failing in v0.1.5
1 parent 44c86c3 commit de1602c

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed

.github/workflows/release.yml

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
jobs:
99
build:
1010
runs-on: ubuntu-latest
11+
if: false # Disabled: use build-desktop.yml instead
1112
steps:
1213
- name: Checkout
1314
uses: actions/checkout@v4
@@ -48,6 +49,7 @@ jobs:
4849
release:
4950
needs: build
5051
runs-on: ubuntu-latest
52+
if: false # Disabled: use build-desktop.yml instead
5153
permissions:
5254
contents: write
5355
steps:
@@ -85,7 +87,6 @@ jobs:
8587
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8688

8789
pages:
88-
needs: build
8990
runs-on: ubuntu-latest
9091
permissions:
9192
contents: read
@@ -95,11 +96,24 @@ jobs:
9596
- name: Checkout
9697
uses: actions/checkout@v4
9798

98-
- name: Download web build
99-
uses: actions/download-artifact@v4
99+
- name: Setup Flutter
100+
uses: subosito/flutter-action@v2
100101
with:
101-
name: webapp
102-
path: webapp
102+
flutter-version: '3.x'
103+
channel: 'stable'
104+
105+
- name: Flutter pub get
106+
working-directory: frontend
107+
run: flutter pub get
108+
109+
- name: Build Flutter web
110+
working-directory: frontend
111+
run: flutter build web --release --no-tree-shake-icons --no-wasm-dry-run
112+
113+
- name: Copy web build
114+
run: |
115+
mkdir -p webapp
116+
cp -R frontend/build/web/* webapp/
103117
104118
- name: Setup Pages
105119
uses: actions/configure-pages@v5

scripts/package-linux.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ cd frontend
4949
flutter clean
5050
flutter pub get
5151
echo " Building with version: $VERSION"
52-
flutter build linux --release --build-name="$VERSION" --build-number="1"
52+
flutter build linux --release --build-name="$VERSION" --build-number="1" --no-tree-shake-icons
5353

5454
BUILD_DIR="build/linux/x64/release/bundle"
5555
if [ ! -d "$BUILD_DIR" ]; then

scripts/package-macos.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ cd frontend
5050
flutter clean
5151
flutter pub get
5252
echo " Building with version: $VERSION"
53-
flutter build macos --release --build-name="$VERSION" --build-number="1"
53+
flutter build macos --release --build-name="$VERSION" --build-number="1" --no-tree-shake-icons
5454

5555
if [ ! -d "build/macos/Build/Products/Release/$BUNDLE_NAME" ]; then
5656
echo -e "${RED}Error: Flutter build failed${NC}"

0 commit comments

Comments
 (0)