Black color on dark bacground

[Xarium]

The text color is black (and thus hard to read) in dark obsidian theme; I suggest the use of the style "color: inherit;" for lowlight and floating.

[dk-a-dev]

resolve it manually
If you used the built in installer:

1. close obsidian
2. go to the folder of your vault ${OBSDIAN_VAULT}.obsidian\plugins\highlightr-plugin
3. open up main.js in you best code editor and go to line 3474 and copy in the extra lines.

addNewStyle(mark, .markdown-preview-view mark, color: inherit;, styleSheet)

5. hit save
6. reopen obsidian

[walrus543]

@dk-a-dev "line 3474" is not quite helpful :)
Are you talking about createStyles function? Please share the whole code of the function with your additional code. Thank you.

[TE-2]

Placing the line in the createStyles function after the loop Object.keys(settings.highlighters).forEach((highlighter) => { ... }); worked for me:

function createStyles(settings) {
    let styleSheet = document.createElement("style");
    setAttributes(styleSheet, {
        type: "text/css",
        id: "highlightr-styles",
    });
    let header = document.getElementsByTagName("HEAD")[0];

    header.appendChild(styleSheet);
    Object.keys(settings.highlighters).forEach((highlighter) => {
        let colorLowercase = highlighter.toLowerCase();
        addNewStyle(`.hltr-${colorLowercase},\nmark.hltr-${colorLowercase},\n.markdown-preview-view mark.hltr-${colorLowercase}`, `background: ${settings.highlighters[highlighter]};`, styleSheet);
    });

    addNewStyle("mark, .markdown-preview-view mark", "color: inherit;", styleSheet);  //<----- add here 
}

[AleMunin]

I'm testing the plugin and this is the first thing I run into.

I'm not familiar with the solution you guys are discussing (rookie on plugins and snippets), but here is what happens on my theme:

I think this could be solved with the option of adding a second class when you create the highlighter

1. .style
2. .text-color

This way if you want one color to be Lowlight but other to be Rounded, you can. The text-color will also make you not need to worry about the theme altogether since people ca just pick it on the plugin settings.