don't log "GC cleanup" events without memory information

Author: chewiebug

src/main/java/com/tagtraum/perf/gcviewer/imp/DataReaderSun1_6_0G1.java

@@ -116,6 +116,7 @@ public class DataReaderSun1_6_0G1 extends AbstractDataReaderSun {
         HEAP_STRINGS.add("class space"); // java 8
         HEAP_STRINGS.add("}");
         HEAP_STRINGS.add("[0x"); // special case of line following one containing a concurrent event mixed with heap information
+        HEAP_STRINGS.add("total"); // special case of line following one containing a concurrent event mixed with heap information
     }
 
     /** is true, if "[Times ..." information is present in the gc log */
@@ -413,7 +414,9 @@ else if (line.indexOf(INCOMPLETE_CONCURRENT_EVENT_INDICATOR) >= 0) {
 
         if (event.getTotal() == 0) {
             // is currently the case for jdk 1.7.0_02 which changed the memory format
-            LOG.warning("line " + lineNumber + ": no memory information found (" + event.toString() + ")");
+            // as of 1.7.0_25 for "GC cleanup" events, there seem to be rare cases, where this just happens
+            // => don't log as warning; just log on debug level
+            if (LOG.isLoggable(Level.FINE)) LOG.fine("line " + lineNumber + ": no memory information found (" + event.toString() + ")");
         }
         model.add(event);
 

src/test/resources/openjdk/SampleSun1_7_0G1_PrintHeapAtGC_withConcurrent.txt

@@ -1,17 +1,17 @@
-2.385: {Heap before GC invocations=166 (full 32):
-[GC concurrent-root-region-scan-end, 0.0000684]
- garbage-first heap  2.385:  total 131072K, used 131072K[GC concurrent-mark-start]
- [0x04800000, 0x0c800000, 0x0c800000)
-  region size 8192K, 1 young (8192K), 1 survivors (8192K)
- compacting perm gen  total 8192K, used 1626K [0x0c800000, 0x0d000000, 0x10800000)
-   the space 8192K,  19% used [0x0c800000, 0x0c996bd0, 0x0c996c00, 0x0d000000)
-No shared spaces configured.
-2.385: [Full GC 128M->57M(128M), 0.0326402 secs]
- [Times: user=0.05 sys=0.00, real=0.05 secs] 
-Heap after GC invocations=167 (full 33):
- garbage-first heap   total 131072K, used 59219K [0x04800000, 0x0c800000, 0x0c800000)
-  region size 8192K, 0 young (0K), 0 survivors (0K)
- compacting perm gen  total 8192K, used 1626K [0x0c800000, 0x0d000000, 0x10800000)
-   the space 8192K,  19% used [0x0c800000, 0x0c996bd0, 0x0c996c00, 0x0d000000)
-No shared spaces configured.
-}
+2.385: {Heap before GC invocations=166 (full 32):
+[GC concurrent-root-region-scan-end, 0.0000684]
+ garbage-first heap  2.385:  total 131072K, used 131072K[GC concurrent-mark-start]
+ [0x04800000, 0x0c800000, 0x0c800000)
+  region size 8192K, 1 young (8192K), 1 survivors (8192K)
+ compacting perm gen  total 8192K, used 1626K [0x0c800000, 0x0d000000, 0x10800000)
+   the space 8192K,  19% used [0x0c800000, 0x0c996bd0, 0x0c996c00, 0x0d000000)
+No shared spaces configured.
+2.385: [Full GC 128M->57M(128M), 0.0326402 secs]
+ [Times: user=0.05 sys=0.00, real=0.05 secs] 
+Heap after GC invocations=167 (full 33):
+ garbage-first heap   total 131072K, used 59219K [0x04800000, 0x0c800000, 0x0c800000)
+  region size 8192K, 0 young (0K), 0 survivors (0K)
+ compacting perm gen  total 8192K, used 1626K [0x0c800000, 0x0d000000, 0x10800000)
+   the space 8192K,  19% used [0x0c800000, 0x0c996bd0, 0x0c996c00, 0x0d000000)
+No shared spaces configured.
+}