Merge PR #235: ci: Upgrade compilers

- Upgrade clang-tidy config for version 16
- Upgrade Python build config at CI
- Upgrade compilers to GCC 13 and Clang 16 at CI

Author: chfast

.clang-tidy

@@ -20,8 +20,10 @@ Checks: >
   cert-oop57-cpp,
   cert-oop58-cpp,
   clang-analyzer-*,
+  -clang-analyzer-deadcode.DeadStores,
   cppcoreguidelines-*,
   -cppcoreguidelines-avoid-c-arrays,
+  -cppcoreguidelines-avoid-const-or-ref-data-members,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-avoid-non-const-global-variables,
   -cppcoreguidelines-init-variables,
@@ -43,9 +45,12 @@ Checks: >
   misc-*,
   -misc-const-correctness,
   -misc-non-private-member-variables-in-classes,
+  -misc-use-anonymous-namespace,
   modernize-*,
   -modernize-avoid-c-arrays,
+  -modernize-unary-static-assert,
   -modernize-use-auto,
+  -modernize-use-nodiscard,
   -modernize-use-trailing-return-type,
   performance-*,
   portability-*,

circle.yml

@@ -21,7 +21,7 @@ commands:
           name: "Install powerpc64 toolchain"
           command: |
             sudo apt -q update
-            sudo apt -qy install g++-powerpc64-linux-gnu qemu-user-static
+            sudo apt -qy install g++-powerpc64-linux-gnu lcov qemu-user-static
 
   configure:
     steps:
@@ -86,8 +86,18 @@ commands:
         type: string
     steps:
       - run:
-          name: "Upgrade codecov"
-          command: sudo pip3 install --break-system-packages --upgrade --quiet --no-cache-dir codecov
+          name: "Install codecov"
+          command: |
+            export CODECOV_VERSION=v0.6.2
+            curl -Os https://uploader.codecov.io/$CODECOV_VERSION/linux/codecov
+            curl -Os https://uploader.codecov.io/$CODECOV_VERSION/linux/codecov.SHA256SUM
+            curl -Os https://uploader.codecov.io/$CODECOV_VERSION/linux/codecov.SHA256SUM.sig
+
+            gpgv codecov.SHA256SUM.sig codecov.SHA256SUM
+            shasum -c codecov.SHA256SUM
+
+            chmod +x codecov
+            sudo mv codecov /usr/local/bin
       - run:
           name: "Upload to Codecov"
           command: |
@@ -117,7 +127,7 @@ jobs:
 
   linux-gcc-coverage:
     docker:
-      - image: ethereum/cpp-build-env:19-gcc-12
+      - image: ethereum/cpp-build-env:20-gcc-13
     environment:
       - BUILD_TYPE: Coverage
     steps:
@@ -145,7 +155,7 @@ jobs:
 
   linux-clang-sanitizers:
     docker:
-      - image: ethereum/cpp-build-env:19-clang-15
+      - image: ethereum/cpp-build-env:20-clang-16
     environment:
       - CMAKE_OPTIONS: -DSANITIZE=address,undefined,unsigned-integer-overflow,shift-exponent,implicit-conversion,nullability -DCMAKE_CXX_CLANG_TIDY=clang-tidy
       - ASAN_OPTIONS: allocator_may_return_null=1
@@ -159,7 +169,7 @@ jobs:
 
   linux-32bit-asan:
     docker:
-      - image: ethereum/cpp-build-env:19-gcc-12-multilib
+      - image: ethereum/cpp-build-env:20-gcc-13-multilib
     environment:
       - BUILD_TYPE: RelWithDebInfo
       - CMAKE_OPTIONS: -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/32bit.cmake -DSANITIZE=address
@@ -173,13 +183,16 @@ jobs:
 
   powerpc64:
     docker:
-      - image: ethereum/cpp-build-env:19-gcc-12
+      - image: cimg/base:current-22.04
     environment:
       - TESTS_EXCLUDE: _oom|_multithreaded
       - BUILD_TYPE: Coverage
       - CMAKE_OPTIONS: -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/powerpc64.cmake -DCMAKE_EXE_LINKER_FLAGS=-static
     steps:
       - checkout
+      - run:
+          name: Install codecov GPG key
+          command: curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import
       - install-powerpc64
       - configure
       - build-tests
@@ -193,9 +206,9 @@ jobs:
 
   linux-release:
     docker:
-      - image: ethereum/cpp-build-env:16-clang-11
+      - image: ethereum/cpp-build-env:20-gcc-12
     environment:
-      - CMAKE_OPTIONS: -DETHASH_TESTING=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON
+      CMAKE_OPTIONS: -DETHASH_TESTING=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON
     steps:
       - checkout
       - configure
@@ -207,11 +220,17 @@ jobs:
 
   linux-release-python:
     docker:
-      - image: quay.io/pypa/manylinux_2_24_x86_64
+      - image: quay.io/pypa/manylinux_2_28_x86_64
+    environment:
+      CMAKE_OPTIONS: >
+        -DETHASH_TESTING=OFF 
+        -DCMAKE_POSITION_INDEPENDENT_CODE=ON 
+        -DCMAKE_INSTALL_PREFIX=~/project/dist
+        -DCMAKE_INSTALL_LIBDIR=lib
     steps:
       - checkout
-      - attach_workspace:
-          at: ~/project/dist
+      - configure
+      - build
       - run:
           name: "Build wheels"
           command: scripts/ci/python_build_wheels.sh
@@ -223,7 +242,7 @@ jobs:
       - run:
           name: "Select Python"
           command: |
-            echo 'export PATH=/opt/python/cp310-cp310/bin:$PATH' >> $BASH_ENV
+            echo 'export PATH=/opt/python/cp311-cp311/bin:$PATH' >> $BASH_ENV
             source $BASH_ENV
             python --version
             pip --version
@@ -233,12 +252,6 @@ jobs:
       - store_artifacts:
           path: ~/project/dist
           destination: dist
-      - run:
-          name: "Install libffi"
-          command: apt -q update && apt -qy install libffi-dev
-      - run:
-          name: "Install CMake"
-          command: pip install cmake
       - run:
           name: "Build wheel with CMake build"
           command: ./setup.py bdist_wheel
@@ -248,7 +261,7 @@ jobs:
 
   macos-xcode-tsan:
     macos:
-      xcode: "13.4.1"
+      xcode: 14.3.1
     environment:
       - CMAKE_OPTIONS: -DSANITIZE=thread
       - TSAN_OPTIONS: allocator_may_return_null=1
@@ -257,13 +270,13 @@ jobs:
 
   macos-xcode-old:
     macos:
-      xcode: "12.5.1"
+      xcode: 12.5.1
     steps:
       - macos-defaults
 
   macos-release:
     macos:
-      xcode: "13.4.1"
+      xcode: 14.3.1
     environment:
       - CMAKE_OPTIONS: -DETHASH_TESTING=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_INSTALL_PREFIX=~/project/dist
     steps:
@@ -321,9 +334,7 @@ workflows:
       - macos-xcode-tsan
       - macos-xcode-old
       - linux-release
-      - linux-release-python:
-          requires:
-            - linux-release
+      - linux-release-python
       - macos-release
       - cmake-min
       - wasi

scripts/ci/python_build_wheels.sh

@@ -7,11 +7,14 @@
 
 set -eo pipefail
 
+ACTIVATE_DIR=bin
+
 if [ -n "$APPVEYOR" ]; then
-    PYTHON_PATHS="/c/Python310-x64:/c/Python310-x64/Scripts /c/Python39-x64:/c/Python39-x64/Scripts /c/Python38-x64:/c/Python38-x64/Scripts /c/Python37-x64:/c/Python37-x64/Scripts"
+    ACTIVATE_DIR=Scripts
+    PYTHON_PATHS="/c/Python311-x64:/c/Python311-x64/Scripts /c/Python310-x64:/c/Python310-x64/Scripts /c/Python39-x64:/c/Python39-x64/Scripts /c/Python38-x64:/c/Python38-x64/Scripts"
 elif [ -n "$CIRCLECI" ]; then
     if [ "$OSTYPE" = "linux-gnu" ]; then
-        PYTHON_PATHS="/opt/python/cp310-cp310/bin /opt/python/cp39-cp39/bin /opt/python/cp38-cp38/bin /opt/python/cp37-cp37m/bin /opt/python/cp36-cp36m/bin"
+        PYTHON_PATHS="/opt/python/cp311-cp311/bin /opt/python/cp310-cp310/bin /opt/python/cp39-cp39/bin /opt/python/cp38-cp38/bin"
     else
         # The continuation of the script expects "python" executable name,
         # so make link python -> python3.
@@ -25,12 +28,16 @@ PATH_ORIG=$PATH
 for p in $PYTHON_PATHS
 do
     PATH="$p:$PATH_ORIG"
+    python -m venv venv
+    source venv/$ACTIVATE_DIR/activate
     echo '***'
     python --version
     which python
-    python -m pip --version
+    pip --version
     echo '***'
-    python -m pip install wheel
+    pip install --use-pep517 wheel
     python setup.py build_ext --skip-cmake-build
     python setup.py bdist_wheel --skip-build
+    deactivate
+    rm -rf venv
 done