Skip to content

Commit f0b5aff

Browse files
ChristopherHXtechknowlogick
authored andcommitted
fix: invalid label NoInteractive exit code (#683)
* add test * return validation error not nil from function Closes #665 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/683 Reviewed-by: techknowlogick <[email protected]> Co-authored-by: Christopher Homberger <[email protected]> Co-committed-by: Christopher Homberger <[email protected]>
1 parent 44b4736 commit f0b5aff

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

internal/app/cmd/register.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ func registerNoInteractive(ctx context.Context, configFile string, regArgs *regi
281281
}
282282
if err := inputs.validate(); err != nil {
283283
log.WithError(err).Errorf("Invalid input, please re-run act command.")
284-
return nil
284+
return err
285285
}
286286
if err := doRegister(ctx, cfg, inputs); err != nil {
287287
return fmt.Errorf("Failed to register runner: %w", err)

internal/app/cmd/register_test.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
// Copyright 2025 The Gitea Authors. All rights reserved.
2+
// SPDX-License-Identifier: MIT
3+
4+
package cmd
5+
6+
import (
7+
"testing"
8+
9+
"gotest.tools/v3/assert"
10+
)
11+
12+
func TestRegisterNonInteractiveReturnsLabelValidationError(t *testing.T) {
13+
err := registerNoInteractive(t.Context(), "", &registerArgs{
14+
Labels: "label:invalid",
15+
Token: "token",
16+
InstanceAddr: "http://localhost:3000",
17+
})
18+
assert.Error(t, err, "unsupported schema: invalid")
19+
}

0 commit comments

Comments
 (0)