test: add valueSyntax coverage

Author: chhoumann

src/formatters/completeFormatter.ts

@@ -24,7 +24,7 @@ import {
 	generateFieldCacheKey,
 } from "../utils/FieldValueCollector";
 import { FieldValueProcessor } from "../utils/FieldValueProcessor";
-import { Formatter } from "./formatter";
+import { Formatter, type PromptContext } from "./formatter";
 import { MacroAbortError } from "../errors/MacroAbortError";
 import { isCancellationError } from "../utils/errorUtils";
 
@@ -192,15 +192,7 @@ export class CompleteFormatter extends Formatter {
 
 	protected async promptForVariable(
 		header?: string,
-		context?: {
-			type?: string;
-			dateFormat?: string;
-			defaultValue?: string;
-			label?: string;
-			description?: string;
-			placeholder?: string;
-			variableKey?: string;
-		},
+		context?: PromptContext,
 	): Promise<string> {
 		try {
 			// Use VDateInputPrompt for VDATE variables
@@ -217,7 +209,7 @@ export class CompleteFormatter extends Formatter {
 			// Use default prompt for other variables
 			return await new InputPrompt().factory().Prompt(
 				this.app,
-				(header as string) ?? context?.label ?? "Enter value",
+				header ?? context?.label ?? "Enter value",
 				context?.placeholder ??
 					(context?.defaultValue ? context.defaultValue : undefined),
 				context?.defaultValue,

src/formatters/fileNameDisplayFormatter.ts

@@ -1,4 +1,4 @@
-import { Formatter } from "./formatter";
+import { Formatter, type PromptContext } from "./formatter";
 import type { App } from "obsidian";
 import { DATE_VARIABLE_REGEX, GLOBAL_VAR_REGEX } from "../constants";
 import type { IDateParser } from "../parsers/IDateParser";
@@ -109,15 +109,7 @@ export class FileNameDisplayFormatter extends Formatter {
 
 	protected async promptForVariable(
 		variableName: string,
-		context?: {
-			type?: string;
-			dateFormat?: string;
-			defaultValue?: string;
-			label?: string;
-			description?: string;
-			placeholder?: string;
-			variableKey?: string;
-		}
+		context?: PromptContext
 	): Promise<string> {
 		return getVariablePromptExample(variableName);
 	}

src/formatters/formatDisplayFormatter.ts

@@ -1,4 +1,4 @@
-import { Formatter } from "./formatter";
+import { Formatter, type PromptContext } from "./formatter";
 import type { App } from "obsidian";
 import type QuickAdd from "../main";
 import { SingleTemplateEngine } from "../engine/SingleTemplateEngine";
@@ -112,15 +112,7 @@ export class FormatDisplayFormatter extends Formatter {
 
 	protected promptForVariable(
 		variableName: string,
-		context?: {
-			type?: string;
-			dateFormat?: string;
-			defaultValue?: string;
-			label?: string;
-			description?: string;
-			placeholder?: string;
-			variableKey?: string;
-		}
+		context?: PromptContext
 	): Promise<string> {
 		return Promise.resolve(getVariablePromptExample(variableName));
 	}

src/formatters/formatter.ts

@@ -31,6 +31,16 @@ import { parseMacroToken } from "../utils/macroSyntax";
 
 export type LinkToCurrentFileBehavior = "required" | "optional";
 
+export interface PromptContext {
+	type?: string;
+	dateFormat?: string;
+	defaultValue?: string;
+	label?: string;
+	description?: string;
+	placeholder?: string;
+	variableKey?: string;
+}
+
 export abstract class Formatter {
 	protected value: string;
 	protected variables: Map<string, unknown> = new Map<string, unknown>();
@@ -563,15 +573,7 @@ export abstract class Formatter {
 
 	protected abstract promptForVariable(
 		variableName: string,
-		context?: {
-			type?: string;
-			dateFormat?: string;
-			defaultValue?: string;
-			label?: string;
-			description?: string;
-			placeholder?: string;
-			variableKey?: string;
-		}
+		context?: PromptContext,
 	): Promise<string>;
 
 	protected abstract getTemplateContent(templatePath: string): Promise<string>;

src/preflight/RequirementCollector.ts

@@ -1,6 +1,6 @@
 import type { App } from "obsidian";
 import { GLOBAL_VAR_REGEX, TEMPLATE_REGEX, VARIABLE_REGEX } from "src/constants";
-import { Formatter } from "src/formatters/formatter";
+import { Formatter, type PromptContext } from "src/formatters/formatter";
 import type { IChoiceExecutor } from "src/IChoiceExecutor";
 import type QuickAdd from "src/main";
 import { NLDParser } from "src/parsers/NLDParser";
@@ -205,15 +205,7 @@ export class RequirementCollector extends Formatter {
 
 	protected async promptForVariable(
 		variableName?: string,
-		context?: {
-			type?: string;
-			dateFormat?: string;
-			defaultValue?: string;
-			label?: string;
-			description?: string;
-			placeholder?: string;
-			variableKey?: string;
-		},
+		context?: PromptContext,
 	): Promise<string> {
 		if (!variableName) return "";
 		const key = context?.variableKey ?? variableName;

src/utils/valueSyntax.test.ts

@@ -0,0 +1,44 @@
+import { describe, expect, it } from "vitest";
+import {
+	buildValueVariableKey,
+	parseValueToken,
+} from "./valueSyntax";
+
+describe("parseValueToken", () => {
+	it("ignores empty label values", () => {
+		const parsed = parseValueToken("title|label:");
+		expect(parsed).not.toBeNull();
+		expect(parsed?.label).toBeUndefined();
+		expect(parsed?.variableKey).toBe("title");
+	});
+
+	it("uses the last label when multiple are provided", () => {
+		const parsed = parseValueToken("title|label:First|label:Second");
+		expect(parsed?.label).toBe("Second");
+	});
+
+	it("scopes list variables by label", () => {
+		const parsed = parseValueToken("a,b|label:Priority");
+		expect(parsed?.hasOptions).toBe(true);
+		const expectedKey = buildValueVariableKey("a,b", "Priority", true);
+		expect(parsed?.variableKey).toBe(expectedKey);
+	});
+
+	it("treats bare label option as legacy default", () => {
+		const parsed = parseValueToken("title|label");
+		expect(parsed?.label).toBeUndefined();
+		expect(parsed?.defaultValue).toBe("label");
+	});
+
+	it("parses custom boolean values", () => {
+		expect(parseValueToken("a,b|custom:")?.allowCustomInput).toBe(true);
+		expect(parseValueToken("a,b|custom:false")?.allowCustomInput).toBe(false);
+		expect(parseValueToken("a,b|custom:0")?.allowCustomInput).toBe(false);
+	});
+
+	it("allows custom plus explicit default", () => {
+		const parsed = parseValueToken("a,b|custom|default:High");
+		expect(parsed?.allowCustomInput).toBe(true);
+		expect(parsed?.defaultValue).toBe("High");
+	});
+});