refactor: share VALUE label key helper

Author: chhoumann

src/preflight/RequirementCollector.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect } from "vitest";
 import { RequirementCollector } from "./RequirementCollector";
-import { parseValueToken } from "src/utils/valueSyntax";
+import { buildValueVariableKey } from "src/utils/valueSyntax";
 
 // Light stubs for app/plugin
 const makeApp = () => ({
@@ -37,10 +37,13 @@ describe("RequirementCollector", () => {
 
     expect(byId["title"].label).toBe("title");
     expect(byId["title"].description).toBe("Snake cased name");
-    const parsed = parseValueToken(multiToken);
-    expect(parsed).not.toBeNull();
-    expect(byId[parsed!.variableKey].label).toBe("Priority");
-    expect(byId[parsed!.variableKey].type).toBe("dropdown");
+    const variableKey = buildValueVariableKey(
+      "low,medium,high",
+      "Priority",
+      true,
+    );
+    expect(byId[variableKey].label).toBe("Priority");
+    expect(byId[variableKey].type).toBe("dropdown");
   });
 
   it("collects VDATE with format and default", async () => {

src/utils/valueSyntax.ts

@@ -14,6 +14,16 @@ export type ParsedValueToken = {
 	hasOptions: boolean;
 };
 
+export function buildValueVariableKey(
+	variableName: string,
+	label: string | undefined,
+	hasOptions: boolean,
+): string {
+	return hasOptions && label
+		? `${variableName}${VALUE_LABEL_KEY_DELIMITER}${label}`
+		: variableName;
+}
+
 type ParsedOptions = {
 	label?: string;
 	defaultValue: string;
@@ -125,10 +135,7 @@ export function parseValueToken(raw: string): ParsedValueToken | null {
 		defaultValue = allowCustomInput ? "" : legacyDefault;
 	}
 
-	const variableKey =
-		hasOptions && label
-			? `${variablePart}${VALUE_LABEL_KEY_DELIMITER}${label}`
-			: variablePart;
+	const variableKey = buildValueVariableKey(variablePart, label, hasOptions);
 
 	return {
 		raw,