fixed favicon.ico error

Author: chichutschang

app.js

@@ -37,11 +37,16 @@ app.use('/', indexRouter);
 //console.dir(indexRouter);
 app.use('/users', usersRouter);
 app.use('/jquery', express.static(__dirname + '/node_modules/jquery/dist/'));
-// catch 404 and forward to error handler
+//catch 404 and forward to error handler
 app.use(function(req, res, next) {
   next(createError(404));
 });
 
+//respond with 204 error code (no content) when getting favicon.ico
+app.get('/favicon.ico', function(req, res) { 
+  res.sendStatus(204); 
+});
+
 // error handler
 app.use(function(err, req, res, next) {
   // set locals, only providing error in development

public/images/tschang.ico renamed to public/images/favicon.ico

@@ -40,13 +40,13 @@ router.get('/resume', function(req, res, next) {
 });
 
 /* GET teaching page. */
-router.get('/teaching/english1', function(req, res) {
-  res.render('english1', { title: 'English 1' });
+router.get('/teaching/english9', function(req, res) {
+  res.render('english9', { title: 'English 9' });
 });
 
 /* GET teaching page. */
-router.get('/teaching/english2', function(req, res) {
-  res.render('english2', { title: 'English 2' });
+router.get('/teaching/english10', function(req, res) {
+  res.render('english10', { title: 'English 10' });
 });
 
 /* GET learning page. */

routes/index.js

@@ -2,5 +2,5 @@
 <meta name="author" content="Chi-Chu Tschang">
 <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=no">
 <meta name="description" content="chi-chu.tschang.net is the personal website of Chi-Chu Tschang">
-<link rel="shortcut icon" href="data:;base64,iVBORw0KGgo="> 
+<link rel="icon" href="/images/favicon.ico" type="image/x-icon">
 <title>chi-chu.tschang.net</title>

views/partials/head.ejs

@@ -23,15 +23,15 @@
         <li class="nav-link"><a href="/">home</a></li>
         <li class="nav-link"><a href="/resume">resume</a></li>
         <li class="nav-link"><a href="/learning">learning</a></li>
-        <li class="nav-link"><a href="/teaching/english1">teaching</a></li> 
+        <li class="nav-link"><a href="/teaching/english9">teaching</a></li> 
         <li class="nav-link"><a href="/reading">reading</a></li>
         <li class="nav-link"><a href="https://www.bloomberg.com/authors/AE_Git5xwiE/chichu-tschang">writing</a></li>
         <li class="nav-link"><a href="/projects">projects</a></li>
       </ul>
 
       <div id="header">
         <!-- add icon link -->
-        <link rel="icon" href="/images/favicon.ico" type="/image/icon">
+        <link rel="icon" href="/images/favicon.ico" type="image/x-icon">
         <a href="/"><div id="header_left"><img src="/images/chichutschanglogo.jpg" width="50" height="auto"></div></a>
         <a href="/"><div id="header_right"><img src="/images/chi-chu.tschang.png" width="175" height="auto"></div></a>
       </div>